Skip to content

Nuvoton: Remove SD component from targets.json #10178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2019

Conversation

ccli8
Copy link
Contributor

@ccli8 ccli8 commented Mar 21, 2019

Description

Nuvoton targets below don't provide SPI-bus SD on-board, identified by SD in
target component list. Instead, these targets provide SD-bus SD on-board, identified
by unofficial NUSD, driver of which is provided outside mbed-os tree. So SD must
be removed to reflect the truth.

  • NUMAKER_PFM_NUC472
  • NUMAKER_PFM_M487
  • NUMAKER_IOT_M487
  • NUMAKER_PFM_M2351

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Nuvoton targets below don't provide SPI-bus SD on-board, identified by 'SD' in
target component list. Instead, these targets provide SD-bus SD on-board, identified
by unofficial 'NUSD', driver of which is provided outside mbed-os tree. So 'SD' must
be removed to reflect the truth.

- NUMAKER_PFM_NUC472
- NUMAKER_PFM_M487
- NUMAKER_IOT_M487
- NUMAKER_PFM_M2351
@ciarmcom ciarmcom requested a review from a team March 21, 2019 06:00
@ciarmcom
Copy link
Member

@ccli8, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 21, 2019

cc @ARMmbed/mbed-os-storage

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 21, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Mar 21, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit d6908ce into ARMmbed:master Mar 22, 2019
@cyliangtw cyliangtw deleted the nuvoton_fix_stor_cmpt branch March 9, 2023 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants