Skip to content

test_configs: generic app config for boards with Wi-Fi #10105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2019
Merged

test_configs: generic app config for boards with Wi-Fi #10105

merged 1 commit into from
Mar 19, 2019

Conversation

VeijoPesonen
Copy link
Contributor

@VeijoPesonen VeijoPesonen commented Mar 14, 2019

Description

To be used at least with ESP32 which has all required settings already in its mbed_lib.json. I assume this only works with drivers pulled from external repositories as there can be only be one default network interface.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[X] Test update
[ ] Breaking change

Reviewers

@SeppoTakalo
@OPpuolitaival

Release Notes

@ciarmcom ciarmcom requested review from OPpuolitaival, SeppoTakalo and a team March 14, 2019 16:00
@ciarmcom
Copy link
Member

@VeijoPesonen, thank you for your changes.
@SeppoTakalo @OPpuolitaival @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@SeppoTakalo
Copy link
Contributor

This should work with built-in WiFi as well.

@NirSonnenschein
Copy link
Contributor

starting CI

@mbed-ci
Copy link

mbed-ci commented Mar 17, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@NirSonnenschein
Copy link
Contributor

passed CI and should be ready.
@OPpuolitaival would you like to review before it gets merged?

@0xc0170 0xc0170 merged commit a23d105 into ARMmbed:master Mar 19, 2019
@VeijoPesonen VeijoPesonen deleted the esp32_app_config branch March 19, 2019 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants