Grab the low-hanging fruit from forcing USE_FLOAT8_BYVAL to true.
authorTom Lane <[email protected]>
Wed, 13 Aug 2025 21:18:13 +0000 (17:18 -0400)
committerTom Lane <[email protected]>
Wed, 13 Aug 2025 21:18:22 +0000 (17:18 -0400)
commitee54046601de2d14ca9107ba04c50178d9b52fe6
tree3950eafde3f8a7bc96cb47741942962abe3ac2c6
parent6aebedc38497ecebda22caf61bcadf78a8331b52
Grab the low-hanging fruit from forcing USE_FLOAT8_BYVAL to true.

Remove conditionally-compiled code for the other case.

Replace uses of FLOAT8PASSBYVAL with constant "true", mainly because
it was quite confusing in cases where the type we were dealing with
wasn't float8.

I left the associated pg_control and Pg_magic_struct fields in place.
Perhaps we should get rid of them, but it would save little, so it
doesn't seem worth thinking hard about the compatibility implications.
I just labeled them "vestigial" in places where that seemed helpful.

Author: Tom Lane <[email protected]>
Reviewed-by: Peter Eisentraut <[email protected]>
Discussion: https://postgr.es/m/1749799.1752797397@sss.pgh.pa.us
22 files changed:
contrib/btree_gist/btree_time.c
contrib/btree_gist/btree_ts.c
src/backend/access/common/tupdesc.c
src/backend/access/index/indexam.c
src/backend/access/transam/xlog.c
src/backend/catalog/genbki.pl
src/backend/optimizer/plan/planagg.c
src/backend/optimizer/plan/planner.c
src/backend/parser/parse_node.c
src/backend/rewrite/rewriteSearchCycle.c
src/backend/utils/adt/arrayfuncs.c
src/backend/utils/adt/int8.c
src/backend/utils/adt/numeric.c
src/backend/utils/adt/orderedsetaggs.c
src/backend/utils/adt/rangetypes_typanalyze.c
src/backend/utils/fmgr/fmgr.c
src/bin/initdb/initdb.c
src/bin/pg_resetwal/pg_resetwal.c
src/include/c.h
src/include/catalog/pg_type.dat
src/include/fmgr.h
src/include/postgres.h