Fix inconsistent reporting of checkpointer stats.
authorFujii Masao <[email protected]>
Wed, 2 Oct 2024 02:17:47 +0000 (11:17 +0900)
committerFujii Masao <[email protected]>
Wed, 2 Oct 2024 02:17:47 +0000 (11:17 +0900)
commit17cc5f666f6aada21eb3237974c50681ba4814ea
treea8d3fad9a3262e2b9d7d82fae23a78cddc1cadde
parent506eede7111ae7c88bd3c21f653bbb65846bd4a5
Fix inconsistent reporting of checkpointer stats.

Previously, the pg_stat_checkpointer view and the checkpoint completion
log message could show different numbers for buffers written
during checkpoints. The view only counted shared buffers,
while the log message included both shared and SLRU buffers,
causing inconsistencies.

This commit resolves the issue by updating both the view and the log message
to separately report shared and SLRU buffers written during checkpoints.
A new slru_written column is added to the pg_stat_checkpointer view
to track SLRU buffers, while the existing buffers_written column now
tracks only shared buffers. This change would help users distinguish
between the two types of buffers, in the pg_stat_checkpointer view and
the checkpoint complete log message, respectively.

Bump catalog version.

Author: Nitin Jadhav
Reviewed-by: Bharath Rupireddy, Michael Paquier, Kyotaro Horiguchi, Robert Haas
Reviewed-by: Andres Freund, vignesh C, Fujii Masao
Discussion: https://postgr.es/m/CAMm1aWb18EpT0whJrjG+-nyhNouXET6ZUw0pNYYAe+NezpvsAA@mail.gmail.com
doc/src/sgml/monitoring.sgml
src/backend/access/transam/slru.c
src/backend/access/transam/xlog.c
src/backend/catalog/system_views.sql
src/backend/utils/activity/pgstat_checkpointer.c
src/backend/utils/adt/pgstatfuncs.c
src/include/access/xlog.h
src/include/catalog/catversion.h
src/include/catalog/pg_proc.dat
src/include/pgstat.h
src/test/regress/expected/rules.out