Nominating Eric Astor as the maintainer for llvm-ml and Masm related functionality

Hey folks! I wanted to nominate @ericastor as a maintainer for all Microsoft assembler related functionality in LLVM. He has a large body of work contributing to masm over multiple years (logs), and it’s mostly focused on adding masm functionality and compatibility.

Assembler compatibility is a difficult area, and it’s easy to make short term compromises to improve compatibility while compromising the overall complexity of the shared assembler codebase, but I think Eric has demonstrated through careful code review that he knows how to navigate these concerns and minimize the overall burden of masm compatibility support. I felt it was a good time to recognize his significant contributions in this area and nominate him as the maintainer for the area. Thank you, Eric, for your continued contributions!

I roughly summarize the maintainer responsibilities as “provide code review, and help triage issues”. The linked docs paint a more full picture. Let us know if you accept the nomination, and I can send a PR and will get it stamped by the LLVM area team leads.

2 Likes

Thank you - I’d be glad to take this on!

One slight caveat - I’ve had trouble getting code reviews for my own work on this subject lately, since we seem to have a shortage of people actively involved in MC, and most of them think that MASM is a particularly strange breed of animal. (They’re correct, for what it’s worth.) Will this make getting reviewers easier, or harder? :grin:

1 Like