test1119: scan all public headers #9544
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6387fb4 to
75f66f8
Compare
|
This updated scan also correctly finds the #9552 issue, a wrongly spelled |
|
#9523 fixes that issue, and I will rerun this build once that has landed to confirm. |
Previously this test only scanned a subset of the headers, which made us accidentally miss symbols that were provided in the others. Now, the script iterates over all headers present in include/curl.
This script now also finds all .3 man pages in docs/include and docs/include/opts, extracts all uses of CURL* symbols and verifies that all symbols mentioned in docs are defined in public headers. A "global symbol" is one of those matching a known prefix and the script makes an attempt to check all/most of them. Just using *all* symbols that match CURL* proved matching a little too many other references as well and turned difficult turning into something useful.
The same error and comment were also used and is now corrected in CURLOPT_SSH_KEYFUNCTION.3
75f66f8 to
b33c49f
Compare
bagder
added a commit
that referenced
this pull request
Sep 22, 2022
bagder
added a commit
that referenced
this pull request
Sep 22, 2022
This script now also finds all .3 man pages in docs/include and docs/include/opts, extracts all uses of CURL* symbols and verifies that all symbols mentioned in docs are defined in public headers. A "global symbol" is one of those matching a known prefix and the script makes an attempt to check all/most of them. Just using *all* symbols that match CURL* proved matching a little too many other references as well and turned difficult turning into something useful. Closes #9544
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this test only scanned a subset of the headers, which made us accidentally miss symbols that were provided in the others. Now, the script iterates over all headers present in include/curl.