http: disallow > 3-digit response codes #7641
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/http.c
Outdated
| if(baddigit != -1) { | ||
| failf(data, "Unsupported response code in HTTP response"); | ||
| return CURLE_UNSUPPORTED_PROTOCOL; | ||
| } |
There was a problem hiding this comment.
Shouldn't this also inspect nc to just to be on the safe side?
There was a problem hiding this comment.
Hm, maybe that's better for readability but surely baddigit cannot be assigned anything if the other fields didn't already get stored?
There was a problem hiding this comment.
ah no, the check below will be skipped ... updating!
There was a problem hiding this comment.
I went with an explanatory comment instead. What do you think @danielgustafsson ?
Make the built-in HTTP parser behave similar to hyper and reject any HTTP response using more than 3 digits for the response code. Updated test 1432 accordingly. Enabled test 1432 in the hyper builds. Closes #7641
eefd539 to
5a82f54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the built-in HTTP parser behave similar to hyper and reject any
HTTP response using more than 3 digits for the response code.
Updated test 1432 accordingly.
Enabled test 1432 in the hyper builds.