sasl: binary messages #6930
sasl: binary messages #6930
Conversation
lib/curl_sasl.c
Outdated
| @@ -58,7 +58,7 @@ | |||
| static const struct { | |||
| const char *name; /* Name */ | |||
| size_t len; /* Name length */ | |||
| unsigned int bit; /* Flag bit */ | |||
| unsigned long bit; /* Flag bit */ | |||
There was a problem hiding this comment.
Why this change? We cannot assume that a long is larger than 32 bit anyway... and if you want to store 32 bit, why use 64 bit on some platforms?
There was a problem hiding this comment.
HTTP authentication flags are already defined as unsigned long: although not yet related, the idea behind this change is to ease a possible future unification of sasl and http authentication flags.
This is the only reason. But perhaps the change would have to be done the other way on http side, which is not the target of my current work.
I can drop it for now, if you prefer.
0f9373d to
89689b2
Compare
1b5aeb2 to
a3c59af
Compare
427897b to
5f32231
Compare
e63efec to
b0824fc
Compare
9362a16 to
1528f7c
Compare
|
IMHO, this is ready for review/pull. |
c95a50f to
ed5f3c0
Compare
7c8ed33 to
0c01ed4
Compare
a777b3f to
5222519
Compare
|
@bagder : Please can you look at this while the feature window is open? Having it unpushed blocks my work on openldap. Thanks. |
|
@monnerat for the future, please request a review of the PR. It's an excellent way to signal that you're ready/done (and a good way for me to spot/filter such PRs). |
Sorry for using a comment for that, but the "request review" icon is sometimes missing. Github bug ? |
Capabilities of sasl module are extended to exchange messages in binary as an alternative to base64. If http authentication flags have been set, those are used as sasl default preferred mechanisms.
|
Thanks! |
|
Thanks to you for pulling. |
Capabilities of sasl module are extended to exchange messages in binary as an alternative to base64.
If http authentication flags have been set, those are used as sasl default preferred mechanisms.