Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Curlrc inconsistent behavior of proxy-user setting #3738

Closed
etasse opened this issue Apr 5, 2019 · 5 comments
Closed

Curlrc inconsistent behavior of proxy-user setting #3738

etasse opened this issue Apr 5, 2019 · 5 comments
Labels
cmdline tool documentation

Comments

@etasse
Copy link

etasse commented Apr 5, 2019 •
edited
Loading

I did this

Insert the following items to the _curlrc file

proxy-ntlm
proxy-user :

to force NTLM authentication using SSPI

Note that adding the line as

--proxy-user :

fixes the problem.

I expected the following

Success 200 OK

But I got

407 ACCESS DENIED
and

Warning: _curlrc:6: warning: 'proxy-user' requires
Warning: parameter

curl/libcurl version

curl 7.64.0 (x86_64-pc-win32) libcurl/7.64.0 OpenSSL/1.1.1b (Schannel) zlib/1.2.11 brotli/1.0.7 WinIDN libssh2/1.8.1 nghttp2/1.37.0
Release-Date: 2019-02-06
Protocols: dict file ftp ftps gopher http https imap imaps ldap ldaps pop3 pop3s rtsp scp sftp smb smbs smtp smtps telnet tftp
Features: AsynchDNS IDN IPv6 Largefile SSPI Kerberos SPNEGO NTLM SSL libz brotli TLS-SRP HTTP2 HTTPS-proxy MultiSSL

operating system

Microsoft Windows [Version 10.0.15063]
@jay
Copy link
Member

jay commented Apr 5, 2019

Reproduced in 7.64.1. -DDEBUG_CONFIG output:

--proxy-user :

GOT: --proxy-user
PARAM: ":"


proxy-user :

GOT: proxy-user
PARAM: "(null)"


proxy-user ":"

GOT: proxy-user
PARAM: ":"

It's happening because the colon is treated as a separator when the option is not dashed.

curl/src/tool_parsecfg.c

Lines 39 to 41 in 521bbbe

/* only acknowledge colon or equals as separators if the option was not
specified with an initial dash! */
#define ISSEP(x,dash) (!dash && (((x) == '=') || ((x) == ':')))

curl/src/tool_parsecfg.c

Lines 164 to 166 in 521bbbe

/* pass spaces and separator(s) */
while(*line && (ISSPACE(*line) || ISSEP(*line, dashed_option)))
line++;

@bagder
Copy link
Member

bagder commented Apr 5, 2019

Right, colon has been supported in config files as a supported separator since the dawn of time basically. The separate handling of dash-dash prefixed entrys came in 0db811b to at least allow exactly what works on the command line.

The man page only shows and mentions '=' as a separator, but I'm still scared of changing this very old functionality as it seems likely to break scripts for users. Tricky!

@etasse
Copy link
Author

etasse commented Apr 6, 2019

I suspect this happens with other switches such as user. So as a general rule it's safest to quote parameters inside curlrc

@bagder
Copy link
Member

bagder commented Apr 7, 2019

it's safest to quote parameters inside curlrc

If the parameter contains white space or starts with ":" or "=" then yes indeed!

@bagder
Copy link
Member

bagder commented Apr 7, 2019

I think the proper fix for this is to make sure this is documented clearly. Like this:

If the parameter contains whitespace (or starts with : or =), the parameter
must be enclosed within quotes.

bagder added a commit that referenced this issue Apr 8, 2019
@bagder
config.d: clarify that initial : and = might need quoting [skip ci]

Verified

This commit was signed with the committer’s verified signature. The key has expired.
mback2k Marc Hörsken
GPG key ID: 61E03CBED7BC859E
Expired
Verified
Learn about vigilant mode
db22cc9 
Fixes #3738
@bagder bagder mentioned this issue Apr 8, 2019
Closed
@bagder bagder closed this as completed in ebb2ebe Apr 8, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jul 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
cmdline tool documentation
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

config.d: clarify that initial : and = might need quoting [skip ci] curl/curl
3 participants
@bagder @jay @etasse