-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ossfuzz: moving towards the ideal integration #1842
Conversation
Coverage remained the same at 73.13% when pulling 77eb3109bc9d2f9182647480b0e0350105e8ceac on cmeister2:cmeister2/ossfuzz/fuzzer into 73fa6aa on curl:master. |
Coverage decreased (-0.008%) to 73.122% when pulling 73d7d302eb4982c88a7340c1ee2f707540ada791 on cmeister2:cmeister2/ossfuzz/fuzzer into 73fa6aa on curl:master. |
Coverage decreased (-0.02%) to 73.111% when pulling 73d7d302eb4982c88a7340c1ee2f707540ada791 on cmeister2:cmeister2/ossfuzz/fuzzer into 73fa6aa on curl:master. |
Coverage decreased (-0.02%) to 73.112% when pulling 73d7d302eb4982c88a7340c1ee2f707540ada791 on cmeister2:cmeister2/ossfuzz/fuzzer into 73fa6aa on curl:master. |
Ok, the few tweaks I made means that this compiles within the Automake system and links to the libraries as expected (mostly this was reinstating the old code and adding some new tweaks to link to $LIB_FUZZING_ENGINE). |
tests/fuzz/Makefile.fuzz
Outdated
@@ -0,0 +1,48 @@ | |||
# Copyright 2017 Google Inc. All Rights Reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From IRC: this file doesn't need to exist anymore now that the Makefile.am works
tests/fuzz/README
Outdated
|
||
(optional) export LIB_FUZZING_ENGINE=<path to libFuzzer.a> | ||
|
||
make -f Makefile.fuzz check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't need the -f Makefile.fuzz
qualifier here now that Automake works
- Start with the basic code from the ossfuzz project. - Rewrite fuzz corpora to be binary files full of Type-Length-Value data, and write a glue layer in the fuzzing function to convert corpora into CURL options. - Have supporting functions to generate corpora from existing tests - Integrate with Makefile.am
Coverage decreased (-0.02%) to 73.103% when pulling 7d63d1ebea07eed52ab64f027b73dac6a24de5e5 on cmeister2:cmeister2/ossfuzz/fuzzer into 222e65f on curl:master. |
Create simple seed corpora for: - FTP - telnet - dict - tftp - imap - pop3 based off the tests of the same number.
As discussed on IRC, it looks like failures are due to travis issues. |
data, and write a glue layer in the fuzzing function to convert
corpora into CURL options.
This still needs integrating into the rest of the build chain properly,
but is built in CI.