ldap: drop support for legacy Novell LDAP SDK #16176
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest copy I could find at: https://beta.novell.com/developer/ndk/ldap_libraries_for_c.html is from 2016-Feb-03, available for Linux and Windows. It comes with `OpenSSL 1.0.1q-fips 3 Dec 2015` binaries. I built curl against the Windows package with CMake. CMake identified it as OpenLDAP and built it as expected: ``` curl 8.12.0-DEV (x86_64-w64-mingw32) libcurl/8.12.0-DEV Schannel OpenLDAP/2.4.37 Release-Date: [unreleased] Protocols: dict file ftp ftps gopher gophers http https imap imaps ipfs ipns ldap ldaps mqtt pop3 pop3s rtsp smb smbs smtp smtps telnet tftp ws wss Features: alt-svc AsynchDNS HSTS HTTPS-proxy IPv6 Kerberos Largefile NTLM SPNEGO SSL SSPI threadsafe UnixSockets ``` Since it identified it as OpenLDAP (`lib/openldap.c`), the branch deleted in this PR (`lib/ldap.c`) wasn't reached. Thus, defining the `CURL_HAS_NOVELL_LDAPSDK` also made no difference in the build. This suggests the code guarded by it is now orphan and unnecessary. Novell NetWare builds were another user, but we dropped support for them in 2022: 3b16575 curl#8358 Let me know if I missed something and there might still be used for this.
bagder
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest copy I could find at:
https://beta.novell.com/developer/ndk/ldap_libraries_for_c.html
is from 2016-Feb-03, available for Linux and Windows.
I built curl against the Windows package with CMake:
https://sdk.suse.com/ndk/cldap/builds/2016/openldapsdk-devel-windows64-2016-01-28.zip
(It comes with OpenSSL 1.0.1q-fips (2015-Dec-03) binaries.)
CMake identified it as OpenLDAP and built with it as expected:
Since it identified it as OpenLDAP (
lib/openldap.c), the branchdeleted in this PR (
lib/ldap.c) wasn't reached. Thus, definingthe
CURL_HAS_NOVELL_LDAPSDKalso made no difference in the build.This suggests the code guarded by it is now orphan and unnecessary.
Novell NetWare builds were another user, but we dropped support for them
in 2022: 3b16575 #8358
Let me know if I missed something and there might still be use for this.