wolfssl: avoid calling get_cached_x509_store if store is uncachable #14306
Conversation
|
@icing, @dfandrich and me discussed this a bit. It is not clear that a user prefers to disable CA caching just because they use the callback, because it is a quite significant performance blow and there are numerous use cases for the callback that does not alter the CA store at all. Or that alter it but is fine with it remaining in memory. So, we now stress the caching details in the CTX callback documentation: 674e102 Don't you think that is enough? It is a minor behavior difference, but I think for the good for almost everyone. |
Yeah, I think it's fine. I'll update the PR to avoid calling |
There's no need for get_cached_x509_store call if the return value won't be used for caching anyway.
9799ec9 to
199fa2c
Compare
|
Thanks! |
There's no need for get_cached_x509_store call if the return value won't be used for caching anyway.