winsock, move sendbuf update into cf-socket.c #13763
Conversation
|
I'm seeing some strangeness when i test this, data->conn->writesockfd is -1 for the first call, and more if i step through it in the debugger
edit: I've got breakpoints which is slowing things down and causes the 1000 logic to trigger more often but anyway the point is it seems data->conn->writesockfd is not set before at least the first call to cf_socket_send |
- we updated the WINSOCK sendbuf in the transfer loop, but cf-socket.c seems a much better place. - moving code and timestamp into the socket filter I am not a Windows dev, hope this works as intended.
36a953c to
8c5b576
Compare
Thanks for testing. The move was incomplete. The sendbuf update should use the filter's socket |
There was a problem hiding this comment.
This PR is fine as is however I've made a branch modified__winsock-move-sendbuf-update and added a change that renames the functions to be easier to understand, moves the time check into win_update_sndbuf_size and
saves the last sndbuf_size to avoid multiple setsockopt calls every second. I can open a separate PR after you land this one or you're welcome to squash it in.
|
Thanks. I landed this as is and the follow-up is in #13827. |
I am not a Windows dev, hope this works as intended.