Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustls, fix handshake done handling #13686

Closed
wants to merge 1 commit into from
Closed

rustls, fix handshake done handling #13686

wants to merge 1 commit into from

Conversation

icing
Copy link
Contributor

@icing icing commented May 17, 2024 •
edited
Loading

  • rustls reports it has finished the TLS handshake before all relevant data has been sent off, e.g. it FINISHED message
  • On connections that send data immediately, this was never noticed as the FINISHED in rustls buffers was send later with the app data
  • On passive FTP connections, curl does not send any data after the handshake, leaving FINISHED unsent and the server never responded as it was waiting on this.

@icing
rustls, fix handshake done handling
5b8845d 
- rustls report it has finished the TLS handshake *before*
  all relevant data has been sent off, e.g. it FINISHED message
- On connections the send data immediately, this was never noticed
  as the FINISHED in rustls buffers was send with the app data
- On passive FTP connections, curl does not send any data after
  the handshake, leaving FINISHED unsent and the server never
  responded as it was waiting on this.
@github-actions github-actions bot added the TLS label May 17, 2024
@bagder bagder closed this in afffd4c May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
TLS
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@icing @bagder