-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Pin dependencies #13628
ci: Pin dependencies #13628
Conversation
5c570f7
to
ffbf4d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are consistent and as expected
I can't comment/review, I don't know if pinning is to prefer to plain versions. |
My understanding is that pinning dependencies is preferred for OpenSSF, which I believe curl is signed up for. It's also better to pin to a hash rather than a tag because tags can be changed on Git. I don't think it's adding much security but I think it's a best practice that doesn't add much, if any, friction with its use. |
... and we automatically adapt to the new one by advancing the pin? Or what kind of extra checks are done when the pin is updated? How often is this changing, do we know? Does it risk becoming a nuisance? |
"actions/checkout" is pinned to two different hashes which looks incorrect |
Yes, this auto-advances by advancing the pin. It's not particularly spammy - given we've had this set up on curl-fuzzer for quite a while now and it's raised a handful of updates. |
One is v2 and one is v4 - the update here is being handled by #13632 |
So how does it know it is a pinned version of v2 and v4? Is the added comment in the yaml how it knows?
can't we just merge that PR into this to reduce clutter? |
I believe so.
I don't think so. Once every instance of the dependency is on the same version then it becomes much less of a clutter problem. |
ffbf4d2
to
f33b044
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do this. If it causes too much churn or nuisance we can reconsider later.
This PR contains the following updates:
0c45773
0ad4b8f
65a9edc
8558fd7
6546280
a46482c
5c5dfc0
b7cec75
dbd2f1d
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR has been generated by Mend Renovate. View repository job log here.