lib/cf-h1-proxy.c: -Wnull-dereference warnings with gcc 12 / curl 8.7.1
#13237
Comments
|
Grr, this the overcomplaining errors from gcc's static analyzer coming. Quite annoying. This happens because in: CURL_TRC_CF(data, cf, "close");
cf->connected = FALSE;... the macro on the first line checks if I find this warning annoying and counter-productive. The macro is fine to use protection because it can be used in places where maybe it can be a NULL pointer passed to it. It does mean that a NULL pointer is accepted in every place the macro is used. |
-Wnull-dereference warnings with gcc 13.2.0 / curl 8.7.1-Wnull-dereference warnings with gcc 12.0.0 / curl 8.7.1
|
I guess a few false positives is the price to pay for detecting real issues. The other thing I wondered why this wasn't caught in CI. E.g. in this job (mingw, gcc13, unity): https://ci.appveyor.com/project/curlorg/curl/builds/49500338/job/opyx2nhk46vop8b3?fullLog=true Then noticed that the affected gcc version was actually 12.2.0, not 13.2.0. |
-Wnull-dereference warnings with gcc 12.0.0 / curl 8.7.1-Wnull-dereference warnings with gcc 12 / curl 8.7.1
-Wnull-dereference warnings with gcc 12 / curl 8.7.1-Wnull-dereference warnings with gcc 12 / curl 8.7.1
|
This remains valid, but I don't want to offend anybody with warnings popping up in tests. |
They came up ealier with gcc 12 (Windows), but apparently gcc 14 is
still reporting them, also under Linux.
```
/home/runner/work/curl-for-win/curl-for-win/curl/lib/cf-h1-proxy.c: In function 'cf_h1_proxy_close':
/home/runner/work/curl-for-win/curl-for-win/curl/lib/cf-h1-proxy.c:1060:17: warning: null pointer dereference [-Wnull-dereference]
1060 | cf->connected = FALSE;
/home/runner/work/curl-for-win/curl-for-win/curl/lib/cf-h1-proxy.c:1061:8: warning: null pointer dereference [-Wnull-dereference]
1061 | if(cf->ctx) {
| ~~^~~~~
In function 'tunnel_free',
inlined from 'cf_h1_proxy_destroy' at /home/runner/work/curl-for-win/curl-for-win/curl/lib/cf-h1-proxy.c:1053:3:
/home/runner/work/curl-for-win/curl-for-win/curl/lib/cf-h1-proxy.c:198:27: warning: null pointer dereference [-Wnull-dereference]
198 | struct h1_tunnel_state *ts = cf->ctx;
| ^~
```
Ref: https://github.com/curl/curl-for-win/actions/runs/8985369476/job/24679219528#step:3:6320
Fixes curl#13237
Close #xxxxx
They came up ealier with gcc 12 (Windows), but apparently gcc 14 is
still reporting them, also under Linux.
```
/home/runner/work/curl-for-win/curl-for-win/curl/lib/cf-h1-proxy.c: In function 'cf_h1_proxy_close':
/home/runner/work/curl-for-win/curl-for-win/curl/lib/cf-h1-proxy.c:1060:17: warning: null pointer dereference [-Wnull-dereference]
1060 | cf->connected = FALSE;
/home/runner/work/curl-for-win/curl-for-win/curl/lib/cf-h1-proxy.c:1061:8: warning: null pointer dereference [-Wnull-dereference]
1061 | if(cf->ctx) {
| ~~^~~~~
In function 'tunnel_free',
inlined from 'cf_h1_proxy_destroy' at /home/runner/work/curl-for-win/curl-for-win/curl/lib/cf-h1-proxy.c:1053:3:
/home/runner/work/curl-for-win/curl-for-win/curl/lib/cf-h1-proxy.c:198:27: warning: null pointer dereference [-Wnull-dereference]
198 | struct h1_tunnel_state *ts = cf->ctx;
| ^~
```
Ref: https://github.com/curl/curl-for-win/actions/runs/8985369476/job/24679219528#step:3:6320
Fixes #13237
Closes #13555
I did this
Built curl-for-win with gcc + mingw-w64.
Got these warnings:
Ref: https://github.com/curl/curl-for-win/actions/runs/8492022102/job/23264582018#step:3:10749
I expected the following
No warnings.
curl/libcurl version
curl 8.7.1
operating system
Windows (seems OS-agnostic)
The text was updated successfully, but these errors were encountered: