-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add pkg-config support to rustls detection #13179
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on the existing openssl pkg-config detection, this commit tries to use pkg-config to find `rustls` then falls back to the current approach if that fails. We use the following logic: - if no path is provided, just use pkg-config, if it's not there we have a problem! - if a path is provided, try pkg-config + if pkg-config fails, try and find rustls directly
bagder
approved these changes
Mar 25, 2024
Thanks! |
This breaks the build of the curl-rustls Arch Linux package, unfortunately I don't know why. 8.7.1 builds correctly when reverting this commit. This is the error I get during configure:
pkg-config is correctly setup for librustls:
The configure options used are:
Full configure output:
|
@kpcyrd since this was merged already, please file this as a new issue |
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Nov 11, 2024
Different variable names were used in flag save and restore operations, which could cause existing `CPPFLAGS` and `LDFLAGS` be accidentally lost when detecting Rustls. Follow-up to 647e86a curl#13179
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As identified in https://bugs.gentoo.org/919396, cURL fails configure when looking for an installed
rustls
when usinglld
.Based on the existing openssl pkg-config detection, this patch tries to use pkg-config to find
rustls
then falls back to the current approach if that fails.We use the following logic:
This should achieve the same objective as the current detection logic and be a bit more robust.