summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorThiago Macieira <[email protected]>2024-09-19 17:03:13 -0700
committerThiago Macieira <[email protected]>2024-10-11 11:52:19 -0700
commitd44b3ad1c8f1e6615e47c4d62b236c57f051b709 (patch)
tree7793b00b2d66b31c718eabd7a9b9b4639134bfd0
parent31b4150dc3a789ffaf3f660151971127ac86510d (diff)
Benchlib: remove unused init() virtual function
Commit 051f68c2d3a069543dce4d560facff6aa22284bd (Qt 5.2) made it empty by moving the content to QBenchmarkPerfEventsMeasurer::start(). Pick-to: 6.8 Change-Id: I65f48d72a9d079f0aee5fffd6abeae9cf7fcdcf5 Reviewed-by: Tor Arne Vestbø <[email protected]>
-rw-r--r--src/testlib/qbenchmark.cpp1
-rw-r--r--src/testlib/qbenchmarkmeasurement_p.h1
-rw-r--r--src/testlib/qbenchmarkperfevents.cpp4
-rw-r--r--src/testlib/qbenchmarkperfevents_p.h1
4 files changed, 0 insertions, 7 deletions
diff --git a/src/testlib/qbenchmark.cpp b/src/testlib/qbenchmark.cpp
index af6ee5f7c66..11bb28b9d55 100644
--- a/src/testlib/qbenchmark.cpp
+++ b/src/testlib/qbenchmark.cpp
@@ -55,7 +55,6 @@ QBenchmarkMeasurerBase * QBenchmarkGlobalData::createMeasurer()
} else {
measurer = new QBenchmarkTimeMeasurer;
}
- measurer->init();
return measurer;
}
diff --git a/src/testlib/qbenchmarkmeasurement_p.h b/src/testlib/qbenchmarkmeasurement_p.h
index 56b978228bf..70079ae48a3 100644
--- a/src/testlib/qbenchmarkmeasurement_p.h
+++ b/src/testlib/qbenchmarkmeasurement_p.h
@@ -30,7 +30,6 @@ public:
QTest::QBenchmarkMetric metric;
};
virtual ~QBenchmarkMeasurerBase() = default;
- virtual void init() {}
virtual void start() = 0;
virtual QList<Measurement> stop() = 0;
virtual bool isMeasurementAccepted(Measurement m) = 0;
diff --git a/src/testlib/qbenchmarkperfevents.cpp b/src/testlib/qbenchmarkperfevents.cpp
index b42789ce590..02f8e7af414 100644
--- a/src/testlib/qbenchmarkperfevents.cpp
+++ b/src/testlib/qbenchmarkperfevents.cpp
@@ -448,10 +448,6 @@ QBenchmarkPerfEventsMeasurer::~QBenchmarkPerfEventsMeasurer()
qt_safe_close(fd);
}
-void QBenchmarkPerfEventsMeasurer::init()
-{
-}
-
void QBenchmarkPerfEventsMeasurer::start()
{
QT_WARNING_DISABLE_GCC("-Wmissing-field-initializers")
diff --git a/src/testlib/qbenchmarkperfevents_p.h b/src/testlib/qbenchmarkperfevents_p.h
index 5f94ea77948..753bb510a4d 100644
--- a/src/testlib/qbenchmarkperfevents_p.h
+++ b/src/testlib/qbenchmarkperfevents_p.h
@@ -24,7 +24,6 @@ class QBenchmarkPerfEventsMeasurer : public QBenchmarkMeasurerBase
public:
QBenchmarkPerfEventsMeasurer();
~QBenchmarkPerfEventsMeasurer();
- void init() override;
void start() override;
QList<Measurement> stop() override;
bool isMeasurementAccepted(Measurement measurement) override;