summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVolker Hilsheimer <[email protected]>2023-02-08 09:41:33 +0100
committerVolker Hilsheimer <[email protected]>2023-02-09 00:23:34 +0100
commit3fe0bf6e1bd3713543a5b763d3bfcee0c03faf4c (patch)
tree73a54a589276a8e7e6966ffc7e60afd78740c89e
parent55f2b448b0aec4e9a8fd3896b2a40f37e939ecb3 (diff)
Move findfiles example into manual tests
The example follows bad and outdated practices: - running time consuming and I/O heavy workload in the GUI thread - calling processEvents to keep the UI responsive - showing results only at the end of a search rather than continuously Perhaps this example can be rewritten at some point to apply modern practices (at least use a thread and emit signals), but it seems to have low overall educational value. Moving it to be a manual test for now. Fixes: QTBUG-111002 Pick-to: 6.5 Change-Id: Id630fd4599096448ea4f96bcbf977b11a039796f Reviewed-by: Axel Spoerl <[email protected]> Reviewed-by: Qt CI Bot <[email protected]>
-rw-r--r--doc/src/images/findfiles-example.pngbin11174 -> 0 bytes
-rw-r--r--examples/widgets/dialogs/CMakeLists.txt1
-rw-r--r--examples/widgets/dialogs/dialogs.pro1
-rw-r--r--src/widgets/dialogs/qprogressdialog.cpp2
-rw-r--r--tests/manual/findfiles/CMakeLists.txt (renamed from examples/widgets/dialogs/findfiles/CMakeLists.txt)0
-rw-r--r--tests/manual/findfiles/findfiles.pro (renamed from examples/widgets/dialogs/findfiles/findfiles.pro)0
-rw-r--r--tests/manual/findfiles/findfiles.qdoc (renamed from examples/widgets/doc/src/findfiles.qdoc)0
-rw-r--r--tests/manual/findfiles/main.cpp (renamed from examples/widgets/dialogs/findfiles/main.cpp)0
-rw-r--r--tests/manual/findfiles/window.cpp (renamed from examples/widgets/dialogs/findfiles/window.cpp)0
-rw-r--r--tests/manual/findfiles/window.h (renamed from examples/widgets/dialogs/findfiles/window.h)0
10 files changed, 1 insertions, 3 deletions
diff --git a/doc/src/images/findfiles-example.png b/doc/src/images/findfiles-example.png
deleted file mode 100644
index cf3885c0153..00000000000
--- a/doc/src/images/findfiles-example.png
+++ /dev/null
Binary files differ
diff --git a/examples/widgets/dialogs/CMakeLists.txt b/examples/widgets/dialogs/CMakeLists.txt
index bb966b485aa..a4031a68071 100644
--- a/examples/widgets/dialogs/CMakeLists.txt
+++ b/examples/widgets/dialogs/CMakeLists.txt
@@ -6,7 +6,6 @@ if(QT_FEATURE_wizard)
qt_internal_add_example(trivialwizard)
endif()
qt_internal_add_example(extension)
-qt_internal_add_example(findfiles)
qt_internal_add_example(standarddialogs)
qt_internal_add_example(tabdialog)
if(QT_FEATURE_wizard AND TARGET Qt6::PrintSupport)
diff --git a/examples/widgets/dialogs/dialogs.pro b/examples/widgets/dialogs/dialogs.pro
index 753308fc557..1983c854a1d 100644
--- a/examples/widgets/dialogs/dialogs.pro
+++ b/examples/widgets/dialogs/dialogs.pro
@@ -3,7 +3,6 @@ QT_FOR_CONFIG += widgets
TEMPLATE = subdirs
SUBDIRS = classwizard \
extension \
- findfiles \
licensewizard \
standarddialogs \
tabdialog \
diff --git a/src/widgets/dialogs/qprogressdialog.cpp b/src/widgets/dialogs/qprogressdialog.cpp
index d3a714c686c..59d44cd8d52 100644
--- a/src/widgets/dialogs/qprogressdialog.cpp
+++ b/src/widgets/dialogs/qprogressdialog.cpp
@@ -215,7 +215,7 @@ void QProgressDialogPrivate::_q_disconnectOnClose()
\image fusion-progressdialog.png A progress dialog shown in the Fusion widget style.
- \sa QDialog, QProgressBar, {Find Files Example}, {Pixelator Example}
+ \sa QDialog, QProgressBar, {Pixelator Example}
*/
diff --git a/examples/widgets/dialogs/findfiles/CMakeLists.txt b/tests/manual/findfiles/CMakeLists.txt
index db27300b1e1..db27300b1e1 100644
--- a/examples/widgets/dialogs/findfiles/CMakeLists.txt
+++ b/tests/manual/findfiles/CMakeLists.txt
diff --git a/examples/widgets/dialogs/findfiles/findfiles.pro b/tests/manual/findfiles/findfiles.pro
index 4fb77f0dd72..4fb77f0dd72 100644
--- a/examples/widgets/dialogs/findfiles/findfiles.pro
+++ b/tests/manual/findfiles/findfiles.pro
diff --git a/examples/widgets/doc/src/findfiles.qdoc b/tests/manual/findfiles/findfiles.qdoc
index bed831d14d0..bed831d14d0 100644
--- a/examples/widgets/doc/src/findfiles.qdoc
+++ b/tests/manual/findfiles/findfiles.qdoc
diff --git a/examples/widgets/dialogs/findfiles/main.cpp b/tests/manual/findfiles/main.cpp
index 27409403a5f..27409403a5f 100644
--- a/examples/widgets/dialogs/findfiles/main.cpp
+++ b/tests/manual/findfiles/main.cpp
diff --git a/examples/widgets/dialogs/findfiles/window.cpp b/tests/manual/findfiles/window.cpp
index f3e7253c754..f3e7253c754 100644
--- a/examples/widgets/dialogs/findfiles/window.cpp
+++ b/tests/manual/findfiles/window.cpp
diff --git a/examples/widgets/dialogs/findfiles/window.h b/tests/manual/findfiles/window.h
index 2c2e3100c09..2c2e3100c09 100644
--- a/examples/widgets/dialogs/findfiles/window.h
+++ b/tests/manual/findfiles/window.h