Publish DEPS for Chromium 63.0.3239.40
Incrementing VERSION to 63.0.3239.40
[email protected]
Change-Id: Id5e1d9b86a8e98bbf1f03d2fe1d2fcc6795c8c74
Reviewed-on: https://chromium-review.googlesource.com/757224
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#411}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Merge to M63] Gtk3: Fix restore button rendering improperly on some themes
> Restore buttons are styled with the ".maxmize" style class, not
> ".restore".
>
> BUG=753067,779848
> [email protected]
>
> Change-Id: Ifcd9f034bddf92285a34be9f1f3d5ea197ee4532
> Reviewed-on: https://chromium-review.googlesource.com/755475
> Commit-Queue: Thomas Anderson <[email protected]>
> Reviewed-by: Elliot Glaysher <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#514293}
BUG=753067,779848
[email protected]
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
Change-Id: I80d3e4bad4cb7b367eb4bbaab3219d8cee9cff5c
Reviewed-on: https://chromium-review.googlesource.com/757500
Reviewed-by: Thomas Anderson <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#410}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Fix potential buffer overflow in browser_theme_pack.cc
This CL fixes a potential buffer overflow in InputScalesValid()
BUG=778251
Change-Id: Iec1dfa3a7758e94cbcdf50006540334fefba451f
Reviewed-on: https://chromium-review.googlesource.com/747323
Reviewed-by: Chris Palmer <[email protected]>
Commit-Queue: Peter Kotwicz <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#513229}(cherry picked from commit 0aa1e66be68440b6966c8659c677d1a7ef2c200e)
Reviewed-on: https://chromium-review.googlesource.com/757222
Reviewed-by: Peter Kotwicz <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#409}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}DevTools: Further relax comparison threshold for CaptureScreenshot tests.
It turned out there are bots whose color profiles produce errors up to 12.
Bump the error threshold to 16.
BUG=778421
[email protected]
(cherry picked from commit bef92ed7729796df9eb6221223bd45a686221fc4)
Change-Id: I05b2322e3804118c0e3e3f9c987f16d59d184d95
Reviewed-on: https://chromium-review.googlesource.com/755845
Reviewed-by: Pavel Feldman <[email protected]>
Commit-Queue: Alexei Filippov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#514302}
Reviewed-on: https://chromium-review.googlesource.com/757464
Reviewed-by: Alexei Filippov <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#408}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}DevTools: Relax captured screenshot comparison threshold for tests.
The pixel colors could be slightly off because of the color profiles or
image compression.
BUG=778421
[email protected]
(cherry picked from commit 6b2875367b6e16b3a781293e1f170de161b78ad7)
Change-Id: I490074667d760f5853caa3d4f866f0ee75b3e4cd
Reviewed-on: https://chromium-review.googlesource.com/754448
Commit-Queue: Pavel Feldman <[email protected]>
Reviewed-by: Pavel Feldman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#514032}
Reviewed-on: https://chromium-review.googlesource.com/757463
Reviewed-by: Alexei Filippov <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#407}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Blocked used profile when force-sign-in is enabled
When force-sign-in is enabled, any profile has been used before
can not be used anymore but only deleted. This behavior is used
to avoid privacy issue caused by profile merge.
[email protected]
(cherry picked from commit 1dca14a652a24f44247ba4e8c67b04a339850508)
Bug: 775546
Change-Id: I37e475407d0f1807500060f550aa9ec97b09c4e0
Reviewed-on: https://chromium-review.googlesource.com/751297
Commit-Queue: Owen Min <[email protected]>
Reviewed-by: Georges Khalil <[email protected]>
Reviewed-by: Roger Tawa <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#513890}
Reviewed-on: https://chromium-review.googlesource.com/757179
Reviewed-by: Owen Min <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#406}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}🏡 Disable the ChromeHome dependent doodle fetching
The LogoServiceFactory caches the UI at creation, but since it can
now change at runtime, this can cause displaying Doodles on classic
New Tab Pages with ChromeHome's white background.
As temporary workaround for M63 that won't display Doodles in
ChromeHome, we simply stop configuring the LogoServiceFactory to
fetch ChromeHome specific Doodles.
[email protected]
(cherry picked from commit 44d6990cb200cf0193064c09243ab5c85dae19cb)
Bug: 776725
Change-Id: I1b2df2250f597671057aa10c86e5a1fa2177d8fa
Reviewed-on: https://chromium-review.googlesource.com/743901
Reviewed-by: Marc Treib <[email protected]>
Commit-Queue: Nicolas Dossou-Gbété <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#512527}
Reviewed-on: https://chromium-review.googlesource.com/756742
Reviewed-by: Nicolas Dossou-Gbété <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#405}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Enable Zip Unpacker extension when it were disabled.
Component extension cannot be disabled or uninstalled by any user
operations, but we got some cases where Zip Unpacker was disabled
in some user's profile.
Bug: 643060
Test: unit_tests --gtest_filter=ExtensionServiceTest.*
Change-Id: Id27ca4472270d37175dd21b54f070c37b2c6f282
Reviewed-on: https://chromium-review.googlesource.com/737892
Reviewed-by: Finnur Thorarinsson <[email protected]>
Commit-Queue: Tatsuhisa Yamaguchi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511780}(cherry picked from commit 5ed1aece396a2398fda2bfb4546f7c788083b33b)
Reviewed-on: https://chromium-review.googlesource.com/756242
Reviewed-by: Tatsuhisa Yamaguchi <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#404}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Incrementing VERSION to 63.0.3239.39
[email protected]
Change-Id: Iaeef4b4424bf031b62441cd5fb4f004868150966
Reviewed-on: https://chromium-review.googlesource.com/756216
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#403}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Reland "Fix iPhone X collections issues"
As MDC is rolled to 38.0, we can start taking advantage of the fix
included for the iPhone X by letting the collection have the default
adjustedContentBehavior.
This also changes the NTP to use an automatic
adjustedContentInsetBehavior, to prevent a bug with the overscroll
action.
Bug: 767802, 779234
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I9d4b3c2cbe7feedcab03714c061a8ff9705d4d57
Reviewed-on: https://chromium-review.googlesource.com/743018
Commit-Queue: Gauthier Ambard <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#512491}(cherry picked from commit 26054fded2ff114df520b5ed2714c1673030b54d)
Reviewed-on: https://chromium-review.googlesource.com/752461
Reviewed-by: Gauthier Ambard <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#402}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Support both $() and ${} substitution in plist files.
Some third_party libraries uses $() to represent substitution
variables in Info.plist. Add support for them to plist_util.py.
Bug: none
Change-Id: Icc16fc0ed39d4b9365ed3cf6b687f65d430b842d
Reviewed-on: https://chromium-review.googlesource.com/733841
Commit-Queue: Sylvain Defresne <[email protected]>
Reviewed-by: Robert Sesek <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511256}(cherry picked from commit 0a50430601ceda22003b0e806f6e6378eaf85532)
Reviewed-on: https://chromium-review.googlesource.com/752381
Reviewed-by: Sylvain Defresne <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#401}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Add a compile_entitlements template on macOS/iOS.
The .entitlements files have some unsubstituted variables. It
currently works because they use $(variable) while the script
performing the substitution only replace ${variable}.
In order to allow the script to also substitute $(variable) to
supports third_party libraries using this pattern, add a new
template that leave untouched those unsubstited variables in
the .entitlements files.
Bug: none
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ie33acc94854f749a0e74c50a111953dd4bea87f0
Reviewed-on: https://chromium-review.googlesource.com/733951
Reviewed-by: Robert Sesek <[email protected]>
Commit-Queue: Sylvain Defresne <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511208}(cherry picked from commit de9557744f6c422f9ee15242259cfc5b47c70435)
Reviewed-on: https://chromium-review.googlesource.com/752281
Reviewed-by: Sylvain Defresne <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#400}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Adds MDF Internationalization dependency
The dependency is needed because the newer versions of MDC needs it.
This CL also roll MDC to e4ef28e6796430e550023be60ff58d6418b40a49.
[email protected]
(cherry picked from commit 8d03446dde8241267009f8ad0671924b566d4bca)
Bug: 775476
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Iabad6d33845d9e5e3e9ecb9ea86117abf0eb5ec9
Reviewed-on: https://chromium-review.googlesource.com/723000
Commit-Queue: Sylvain Defresne <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Reviewed-by: Chris Palmer <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511486}
Reviewed-on: https://chromium-review.googlesource.com/752382
Reviewed-by: Peter Lee <[email protected]>
Reviewed-by: Gauthier Ambard <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#399}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Fix incorrect process reuse allowed by SiteProcessCountTracker (Merge to M63)
Currently, any SiteInstance which uses the
REUSE_PENDING_OR_COMMITTED_SITE process reuse policy is always allowed
to reuse a process with a matching pending site entry. This is not
always correct: before the navigation to a pending site commits (if
ever), the process might be reused by a navigation to a different
site, which makes this process unsuitable for hosting the original
site if that site requires a dedicated process. This policy is used
by ServiceWorkers and isolated origins subframes, and this results in
races where we may commit two incompatible sites (or a site and a SW)
under one origin lock, which subsequently leads to renderer kills when
the site with the mismatched lock requests resources such as cookies.
This CL modifies the site tracker to check whether the
RenderProcessHost is still suitable for the target site before
returning it.
[email protected]
(cherry picked from commit 226d2c907c34ddccf3e66cf69dbc9c1d547c9c2a)
Bug: 780661, 780089
Change-Id: I88553572d8b823100fe797bb3a83c9e7cdbfdd2c
Reviewed-on: https://chromium-review.googlesource.com/750404
Reviewed-by: Charlie Reis <[email protected]>
Commit-Queue: Alex Moshchuk <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#513607}
Reviewed-on: https://chromium-review.googlesource.com/755521
Reviewed-by: Alex Moshchuk <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#398}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[IndexedDB] Fixing blob leak when deserializing wrapped IDB large values
* Fixed blob leak in IDBRequest for wrapped blobs, as unwrapping removes
a yet-to-be-acked blob handle.
* Fixed blob leak in IDBRequestLoader, which was reusing
FileReaderLoader and thus leaking blob urls.
Bug: 777665,777662
Change-Id: Icd3f7e8c9b30e39677ea024c206a9b61bf778fa8
Reviewed-on: https://chromium-review.googlesource.com/754020
Commit-Queue: Daniel Murphy <[email protected]>
Reviewed-by: Victor Costan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#514011}(cherry picked from commit b7b648d6180c470eeec2f94024ee1413421713c1)
Reviewed-on: https://chromium-review.googlesource.com/755822
Reviewed-by: Daniel Murphy <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#397}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Fix selected rows that scroll in a TreeView having incorrect damage.
When the TreeView scheduled a paint it was using the wrong bounds when
the platform wanted to only highlight the row's text (i.e. on Windows).
This resulted in some areas not being repainted when a long selected row
scrolls to the right (in LTR).
[email protected]
(cherry picked from commit a7ad077437ea1ae74cf4c19aab93723c7230f7ad)
Bug: 779983
Change-Id: I5210d5337a7ad2a6ae6dbaf85ba2601862c7accd
Reviewed-on: https://chromium-review.googlesource.com/748209
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Elly Fong-Jones <[email protected]>
Commit-Queue: Bret Sepulveda <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#513931}
Reviewed-on: https://chromium-review.googlesource.com/755517
Reviewed-by: Bret Sepulveda <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#396}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Use webviews instead of iframes in mobile setup web UI
Change chrome://mobilesetup to use webview to embed resources from
component mobile setup extension, and payment urls provided by
cellular network services.
To acheive this, chrome://mobilesetup has to be whitelisted to use
webview API. Additionally, as webviews can by default load extension
resources only when embeded by the same extension, mobile activation
extension has to be explicitly whitelisted as allowed in webviews
from chrome://mobilesetup
Previously, to handle payment portals that required POST request to
start, the web UI would use mobile setup extension's redirect.html:
1. The web UI would load the extension resource into the iframe
2. The extension would create a form with the provided post data,
and initiate POST request by submitting the form.
This meant that the iframe had navigation from an extension URL to
web URL.
This CL avoids this situation - webviews load either only extension
URLs ('carrierPage') or only data: and web URLs (portalFrame).
To initialize payment portal using POST request, the web UI
1. sets up the portal frame webview to contain a form element (using
html data URL)
2. initializes the form with post data provided by the cellular device
(using webview's executeScript API)
3. submit's the initialized form (using the weview's executeScript API)
Note that this makes redirect.html deprecated/unneeded.
BUG=774683
[email protected]
(cherry picked from commit 616faf76cc458038f0f554effe33fa7088e6d878)
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia42da0d328adb60400f9aa4b018e16060459376d
Reviewed-on: https://chromium-review.googlesource.com/736065
Reviewed-by: Charlie Reis <[email protected]>
Reviewed-by: Istiaque Ahmed <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Reviewed-by: Lucas Gadani <[email protected]>
Commit-Queue: Toni Barzic <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#512116}
Reviewed-on: https://chromium-review.googlesource.com/755338
Reviewed-by: Toni Barzic <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#395}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Merge to M63] Target .Main activity alias back to CLA for legacy APK.
AGSA hardcodes .Main activity alias in CCT intents, which causes issue with
back button on KitKat devices. Attempts to fix the issue create even more
issues (see the bug for details).
This CL retargets .Main alias back to ChromeLauncherActivity for legacy APK
(min_sdk_version < 21), avoiding the issue. In other cases .Main still points
to ChromeTabbedActivity.
Bug: 778834
Change-Id: I8b9fa5f4460a8410d2aaa2a9f10657413198a9da
Reviewed-on: https://chromium-review.googlesource.com/750340
Commit-Queue: Dmitry Skiba <[email protected]>
Reviewed-by: Maria Khomenko <[email protected]>
Reviewed-by: Ted Choc <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#513588}(cherry picked from commit 2a2f362c76cbb63123944a5f67121e4dd671fe8e)
Reviewed-on: https://chromium-review.googlesource.com/755476
Reviewed-by: Dmitry Skiba <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#394}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Add null check for BoxPainterBase image
Fixes a null pointer in PaintFillLayerBackground.
This method can be called with no image when a bad resource
locator is given such as "//:0".
BUG=776940
[email protected]
(cherry picked from commit 7da6bd0696fa951c2ffa422a8b2c237f8690287d)
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I53f2c197a57904c06d21a31d7fb38fc9a41efd1d
Reviewed-on: https://chromium-review.googlesource.com/738676
Reviewed-by: Stephen Chenney <[email protected]>
Reviewed-by: vmpstr <[email protected]>
Commit-Queue: Patrick Hulce <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#513522}
Reviewed-on: https://chromium-review.googlesource.com/755474
Reviewed-by: Patrick Hulce <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#393}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Updating XTBs based on .GRDs from branch 3239
[email protected]
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie31d3c81aa02f6b4d55388a628afe38a50bcf532
Reviewed-on: https://chromium-review.googlesource.com/755536
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#392}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}BrowserPlugin: Don't follow RWHV if null
A WebContents' RenderWidgetHostView may be null on setup and teardown.
Don't follow the RenderWidgetHostView pointer in
BrowserPluginGuest::RenderViewReady if it's null.
[email protected]
(cherry picked from commit 8d835fcdbf37e0fe0579cb7ff6a5da2c5250a3d4)
Bug: 780464
Change-Id: I7fb32e780368cafee3679bf1d37e6fc433cebab7
Reviewed-on: https://chromium-review.googlesource.com/753402
Reviewed-by: Lucas Gadani <[email protected]>
Commit-Queue: Fady Samuel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#513767}
Reviewed-on: https://chromium-review.googlesource.com/755117
Reviewed-by: Fady Samuel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#391}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[m63 merge] Fix OOB Write in QuicStreamSequencerBuffer::OnStreamData
BUG=778505
[email protected]
(cherry picked from commit a96567f02a0881561c964e5c11afe9c1af17a5f7)
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I1dfd1d26a2c7ee8fe047f7fe6e4ac2e9b97efa52
Reviewed-on: https://chromium-review.googlesource.com/748282
Commit-Queue: Ryan Hamilton <[email protected]>
Reviewed-by: Zhongyi Shi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#513144}
Reviewed-on: https://chromium-review.googlesource.com/755001
Reviewed-by: Ryan Hamilton <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#390}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[iOS] Check for toolbar frame updates after each layout pass.
When safe area inset usage is enabled, the constraint system bypasses
|-setFrame:| when updating the view upon rotation, so the omnibox's and
buttons' opacities were not updated properly. This CL changes the
delegate protocol to wait for layout events rather than frame setting.
[email protected]
(cherry picked from commit cd6ceee5322b9a3fce70e1fdae83264def9e2153)
Bug: 778750
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I0cbd3bf66f0c53a156da269ed510fcad71ed87ec
Reviewed-on: https://chromium-review.googlesource.com/745723
Commit-Queue: Kurt Horimoto <[email protected]>
Reviewed-by: Kurt Horimoto <[email protected]>
Reviewed-by: Sergio Collazos <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#512874}
Reviewed-on: https://chromium-review.googlesource.com/755017
Cr-Commit-Position: refs/branch-heads/3239@{#389}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Merge to M63] Don't send internal VIEW intents to .Main alias.
.Main activity alias points to ChromeTabbedActivity, but its VIEW intent
dispatching code is temporary and only handles CCT intents.
This CL changes IntentHandler to send intents to .IntentDispatcher alias,
which does proper dispatching.
Bug: 780619
Change-Id: I12253656171f867df3478b1984ab8fc27ca66e3f
Reviewed-on: https://chromium-review.googlesource.com/750254
Reviewed-by: Maria Khomenko <[email protected]>
Commit-Queue: Dmitry Skiba <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#513551}(cherry picked from commit af78fa9e4ea9f41ee0bf2b079de71cc82c006649)
Reviewed-on: https://chromium-review.googlesource.com/755073
Reviewed-by: Dmitry Skiba <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#388}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[merge into M63] Remove URL fragment in referrer chain
Clear URL fragment before recording navigation events and before
matching event url or webcontents url against navigation events.
[email protected]
(cherry picked from commit f75c7357a60a3597f6e955044738873b4e2aff18)
Bug: 776587
Change-Id: I91ee7b9365dd365a5971b64fee55f4df7d395936
Reviewed-on: https://chromium-review.googlesource.com/745318
Reviewed-by: Robert Shield <[email protected]>
Commit-Queue: Jialiu Lin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#513214}
Reviewed-on: https://chromium-review.googlesource.com/754995
Reviewed-by: Jialiu Lin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#387}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Align elements in the save password dialog.
The username field is now align with the pop-up button for the password.
The save button is right-aligned with the username field.
[email protected]
(cherry picked from commit 1df038df6e19e70fd11342f9d5a4d9efbea098fc)
Bug: 774505,780825
Change-Id: Iae200387cb25ddbc5a4b9b3d17dfb093b9bf5cfb
Reviewed-on: https://chromium-review.googlesource.com/751742
Commit-Queue: Vasilii Sukhanov <[email protected]>
Reviewed-by: Maxim Kolosovskiy <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#513727}
Reviewed-on: https://chromium-review.googlesource.com/754934
Reviewed-by: Vasilii Sukhanov <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#386}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Don't merge tab models until native resume has triggered
When using the Chrome Home promo in multi-window mode, restarting
the activity can cause a race condition where the multi-window state
changes before onResumeWithNative is called. This causes a crash when
the browser concequently tries to merge tab models. This change blocks
the logic in onMultiWindowModeChanged until onResumeWithNative has
been called.
BUG=775890
[email protected]
(cherry picked from commit 36e53e77b46fd48a35e5a20d00963eb108eba759)
Change-Id: Ic0f9f032ff0f7d99e5f29a4c603496937db0f66c
Reviewed-on: https://chromium-review.googlesource.com/739760
Commit-Queue: Matthew Jones <[email protected]>
Reviewed-by: Ted Choc <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#512350}
Reviewed-on: https://chromium-review.googlesource.com/754075
Reviewed-by: Matthew Jones <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#385}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Merge to M63] Handle ResourceNotFound in TabbedModeFRA.
TabbedModeFirstRunActivity introduced in 9c6253e4f9aa doesn't properly
handle Resources.NotFoundException from Resources.getValue(), which
can result in a crash (see the bug).
This CL adds necessary Resources.NotFoundException handling.
Bug: 780459
Change-Id: Ib56c9e7be3ddb6aff6ab84621a089ace004b2eee
Reviewed-on: https://chromium-review.googlesource.com/748707
Reviewed-by: Ted Choc <[email protected]>
Commit-Queue: Dmitry Skiba <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#513289}(cherry picked from commit 1127bd123cc2977b8a91d2067e1fb93dda110653)
Reviewed-on: https://chromium-review.googlesource.com/753868
Reviewed-by: Dmitry Skiba <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#384}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Android WebAPK] Fix NullPointerException when showing notification
This CL fixes NullPointerException when showing notifications in WebAPK.
BUG=779960
Change-Id: Icc4721995b57503e74071d7a1ae92f875d5de649
Reviewed-on: https://chromium-review.googlesource.com/748802
Reviewed-by: Yaron Friedman <[email protected]>
Reviewed-by: Xi Han <[email protected]>
Commit-Queue: Peter Kotwicz <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#513186}(cherry picked from commit 2348c5726dce82b70ce3454257d131296a655e47)
Reviewed-on: https://chromium-review.googlesource.com/754853
Cr-Commit-Position: refs/branch-heads/3239@{#383}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[macOS] Remove border-radius for buttons from the UA stylesheet.
[email protected]
(cherry picked from commit 470386c9916e313c1eb724ad28a80d22a5a13333)
Bug: 752450
Change-Id: Iea62709329f0ac25f0b337b6f46de8e1880c797b
Reviewed-on: https://chromium-review.googlesource.com/749604
Reviewed-by: Keishi Hattori <[email protected]>
Commit-Queue: Kent Tamura <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#513453}
Reviewed-on: https://chromium-review.googlesource.com/753278
Cr-Commit-Position: refs/branch-heads/3239@{#382}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Fix keyboard dismissal bug in bookmarks.
Creates a navigation controller subclass to respect the
disablesAutomaticKeyboardDismissal property of a view controller. Uses
this to present the bookmarks view controller.
Bug: 767049
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I3dfeb09a97345a3e70b8e1c3a89264c962741524
Reviewed-on: https://chromium-review.googlesource.com/744045
Reviewed-by: Eric Noyau <[email protected]>
Commit-Queue: Stepan Khapugin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#512816}(cherry picked from commit 15733e14e142d1b3fddf5dc1dc079cf57c5cc8bf)
Reviewed-on: https://chromium-review.googlesource.com/753581
Reviewed-by: Stepan Khapugin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#381}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Revert "Implemented: remove browsing context name on cross origin navigation"
This reverts commit 57e5929e121f8f081a80a2faaf68b00552cf7e72.
Reason for revert: There is a blocking bug for Chromebox for Meetings
that this patch has introduced.
While a solution is being worked out, this patch will be reverted.
Original change's description:
> Implemented: remove browsing context name on cross origin navigation
>
> When updating the history after a cross-origin navigation, the HTML
> Standard says: "If the browsing context is a top-level browsing context,
> but not an auxiliary browsing context, then set the browsing context's
> name to the empty string."
>
> Currently we are not doing this which means there's potential
> information leak.
>
> Spec: https://html.spec.whatwg.org/multipage/browsers.html#resetBCName
> I2I: https://groups.google.com/a/chromium.org/d/msg/blink-dev/fhUIycdlINU/RLVEOKaNAwAJ
> Webkit change: https://trac.webkit.org/changeset/209076/webkit
>
> Bug: crbug.com/706350
> Change-Id: I70cb3efcef06a3442ed4bf9ddd3733e24ccde19d
> Reviewed-on: https://chromium-review.googlesource.com/645309
> Commit-Queue: Andy Paicu <[email protected]>
> Reviewed-by: Mike West <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#506708}
[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: crbug.com/706350
Change-Id: I3dad94ddf95a9c288081be1fda7275220177d16f
Reviewed-on: https://chromium-review.googlesource.com/735441
Commit-Queue: Andy Paicu <[email protected]>
Commit-Queue: Mats Nilsson <[email protected]>
Reviewed-by: Mike West <[email protected]>
Reviewed-by: Andy Paicu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511140}(cherry picked from commit a9d3e8b258ba21d310bf7456cd4c270e3d49e820)
Reviewed-on: https://chromium-review.googlesource.com/750144
Cr-Commit-Position: refs/branch-heads/3239@{#380}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Resource Timing: Do not report subsequent navigations within subframes
We only want to record resource timing for the load that was initiated
by parent document. We filter out subsequent navigations for <iframe>,
but we should do it for other types of subframes too.
[email protected]
Bug: 780312
Change-Id: I3a7b9e1a365c99e24bb8dac190e88c7099fc3da5
Reviewed-on: https://chromium-review.googlesource.com/750487
Reviewed-by: Nate Chapin <[email protected]>
Commit-Queue: Kunihiko Sakamoto <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#513665}(cherry picked from commit fa17c9878dbeebf991b25ac0deb2b4635d85f1b6)
Reviewed-on: https://chromium-review.googlesource.com/753205
Reviewed-by: Kunihiko Sakamoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#379}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Incrementing VERSION to 63.0.3239.38
[email protected]
Change-Id: Iff192139953fa73ac8915acb26598608112e6fec
Reviewed-on: https://chromium-review.googlesource.com/754559
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#378}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Incrementing VERSION to 63.0.3239.37
[email protected]
Change-Id: Ia5f36f88a690919001568d2dcfb0593f38c475d6
Reviewed-on: https://chromium-review.googlesource.com/754582
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#377}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Incrementing VERSION to 63.0.3239.36
[email protected]
Change-Id: I613db952d0e7bc8cc5a5ba3050fd837e1e4fa059
Reviewed-on: https://chromium-review.googlesource.com/753851
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#376}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Add SetHasOpener API to WebState.
Allow CWVWebView to internally set the value of WebState::HasOpener
after the web state has already been created. This prevents
unneccesarily burdening the embedder of ios/web_view with setting this
value.
Bug: 702298
Change-Id: Ic4122aeaba619a4276aa24529ca3fe1bc619dfad
Reviewed-on: https://chromium-review.googlesource.com/750195
Reviewed-by: Eugene But <[email protected]>
Commit-Queue: Mike Dougherty <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#513633}(cherry picked from commit 3e61adc36122a98b47ca177532e79b9a24665690)
Reviewed-on: https://chromium-review.googlesource.com/753865
Reviewed-by: Mike Dougherty <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#375}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Save bluetooth user pref only after button toggle
The current bluetooth settings page listens to power change and save the
change to user pref. This is a problem because recent hardware bugs
cause bluetooth adapter to disconnect by itself, if this happens during
settings page is opened, the user pref will be overwritten by the wrong
value.
The correct behavior is to save user pref only in the event the button
is toggled by the user.
BUG=779206
TEST=Check that the bluetooth power is initialized to the last toggled
value after sign out and sign in again.
(cherry picked from commit 3a3db8dbb476d63fa46c04756cd0156a262125d3)
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I294f60876400949ac35283863945a51b1d38bd94
Reviewed-on: https://chromium-review.googlesource.com/742346
Commit-Queue: Sonny Sasaka <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#512561}
Reviewed-on: https://chromium-review.googlesource.com/754374
Reviewed-by: Alexander Alekseev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#374}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}🔐 Limit the number of times we autofill a form
Autofilling triggers JS events and can be triggered by JS actions. In
some edge cases, this can cause an infinite loop of autofilling. We set
an upper limit to the number of times that PasswordFormManager will
autofill on its form.
[email protected]
(cherry picked from commit 1af275b69022aeb7326bcd81d50045c2adbb37f9)
Bug: 771824
Change-Id: I977330b8c74a3d4210804da419ab0b8deaaad9a3
Reviewed-on: https://chromium-review.googlesource.com/741592
Commit-Queue: Christos Froussios <[email protected]>
Reviewed-by: Vaclav Brozek <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#512189}
Reviewed-on: https://chromium-review.googlesource.com/753585
Reviewed-by: Dominic Battré <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#373}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Remove a wrong reset of selection visual rect
The wrong reset was added in https://chromium-review.googlesource.com/687868.
We should keep the current selection visual rect when there is no full
paint invalidation and change of selection.
[email protected]
(cherry picked from commit 806536f8f547da8e2f7be626ad0c95f39afb9476)
Bug: 780803
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I4b5f362ff8277874b2881ee38c1aeda5f02ce8ba
Reviewed-on: https://chromium-review.googlesource.com/752306
Reviewed-by: Philip Rogers <[email protected]>
Commit-Queue: Xianzhu Wang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#513646}
Reviewed-on: https://chromium-review.googlesource.com/754327
Reviewed-by: Xianzhu Wang <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#372}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[merge M62] Only save sync password hash when there's a password change
HashPasswordManager::SavePasswordHash() is called every time user signs
in and change password. If user's password is not changed, do not need
to update the prefs::kSyncPasswordHash or prefs::kSyncPasswordLengthAnd
Salt value.
This change helps password protection service to better determine if
user changed their sync password or not.
[email protected]
(cherry picked from commit 20c46444e0b3199d11a47c560b8da615facbbd1d)
Bug: 778022
Change-Id: Iaa9d01ceb00f773962b81b5f850d775d495df494
Reviewed-on: https://chromium-review.googlesource.com/749687
Reviewed-by: Vadym Doroshenko <[email protected]>
Commit-Queue: Jialiu Lin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#513592}
Reviewed-on: https://chromium-review.googlesource.com/754278
Reviewed-by: Jialiu Lin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#371}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Incrementing VERSION to 63.0.3239.35
[email protected]
Change-Id: Iab8b06ba8ca5609a182d93613ab8444df3cd97af
Reviewed-on: https://chromium-review.googlesource.com/753782
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#370}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}leveldb: Better handling of errno in GetDirectoryEntries.
Resetting before every call to readdir(2) will effectively ignore errno
if set by other library functions.
[email protected]
(cherry picked from commit bd8384efe5d33c92b6dd620140c2972ba9851fad)
Bug: 766896
Change-Id: I0592db543adb2081d97066f1c62d9599c549c24e
Reviewed-on: https://chromium-review.googlesource.com/736317
Reviewed-by: Erik Chen <[email protected]>
Commit-Queue: Chris Mumford <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511484}
Reviewed-on: https://chromium-review.googlesource.com/753285
Reviewed-by: Chris Mumford <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#369}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Map ENFILE error to FILE_ERROR_TOO_MANY_OPENED.
File::OSErrorToFileError() was only mapping EMFILE to
FILE_ERROR_TOO_MANY_OPENED. Mapping ENFILE is one less FILE_ERROR_FAILED
returned.
Will not fix issue 766896, but might produce better logs.
[email protected]
(cherry picked from commit 49330779ef21d72c982db7c95c82bf7b02aa1f52)
Bug: 766896
Change-Id: I2c2a0fafe15b0415da1c65cfe9b6f13cafe38206
Reviewed-on: https://chromium-review.googlesource.com/706545
Reviewed-by: Lei Zhang <[email protected]>
Commit-Queue: Chris Mumford <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#509666}
Reviewed-on: https://chromium-review.googlesource.com/753997
Reviewed-by: Chris Mumford <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#368}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[BlobStorage] Fixing potential overflow
Bug: 779314
Change-Id: I74612639d20544e4c12230569c7b88fbe669ec03
Reviewed-on: https://chromium-review.googlesource.com/747725
Reviewed-by: Victor Costan <[email protected]>
Commit-Queue: Daniel Murphy <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#512977}(cherry picked from commit 11bd4bc92f3fe704631e3e6ad1dd1a4351641f7c)
Reviewed-on: https://chromium-review.googlesource.com/754084
Reviewed-by: Daniel Murphy <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#367}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}By default, claim PNaCl needs a JIT update: CheckVersionCompatibility
is not called in the registration flow unless there is a version of
PNaCl already on disk.
Bug: 781011
Change-Id: I9be05564bd9a40df6dba7a8256cea286bf5aec24
Reviewed-on: https://chromium-review.googlesource.com/752049
Reviewed-by: Sorin Jianu <[email protected]>
Commit-Queue: Joshua Pawlicki <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#513627}(cherry picked from commit c59b0960eb1c82e9a3c18c97dc94bd2d464ca634)
Reviewed-on: https://chromium-review.googlesource.com/753804
Reviewed-by: Joshua Pawlicki <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#366}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Updating goodies dialog text to be a little more generic
BUG=chromium:777045
TEST=browser test
R=[email protected]
Change-Id: I8080782d2e5d6067421025753599054c3461dfa0
Reviewed-on: https://chromium-review.googlesource.com/733856
Reviewed-by: Toni Barzic <[email protected]>
Commit-Queue: Stephen Lin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511236}(cherry picked from commit a9948444c07063748d61e485cfad892a248665d2)
Reviewed-on: https://chromium-review.googlesource.com/744221
Cr-Commit-Position: refs/branch-heads/3239@{#365}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Avoid crashes caused by multiple DnsAttempts
When DnsUDPAttempt gets a mismatched response, it returns
ERR_DNS_MALFORMED_RESPONSE but keeps the attempt running while another
one starts. DnsTransaction doesn't handle this case very well. This CL
handles the two crashes that the fuzzer has found and adds a regression
test that catches both of them. There's a bug filed
(https://crbug.com/779589) for a more complete fix.
Bug: 768150, 774846
Change-Id: I0630d73a2e0d1cc179e7fe2139c030d58d25d90f
Reviewed-on: https://chromium-review.googlesource.com/743810
Reviewed-by: Julia Tuttle <[email protected]>
Commit-Queue: Miriam Gershenson <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#512864}(cherry picked from commit 1009208271f8f3af982c4d3d9c65fa86ea378f9c)
Reviewed-on: https://chromium-review.googlesource.com/753821
Reviewed-by: Miriam Gershenson <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#364}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Login: Fix horizontal flip for supervised user image grid.
Use flipped image instead of relying on css transform for image
preview. This allows both the grid image and the image preview
to be displayed correctly.
[email protected]
(cherry picked from commit 41e6d26e78c2426341f2210f8979be3de1aa8244)
Bug: 779519
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Icd0fb45f1dc433d490f24d5342c250197e96c11b
Reviewed-on: https://chromium-review.googlesource.com/743693
Reviewed-by: Steven Bennetts <[email protected]>
Commit-Queue: David Reveman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#512564}
Reviewed-on: https://chromium-review.googlesource.com/752584
Reviewed-by: David Reveman <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#363}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Settings: Don't pass JPEG images to WebUI as image/png
ProfileInfoHandler::GetAccountNameAndIcon expects
chromeos::UserImageSource::GetUserImage to return a PNG
image so webui::GetPngDataUrl can be used to create a
profile icon data url from it that can be used by WebUI.
This change makes UserImageSource::GetUserImage always
return a PNG image so that the assumptions made in
GetAccountNameAndIcon are correct.
JPEG images with image/png mime type happen to work
previously as Blink will ignore the mime type and look
at the image signature to determine how to decode it.
The code that was introduced to remove animations from
PNG images is not that smart.
[email protected]
(cherry picked from commit 7248fbb91cb22965fb1427b4e3bc416de7bfabb7)
Bug: 779042
Test: manual
Change-Id: Ib33821f9a25d38626aa939b2540b2a77487de4dc
Reviewed-on: https://chromium-review.googlesource.com/744907
Reviewed-by: Steven Bennetts <[email protected]>
Commit-Queue: David Reveman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#512653}
Reviewed-on: https://chromium-review.googlesource.com/753022
Reviewed-by: David Reveman <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#362}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Change Picture: Improve photo taking animations.
This improves the flash animation for photo taking by removing
the use of a mask-image in favor of a border that can be animated
and doesn't conflict with flash animations. This makes the removal
of the circular frame used for preview less jarring.
It also adjusts the delay of animations and defers image processing
so that flash animations have a chance to finish running. Single
photo mode uses white color ease-in animation, while video mode
uses a less intense flash with 0.67 opacity.
Last, it uses the first frame of PNGs as placeholder while
larger animated PNGs are loading from object URLs. This prevents
the loading from appearing as a flash.
[email protected]
(cherry picked from commit 111a20da92e6c9ad2bab07763d4cc5d3b4fd2c9e)
Bug: 773987
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ibd1a2ec06984a38df685d6f5e29963debcc91190
Reviewed-on: https://chromium-review.googlesource.com/742801
Commit-Queue: David Reveman <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#512612}
Reviewed-on: https://chromium-review.googlesource.com/753021
Reviewed-by: David Reveman <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#361}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Add defensive code against missing RarePaintData or LocalBorderBoxProperties in PaintLayerClipper. Under-invalidation of paint properties (from an unknown cause unfortunately) can lead to these situations.
(cherry picked from commit 6bb950b2225f27fd3883828a3e52d73af54ebd84)
Bug: 774946
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ic847595ce594cc93881e56b4620ece74aded5e54
Reviewed-on: https://chromium-review.googlesource.com/752691
Reviewed-by: Chris Harrelson <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#360}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Incrementing VERSION to 63.0.3239.34
[email protected]
Change-Id: Ic6cc8ad1692d130f7c5d2ae39132eb7d62b156be
Reviewed-on: https://chromium-review.googlesource.com/752383
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#359}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[MDC roll] Roll Material Components to 97c6738501082716b216db1bd880565815758c1b
[email protected], smut
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ibf3aeb60f9d8b67d37f5e8e1a83c25498e263797
Reviewed-on: https://chromium-review.googlesource.com/737437
Commit-Queue: iOS Autoroller <[email protected]>
Reviewed-by: iOS Autoroller <[email protected]>
Cr-Commit-Position: refs/heads/master@{#511626}
(cherry picked from commit c593a205309d6418a1cd6d72887516d181736c69)
Bug:
Change-Id: Iae1da0c05776af43ed0e45f467287cdbe2cb3983
Reviewed-on: https://chromium-review.googlesource.com/752200
Reviewed-by: Peter Lee <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#358}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Roll MDC to fe66153a064fd2faf16c4d5d4486d8b54932533c
Going from 656323ca63a39eba14487a374033fec9921cf0f2 to
fe66153a064fd2faf16c4d5d4486d8b54932533c needs some updates of the
BUILD.gn of MDC.
[email protected]
(cherry picked from commit c199d513a16f7a429af225628573906f277418da)
Bug: 775476
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I3f2b16d8442fef24d2fc3910662a29db6c8b8be6
Reviewed-on: https://chromium-review.googlesource.com/722962
Commit-Queue: Gauthier Ambard <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511506}
Reviewed-on: https://chromium-review.googlesource.com/752198
Reviewed-by: Peter Lee <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#357}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Enable hanging requests detection in Network quality estimation
Bug: 770897
Change-Id: I351a7990c7db4496af39b39fc62a501ff7b1db7c
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/740915
Reviewed-by: Ryan Sturm <[email protected]>
Commit-Queue: Tarun Bansal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#512285}(cherry picked from commit de34299ae0335072042638c1f310cb200a643e97)
Reviewed-on: https://chromium-review.googlesource.com/752204
Reviewed-by: Tarun Bansal <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#356}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Do not use NavigationEntry to block history navigations.
This is no longer necessary after r477371.
BUG=777419
TEST=See bug for repro steps.
[email protected]
(cherry picked from commit 56a84aa67bb071a33a48ac1481b555c48e0a9a59)
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I701e4d4853858281b43e3743b12274dbeadfbf18
Reviewed-on: https://chromium-review.googlesource.com/733959
Reviewed-by: Devlin <[email protected]>
Reviewed-by: Nasko Oskov <[email protected]>
Commit-Queue: Charlie Reis <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511942}
Reviewed-on: https://chromium-review.googlesource.com/751765
Reviewed-by: Charlie Reis <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#355}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Revert "[Reland-2] Merge-M63: Add a temporary fix for Blob lifetime with SW FetchEvent without MojoBlob"
This reverts commit e13b4e699084bd18cb4ded4a6c5d408c0b161555.
Change-Id: I5f2cfd8e946cf0d28d238732bda8fcfd5de6ef83
Reviewed-on: https://chromium-review.googlesource.com/752121
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#354}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Add a ScopedNestableTaskAllower to Fix Tab Navigation
MacOS's alert dialog seems to need allowing nestable tasks for tab
navigation to work.
BUG=778562
[email protected],[email protected],[email protected]
Change-Id: Ic8654defa4e6ec1c7089639108e8a937e923b486
Reviewed-on: https://chromium-review.googlesource.com/747849
Commit-Queue: Robert Liao <[email protected]>
Reviewed-by: Gabriel Charette <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Trent Apted <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#513270}(cherry picked from commit 4383d025f03ee11649c1cd0501e93a2ab20e5286)
Reviewed-on: https://chromium-review.googlesource.com/752042
Reviewed-by: Robert Liao <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#353}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Reland "[Merge to M63] Give NestableTasksAllowed() control back to MessageLoop."
This is a reland of 8661c6c3eacf31fbbc5c202a844b06bd0381e571
Original change's description:
> [Merge to M63] Give NestableTasksAllowed() control back to MessageLoop.
>
> While I still think RunLoop::Type::kNestableTasksAllowed is the right
> API to allow nesting of application tasks in the usual case:
> RunLoop::Delegate::Client::ProcessingTasksAllowed() wasn't the right
> level of abstraction for the allowance (even without the bug it suffered).
>
> When I hit https://bugs.chromium.org/p/chromium/issues/detail?id=754112#c6
> I initially thought the solution was for Client::ProcessingTasksAllowed()
> to return a scoped token to allow only a single application task at once
> per RunLoop instance. But implementing it (see PS1) it became apparent
> that this wasn't generally something most RunLoop::Delegates cared about.
> Rather it was a fallout of some MessageLoops which permit reentrancy
> without a nested RunLoop being involved (e.g. MessageLoop::Run() ->
> MessageLoop::RunTask() can go through an OS-driven MessagePump which can
> in some scenarios trigger reentrancy without a second call to Run()).
>
> This CL keeps the API in RunLoop to declare allowance but then tells
> RunLoop::Delegate::Run() via param whether it should allow application
> tasks for that layer. Leaving it up to the impl to determine how to
> control that.
>
> This ends up getting rid of the duality of the previous check in
> NestableTasksAllowed() as well. Now centralizing the logic in MessageLoop.
>
> Much simpler than the alternative (again, see PS1).
>
> While PS9 ended up keeping usage of a bool to control reentrancy (usage
> of racing counters (allowed vs used) proved useless as they were either
> equal or one off), it was renamed away from referring to "nestable tasks"
> as this makes the nomenclature very confusing with "nested loops" which
> are not the same thing at all. Instead we just name it
> "task_execution_allowed_" and leave it up to MessageLoop logic
> (DeferOrRunPendingTask()) to know to skip non-nestable tasks when inside
> a nested loop.
>
> For reference, see PS16-19 for attempts at making RunLoop be the sole
> controller of nesting/nestable tasks allowance. This was dropped for now as
> it proved to be ugly in conjunction with deprecated MessageLoop::*Nestable*
> APIs that still need to be supported until callers are migrated.
>
> [email protected], [email protected]
>
> (cherry picked from commit b030a4a0884a87640ad65e51b20847c6213b8eab)
>
> Bug: 754112
> Change-Id: I9f3a8431c00f69b0b5bb696e1e86e32bba6e6ffe
> Reviewed-on: https://chromium-review.googlesource.com/730864
> Reviewed-by: Robert Liao <[email protected]>
> Reviewed-by: danakj <[email protected]>
> Commit-Queue: Gabriel Charette <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#511673}
> Reviewed-on: https://chromium-review.googlesource.com/747281
> Reviewed-by: Gabriel Charette <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3239@{#319}
> Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[email protected],[email protected]
Bug: 754112
Change-Id: I8edbeb07e3dd2eb94029965aa4192e462316fd62
Reviewed-on: https://chromium-review.googlesource.com/752041
Reviewed-by: Robert Liao <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#352}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Merge to M63] Fix UI glitches during FRE transition on tablets.
[Merge note: there was a merge conflict, and as a result this change now
includes crrev.com/c/726375.]
On tablets where first run experience activity shows in a dialog, there
is a UI glitch (flash of white) when ChromeTabbedActivity (or any similar
fillscreen activity) transitions to FRE.
CTA transitions to FRE in onCreate(), aborting CTA launch and canceling
currently running window animation midway. By the time onCreate() is
called, the CTA window is already partially visible, so its removal is
perceived as a flash.
This CL introduces TabbedModeFRE activity, which has the same background
as CTA, but renders its content in a FRE-like dialog on tablets. Because
the background is the same, transition from CTA window looks smooth, and
since content is laid out as a dialog, the end experience looks like FRE
dialog appearing on top of starting CTA activity.
Bug: 771545
Change-Id: I4709a83de147e04ce94ba319cfa820a2ec6dea17
Reviewed-on: https://chromium-review.googlesource.com/723725
Commit-Queue: Dmitry Skiba <[email protected]>
Reviewed-by: Ted Choc <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#512893}
Reviewed-on: https://chromium-review.googlesource.com/751796
Reviewed-by: Dmitry Skiba <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#351}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Reland-2] Merge-M63: Add a temporary fix for Blob lifetime with SW FetchEvent without MojoBlob
Add a new method to ServiceWorkerFetchResponseCallback for
legacy blob which calls back to the caller when it's done, and
hold a (copy) of WebServiceWorkerResponse until it's fired.
WebServiceWorkerResponse is a copyable wrapper object of
scoped_refptr<WebServiceWorkerResponsePrivate>, which has
RefPtr<BlobDataHandle> in its member.
(cherry picked from commit 7640944da7ef7b5fa2e61165b9f317b9764e1161)
Bug: 776642
Change-Id: I0d6fff4ca64236a3d6ed69e1790db2c41ccae226
Reviewed-on: https://chromium-review.googlesource.com/734135
Commit-Queue: Daniel Cheng <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Marijn Kruisselbrink <[email protected]>
Reviewed-by: Matt Falkenhagen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511284}
Reviewed-on: https://chromium-review.googlesource.com/750925
Reviewed-by: Kinuko Yasuda <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#345}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
(cherry picked from commit 415422e42b4395802fbf0ef93e4930ee7bf04f79)
Change-Id: I68fe200c3f45a91c4064cc4cd3a2dd25c1257aa2
Reviewed-on: https://chromium-review.googlesource.com/751222
Reviewed-by: Kinuko Yasuda <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#347}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
(cherry picked from commit 13802e31c540e80248e04e8f262091a0767ce988)
[email protected]
Change-Id: I5d269b558b9cf39d32bbc57c292ab26edfc2e1aa
Reviewed-on: https://chromium-review.googlesource.com/751602
Reviewed-by: Kinuko Yasuda <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#350}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Revert "[Reland] Merge-M63: Add a temporary fix for Blob lifetime with SW FetchEvent without MojoBlob"
This reverts commit 13802e31c540e80248e04e8f262091a0767ce988.
[email protected]
Bug:
Change-Id: I4c64ff766602555f73887d7f4e93c7e9854c3294
Reviewed-on: https://chromium-review.googlesource.com/751601
Reviewed-by: Kinuko Yasuda <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#349}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Merge to M63] Fix moving tabs from CTA2 to CTA.
There is an issue in how Android handles LAUNCH_ADJACENT intent flag
when activity alias is involved. See the bug for the gory details.
This change avoids the issue by removing LAUNCH_ADJACENT flag in some
cases.
Bug: 771516
Change-Id: I7e5694f6fda1c4036e69fda5cc3cb02a9507578f
Reviewed-on: https://chromium-review.googlesource.com/741061
Commit-Queue: Dmitry Skiba <[email protected]>
Reviewed-by: Theresa <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#512282}(cherry picked from commit 5097f5016f81285095ae16f13d451883f89a8481)
Reviewed-on: https://chromium-review.googlesource.com/751581
Reviewed-by: Dmitry Skiba <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#348}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Reland] Merge-M63: Add a temporary fix for Blob lifetime with SW FetchEvent without MojoBlob
Add a new method to ServiceWorkerFetchResponseCallback for
legacy blob which calls back to the caller when it's done, and
hold a (copy) of WebServiceWorkerResponse until it's fired.
WebServiceWorkerResponse is a copyable wrapper object of
scoped_refptr<WebServiceWorkerResponsePrivate>, which has
RefPtr<BlobDataHandle> in its member.
(cherry picked from commit 7640944da7ef7b5fa2e61165b9f317b9764e1161)
Bug: 776642
Change-Id: I0d6fff4ca64236a3d6ed69e1790db2c41ccae226
Reviewed-on: https://chromium-review.googlesource.com/734135
Commit-Queue: Daniel Cheng <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Marijn Kruisselbrink <[email protected]>
Reviewed-by: Matt Falkenhagen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511284}
Reviewed-on: https://chromium-review.googlesource.com/750925
Reviewed-by: Kinuko Yasuda <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#345}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
(cherry picked from commit 415422e42b4395802fbf0ef93e4930ee7bf04f79)
Change-Id: I68fe200c3f45a91c4064cc4cd3a2dd25c1257aa2
Reviewed-on: https://chromium-review.googlesource.com/751222
Reviewed-by: Kinuko Yasuda <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#347}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Revert "Merge-M63: Add a temporary fix for Blob lifetime with SW FetchEvent without MojoBlob"
This reverts commit 415422e42b4395802fbf0ef93e4930ee7bf04f79.
[email protected]
Bug:
Change-Id: I8971310ca2ccf88ed8de095abec76145a44b3d46
Reviewed-on: https://chromium-review.googlesource.com/751221
Reviewed-by: Kinuko Yasuda <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#346}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Merge-M63: Add a temporary fix for Blob lifetime with SW FetchEvent without MojoBlob
Add a new method to ServiceWorkerFetchResponseCallback for
legacy blob which calls back to the caller when it's done, and
hold a (copy) of WebServiceWorkerResponse until it's fired.
WebServiceWorkerResponse is a copyable wrapper object of
scoped_refptr<WebServiceWorkerResponsePrivate>, which has
RefPtr<BlobDataHandle> in its member.
[email protected]
(cherry picked from commit 7640944da7ef7b5fa2e61165b9f317b9764e1161)
Bug: 776642
Change-Id: I0d6fff4ca64236a3d6ed69e1790db2c41ccae226
Reviewed-on: https://chromium-review.googlesource.com/734135
Commit-Queue: Daniel Cheng <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Marijn Kruisselbrink <[email protected]>
Reviewed-by: Matt Falkenhagen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511284}
Reviewed-on: https://chromium-review.googlesource.com/750925
Reviewed-by: Kinuko Yasuda <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#345}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Set the opener correctly when not supporting multiple windows
BUG=770518
[email protected]
[email protected]
(cherry picked from commit d03b3d0f6d78eca4ed174e9c496948b4e3068867)
Change-Id: I01b728704f525e06938865729dd4395f982908da
Reviewed-on: https://chromium-review.googlesource.com/735140
Reviewed-by: Richard Coles <[email protected]>
Commit-Queue: Jochen Eisinger <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511160}
Reviewed-on: https://chromium-review.googlesource.com/750087
Reviewed-by: Jochen Eisinger <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#344}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Merge "[NTP] Destroy Bookmarks and Downloads providers when CH..." M63.
This is a merge of https://chromium-review.googlesource.com/738178 into
M63 (branch 3239). There were no conflicts. I've verified the fix by
patching locally and manual testing on the device.
Original description
=====================
[NTP] Destroy Bookmarks and Downloads providers when CH is enabled.
Destroy Bookmarks and Downloads providers and disable their categories
when Chrome Home is enabled. Previously, to enable Chrome Home one had
to restart the app, thus, we did not have to do any special treatment.
Now Chrome Home can be enabled without a restart.
[email protected]
(cherry picked from commit 69689f31d8f6c1bd8a7156e257cf04990a2e281f)
Bug: 776725
Change-Id: I05f026942d89d7500b9dd5a7c5c75fcd664eea8c
Reviewed-on: https://chromium-review.googlesource.com/738178
Reviewed-by: Bernhard Bauer <[email protected]>
Reviewed-by: Jan Krcal <[email protected]>
Commit-Queue: vitaliii <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511504}
Reviewed-on: https://chromium-review.googlesource.com/741235
Reviewed-by: vitaliii <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#343}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Incrementing VERSION to 63.0.3239.33
[email protected]
Change-Id: Id3eb32a1621ab27f3e7dafea95850fe18864ca5c
Reviewed-on: https://chromium-review.googlesource.com/750641
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#342}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Incrementing VERSION to 63.0.3239.32
[email protected]
Change-Id: Ia17d536b9b36d0f21e281c44ec6578290b182265
Reviewed-on: https://chromium-review.googlesource.com/750386
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#341}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Revert "[Chromoting] Set min-bitrate of video channel to 0"
This reverts commit e73f847bc53b227cb7cf88f7f9d1ba19c3d86108.
Reason for revert: WebRTC may also give us a unreasonable low bandwidth estimation.
Original change's description:
> [Chromoting] Set min-bitrate of video channel to 0
>
> According to SendSideBandwidthEstimation,
> https://cs.chromium.org/chromium/src/third_party/webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc?rcl=033ea5f77140eef0c2defd4bd668de5dac9af3ea&l=392
> the bitrate_bps won't be smaller than min_bitrate_configured_, i.e. the field
> set by x-google-min-bitrate. This behavior is wrong or at least not what we have
> expected in WebrtcTransport: when the bandwidth is fully used by video channel,
> returning x-google-min-bitrate as the bitrate from OnTargetBitrateChanged() is
> not expected.
>
> I have verified this change on my machine, and it partially resolves the laggy
> issue.
>
> Bug: chromium:769391
> Change-Id: I2c87a78af63b508b5f8b25b77e171c92a10c7426
> Reviewed-on: https://chromium-review.googlesource.com/726312
> Commit-Queue: Zijie He <[email protected]>
> Reviewed-by: Lambros Lambrou <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#509960}
[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:769391
Change-Id: Ie93ec826e653d040cb5ffd741e69077fab2c2eaf
Reviewed-on: https://chromium-review.googlesource.com/749921
Reviewed-by: Zijie He <[email protected]>
Commit-Queue: Zijie He <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#513294}(cherry picked from commit 70febf8c7f665b5c4a9051b589981bf37db7ef7e)
Reviewed-on: https://chromium-review.googlesource.com/750163
Cr-Commit-Position: refs/branch-heads/3239@{#340}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Merge M63] arc: Don't remove default apps from App Launcher in case PAI is delayed.
This resolves race condition when App Launcher expects that installation
starts for default app and delay on Eve caused by Assistant flow.
Bug: b/68400737
Test: Manually on device. Spinning animation for deferred launch and
app in App Launcher persist while Assistant flow is active. Unit
tests extended
[email protected]
(cherry picked from commit 777688dcdfc744dc7c85eb0f9cfc6c71e5d9b279)
Change-Id: I7756987b20af6a7ef4e6b94db86acc61221559f2
Reviewed-on: https://chromium-review.googlesource.com/742648
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Yury Khmel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#512505}
Reviewed-on: https://chromium-review.googlesource.com/749636
Reviewed-by: Yury Khmel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#339}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[merge-m63] Mac: Make the Cocoa blocked plugins bubble shorter.
Now that flash is the only plugin, this dialog has a lot less to say,
and has too much unwanted white space.
The height of the Cocoa bubble is a hardcoded magic number specific to
this dialog. Make it smaller. The dialog will be replaced with
a toolkit-views version soon.
[email protected]
(cherry picked from commit 5f966630e46da3fc1fa5858e4d4db4118b09943e)
Bug: 773218
Change-Id: Ie828c7d88415c3e1d42c7e280fdd5bae60e8cb71
Reviewed-on: https://chromium-review.googlesource.com/746461
Reviewed-by: Bret Sepulveda <[email protected]>
Commit-Queue: Trent Apted <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#512964}
Reviewed-on: https://chromium-review.googlesource.com/749607
Reviewed-by: Trent Apted <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#338}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Fix Stack Buffer Overflow in QuicClientPromisedInfo::OnPromiseHeaders
BUG=777728
[email protected]
(cherry picked from commit 7a6484fa7b7f86ea06749bfc9d10bb67b145140b)
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I6a80db88aafdf20c7abd3847404b818565681310
Reviewed-on: https://chromium-review.googlesource.com/748425
Reviewed-by: Zhongyi Shi <[email protected]>
Commit-Queue: Ryan Hamilton <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#513105}
Reviewed-on: https://chromium-review.googlesource.com/750065
Reviewed-by: Ryan Hamilton <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#337}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Calculate original content length using new OFCL value in Chrome-Proxy
OFCL value is added in Chrome-Proxy header that indicates the content
length of the entire resource. This needs to be used instead of XOCL
header. For range responses, OFCL indicates the length of the entire
resource. It should be used with received response length and total
length of the resource in range response header., to calculate the
original content length.
(cherry picked from commit 6969ecd20ffb7622e865820056a8d78e0607ac64)
Bug: 723853
Change-Id: Ia9caaa2eeaf09a6ebd0a6e7500cd6e787b836a12
Reviewed-on: https://chromium-review.googlesource.com/669220
Commit-Queue: rajendrant <[email protected]>
Reviewed-by: Tarun Bansal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511771}
Reviewed-on: https://chromium-review.googlesource.com/749668
Reviewed-by: rajendrant <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#336}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Modified the setRemoteDescription-offer.html
Modifed the setRemoteDescription-offer tests to unblock the CL
(https://webrtc-review.googlesource.com/c/src/+/9621).
Two different peerconnections are used in new tests. The remote offer is
generated by a different peerconnection instead of using the 'generateOffer'
method.
In test 'setRemoteDescription multiple times with diffrerent offer shoud succeed',
setLocalDescription is called before creating a subsequent offer. To support the
unified plan SDP, the order of the m= sections shoud be enforced in subsequent
offer.
Added a new test which sets the same remote offer as remote description multiple
times.
Modified the expected output based on new tests.
Based on a Github PR: https://github.com/w3c/web-platform-tests/pull/7893/files
[email protected], [email protected]
(cherry picked from commit e3dc12451acb5ce3397fdf6506607145c4ee681f)
Bug: chromium:773620
Change-Id: Id947c05e795f9fabd60200a20adad02d278218bd
Reviewed-on: https://chromium-review.googlesource.com/736318
Commit-Queue: Zhi Huang <[email protected]>
Reviewed-by: Henrik Boström <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511902}
Reviewed-on: https://chromium-review.googlesource.com/744588
Cr-Commit-Position: refs/branch-heads/3239@{#335}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Revert "[Desktop Capturer] Use new DesktopAndCursorComposer constructor"
This reverts commit cf3aebae2044c573b4b23a2fa490ff0cc3d2bfe0.
Reason for revert: The new API breaks on X11 and Mac OSX.
Original change's description:
> [Desktop Capturer] Use new DesktopAndCursorComposer constructor
>
> After several changes, we finally removed the dependency of SourceId in
> MouseCursorMonitor. Now DesktopAndCursorComposer provides a clearer
> constructor for its clients.
>
> Bug: webrtc:7950
> Change-Id: I8716d736897637412e712fcc2b2d17ef0acf3eab
> Reviewed-on: https://chromium-review.googlesource.com/651147
> Commit-Queue: Zijie He <[email protected]>
> Reviewed-by: Jamie Walch <[email protected]>
> Reviewed-by: Weiyong Yao <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#500761}
[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: webrtc:7950, chromium:778035, chromium:778049
Change-Id: I45fbc68ae52194164828bc34207fe849850a98bf
Reviewed-on: https://chromium-review.googlesource.com/746947
Reviewed-by: Weiyong Yao <[email protected]>
Reviewed-by: Zijie He <[email protected]>
Commit-Queue: Zijie He <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#512976}(cherry picked from commit a511b3d8f416498d105a3a42e7c95b16ba2e4d5d)
Reviewed-on: https://chromium-review.googlesource.com/749104
Cr-Commit-Position: refs/branch-heads/3239@{#334}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Chromoting] Avoid crashing when media foundation is not present on the system
According to a very old bug,
(https://bugs.chromium.org/p/chromium/issues/detail?id=339678),
we should LoadLibrary(), i.e.
MediaFoundationVideoEncodeAccelerator::PreSandboxInitialization() before calling
MFStartup(), i.e. InitializeMediaFoundation() to avoid crashes within DelayLoad.
See the bug for details.
Bug: chromium:775563
Change-Id: I7c54569304b8806095a32b009bed5bec287e91f1
Reviewed-on: https://chromium-review.googlesource.com/723774
Commit-Queue: Zijie He <[email protected]>
Reviewed-by: Lambros Lambrou <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#509563}(cherry picked from commit 282709e964c1b4e6cf7c0781a511d7c409dff9a2)
Reviewed-on: https://chromium-review.googlesource.com/748686
Reviewed-by: Zijie He <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#333}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Cherry-pick 'Reland "Stop building SkCodec"'
Bug: 779261
This is a reland of fd493b4bc80363d51a4c142ddf287d38e86fc1f5
Original change's description:
> Stop building SkCodec
>
> Bug: 768878
>
> Building SkCodec seems to have caused a paint regression on a webpage
> without any images. This leads us to suspect "some minor compiler
> optimization tickling". Stop building it to confirm. Two CLs rely on
> SkCodec:
>
> "Use SkCodec internally in GIFImageDecoder"
> 4fed3346549a90c0de40c02f6388e19e8151e92a. This introduced building
> SkCodec.
>
> "Enable Skia's SkImageGenerator implementation"
> f5eb27c2b897f206b275fd862e874b64159cc15e. This used SkCodec to fix
> crbug.com/758459, but that seems to have been fixed in another way.
>
> In addition, this corrects some formatting in the old code (as
> commanded by presubmit), and makes some other minor changes (no more
> PassRefPtr, FrameDurationAtIndex now returns a TimeDelta).
>
> Change-Id: Ic2bdd87740da0232c9c07e27eed6049efc26d76c
> Reviewed-on: https://chromium-review.googlesource.com/718918
> Commit-Queue: Leon Scroggins <[email protected]>
> Reviewed-by: Chris Blume <[email protected]>
> Reviewed-by: Fredrik Söderquist <[email protected]>
> Reviewed-by: Leon Scroggins <[email protected]>
> Reviewed-by: Philip Rogers <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#509570}
[email protected]
(cherry picked from commit 8bf6a886aad1c42210fd16f372097236db34c162)
Bug: 768878
Change-Id: I18ce8032a1154f222d7392ac5a48b4cd5ec31672
Reviewed-on: https://chromium-review.googlesource.com/730484
Reviewed-by: Philip Rogers <[email protected]>
Reviewed-by: Leon Scroggins <[email protected]>
Commit-Queue: Leon Scroggins <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#510847}
Reviewed-on: https://chromium-review.googlesource.com/743691
Cr-Commit-Position: refs/branch-heads/3239@{#332}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Incrementing VERSION to 63.0.3239.31
[email protected]
Change-Id: I027b6cc6a5f80afe0c9580a19e5261dcf5ad7c0b
Reviewed-on: https://chromium-review.googlesource.com/748244
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#331}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Fix ClearStoragePreRunUsage histogram name (M63 merge)
This histogram was renamed but the code reporting it was not updated
accordingly. This CL fixes that.
Bug: 775321
Change-Id: I155239b3ccf187754c0c2536f6f44535ac3fe089
Reviewed-on: https://chromium-review.googlesource.com/737957
Reviewed-by: Justin DeWitt <[email protected]>
Reviewed-by: Peter Williamson <[email protected]>
Commit-Queue: Carlos Knippschild <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511647}(cherry picked from commit 7169f118b1c26911a504e1746d33559c345e8045)
Reviewed-on: https://chromium-review.googlesource.com/748281
Reviewed-by: Carlos Knippschild <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#330}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[M63 Merge]Verify that uris are valid for manual printers.
Prevent saving a printer if the uri is invalid. Validation in the UI
will be added in a follow up.
[email protected]
(cherry picked from commit 2efa89716a76a299613c3fb5ac2cd7679ce81d4a)
Bug: 778383
Change-Id: I584c8d63248da6aadd7cb7cbef0cea4d2fd80cc2
Reviewed-on: https://chromium-review.googlesource.com/742266
Reviewed-by: Xiaoqian Dai <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Commit-Queue: Sean Kau <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#512543}
Reviewed-on: https://chromium-review.googlesource.com/747883
Reviewed-by: Sean Kau <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#329}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
