Page MenuHomePhabricator

Redirect graphic not shown in preview
Closed, ResolvedPublic

Description

Author: erjohan

Description:
When you editing a REDIRECT page, the preview will not show you the graphics for
redirection, but borken wiki formatation.


Version: unspecified
Severity: trivial
URL: http://sv.wikipedia.org/w/index.php?title=V%E4durs_pump&action=edit

Details

Reference
bz2333

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 8:31 PM
bzimport set Reference to bz2333.
bzimport added a subscriber: Unknown Object (MLST).

gangleri wrote:

works for me with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.8) Gecko/rMW200505116d94
Firefox/1.0.4

erjohan wrote:

Are you sure it works, I've tried on a couple of computers and it's the same.
That is it will not *verify* that what you have written is a redirection.

You will get the same list as if you wrote

a numbered thingy [[link here]]

See:
http://en.wikipedia.org/w/index.php?title=Village_pump&action=edit

that is it will be formated as a numberedlist. This is not what it should look
like instead the preview should look like this:

http://en.wikipedia.org/w/index.php?title=Village_pump&redirect=no

rowan.collins wrote:

If I remember rightly, trhe redirect graphic/message is added in Article.php
when the page is discovered to be a redirect but &redirect=no is in effect. I
always thought it would make more sense if it was in Parser.php so that whenever
a page was displayed that should be a redirect, it would appear with the symbol,
allowing you to check your syntax with a preview. But yes, I should have just
fixed it myself if I was that bothered :/

gangleri wrote:

sorry for comment 1
I did not pay attention to *preview*.

Regards Reinhardt [[user:gangleri]]

gangleri wrote:

Testcase
http://yi.wiktionary.org/w/index.php?title=pruv.png&redirect=no

shows a redirect to an image in the syntax
#REDIRECT [[image:foo]]
and *not*
#REDIRECT [[:image:foo]]

best regards Reinhardt [[user:gangleri]]

gangleri wrote:

bug 4873 comment 2 mentions lack of redirect graphic in diff
Bug 4873: Next and previous revision links hidden on old-revision view of
redirect text

(In reply to comment #2)
Yes how silly. On preview it interprets the # as a numbered list, despite the correct REDIRECT formatting.
One has to go double check that he is sure he got the formatting correct, despite the just plain wrong
preview, and then muster his courage to hit the Save button anyway.

Yes, sorry to need to complicate the PHP code more, but still: looks bad, feels bad.

robchur wrote:

*** Bug 11693 has been marked as a duplicate of this bug. ***

*** Bug 13769 has been marked as a duplicate of this bug. ***

  • Bug 14484 has been marked as a duplicate of this bug. ***
  • Bug 14886 has been marked as a duplicate of this bug. ***