Spec URL: https://slaanesh.fedorapeople.org/aribb24.spec SRPM URL: https://slaanesh.fedorapeople.org/aribb24-1.0.3-1.20160216git5e9be27.fc40.src.rpm Description: A library for ARIB STD-B24, decoding JIS 8 bit characters and parsing MPEG-TS stream. Fedora Account System Username: slaanesh
Copr build: https://copr.fedorainfracloud.org/coprs/build/7939920 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2307694-aribb24/fedora-rawhide-x86_64/07939920-aribb24/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - Not a valid SPDX expression 'LGPL-3.0'. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://slaanesh.fedorapeople.org/aribb24.spec SRPM URL: https://slaanesh.fedorapeople.org/aribb24-1.0.3-2.20160216git5e9be27.fc40.src.rpm Fixed SPDX license identifier and build requirements.
Created attachment 2045031 [details] The .spec file difference from Copr build 7939920 to 7953282
Copr build: https://copr.fedorainfracloud.org/coprs/build/7953282 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2307694-aribb24/fedora-rawhide-x86_64/07953282-aribb24/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
First off, this has not been updated upstream in years; it is really still useful? Adding the git snapshot information to Release is deprecated; current guidelines state these should be in Version instead: https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots Which would look something like: Version: 1.0.3%{!?tag:^%{date}git%{shortcommit0}} Release: 2%{?dist} BTW, why is release 2 and not 1? Drop the Requires: pkg-config from -devel. In %files devel, change %{_includedir}/%{name}/*.h to just %{_includedir}/%{name}/ so that the directory is also owned.
(In reply to Yaakov Selkowitz from comment #5) > First off, this has not been updated upstream in years; it is really still > useful? It has been the main support in ffmpeg (and still is) for anything ARIB STD-B24. I think it will be eventually replaced completely by libaribcaption, but I can't tell. > Adding the git snapshot information to Release is deprecated; current > guidelines state these should be in Version instead: > > https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/ > #_snapshots > > Which would look something like: > > Version: 1.0.3%{!?tag:^%{date}git%{shortcommit0}} > Release: 2%{?dist} Doh, I was not aware it changed. I guess I will update all packages that I maintain with snapshots in the name. > BTW, why is release 2 and not 1? Leftover I guess, I will reuse 1. > Drop the Requires: pkg-config from -devel. > > In %files devel, change %{_includedir}/%{name}/*.h to just > %{_includedir}/%{name}/ so that the directory is also owned. Done.
Spec URL: https://slaanesh.fedorapeople.org/aribb24.spec SRPM URL: https://slaanesh.fedorapeople.org/aribb24-1.0.3.20160216git5e9be27-3.fc40.src.rpm Updated, sorry for the delay. I've left revision 3 as it will update the package from my repository and remove it, and it already contains a bit of history.
Version is still incorrect per the guidelines; please review my comment above and the link therein. Following those will make the version higher than your previous build in your repo, so Release should still be 1. Again, drop the Requires: pkg-config from -devel. Add %doc README.md to %files.