Spec URL: https://ankursinha.fedorapeople.org/reviews/rust-google-cloud-token/rust-google-cloud-token.spec SRPM URL: https://ankursinha.fedorapeople.org/reviews/rust-google-cloud-token/rust-google-cloud-token-0.1.2-1.fc42.src.rpm Description: Google Cloud Platform token spec.
The same comments I made on the google-cloud-metadata ticket apply here as well. https://bugzilla.redhat.com/show_bug.cgi?id=2307641#c1
Spec URL: https://ankursinha.fedorapeople.org/reviews/rust-google-cloud-token/rust-google-cloud-token.spec SRPM URL: https://ankursinha.fedorapeople.org/reviews/rust-google-cloud-token/rust-google-cloud-token-0.1.2-2.fc42.src.rpm - fix: correct license listing
Copr build: https://copr.fedorainfracloud.org/coprs/build/7939807 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2307644-rust-google-cloud-token/fedora-rawhide-x86_64/07939807-rust-google-cloud-token/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Created attachment 2044736 [details] The .spec file difference from Copr build 7939807 to 7939810
Copr build: https://copr.fedorainfracloud.org/coprs/build/7939810 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2307644-rust-google-cloud-token/fedora-rawhide-x86_64/07939810-rust-google-cloud-token/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Hi Fabio, I think this one is also ready for another round of review. Cheers,
Looks good to me now, thank you! I left some more comments in the other approved review. === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora 🫤 license file is included with %license in %files (temporarily manually included from upstream) ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-google-cloud-token
Imported and built.