Spec URL: https://raw.githubusercontent.com/retis-org/copr-playground/main/rust-derive-into-owned.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/@retis/playground/fedora-rawhide-x86_64/07884763-rust-derive-into-owned/rust-derive-into-owned-0.2.0-1.fc41.src.rpm Description: Custom derives to help with types containing Cow fields Build: https://copr.fedorainfracloud.org/coprs/g/retis/playground/build/07884763 Fedora Account System Username: atenart, pvaler, amorenoz I’m starting this review request on behalf of Paolo, Adrián and me. We’d like to maintain it as a group. It’s our first package and we’ll need a sponsor.
Copr build: https://copr.fedorainfracloud.org/coprs/build/7708108 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2295805-rust-derive-into-owned/fedora-rawhide-x86_64/07708108-rust-derive-into-owned/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Please provide URLs to raw files, not HTML pages. Otherwise tooling will not be able to parse this ticket.
[fedora-review-service-build]
Copr build: https://copr.fedorainfracloud.org/coprs/build/7773647 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2295805-rust-derive-into-owned/fedora-rawhide-x86_64/07773647-rust-derive-into-owned/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
> # FIXME: no license files detected It looks like you used "rust2rpm --ignore-missing-license-files" *and* didn't actually fix the FIXME? The MIT license requires that redistributed sources contain a copy of the license text. It looks like the upstream project added a license file after publishing the latest release: https://github.com/koivunej/derive-into-owned Please file an issue upstream about getting a new release that contains the license text. In the meantime, you can include the license file from GitHub as a separate source. For Rust packages, we usually handle this case like it is handled here: https://src.fedoraproject.org/rpms/rust-backtrace-ext/blob/rawhide/f/rust-backtrace-ext.spec (except that you only have one LICENSE file instead of LICENSE-APACHE and LICENSE-MIT, of course)
Thanks for the feedback. The spec file has been updated as per your suggestion including the license file as a separate source. An issue [1] has been filed requesting a new release and both SRPM URL and Build links have been updated in the BZ description to reference the latest build. [1] https://github.com/koivunej/derive-into-owned/issues/19
Spec URL: https://raw.githubusercontent.com/retis-org/copr-playground/main/rust-derive-into-owned.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/@retis/playground/fedora-rawhide-x86_64/07884763-rust-derive-into-owned/rust-derive-into-owned-0.2.0-1.fc41.src.rpm Description: Custom derives to help with types containing Cow fields
Thanks for adding the file as an additional source and filing an issue upstream. However, the file is now just unused in the package. You still need to put it into the correct place and mark it as a license file: - do something equivalent to `cp %{SOURCE1} .` at the end of the %prep scriptlet (i.e. after the %cargo_prep line) - add this line at the start of the %files list for the "devel" subpackage: `%license %{crate_instdir}/LICENSE`
argh, I missed those, sorry about it. Now the license file should be copied and marked. Spec URL: https://raw.githubusercontent.com/retis-org/copr-playground/main/rust-derive-into-owned.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/@retis/playground/fedora-rawhide-x86_64/07953228-rust-derive-into-owned/rust-derive-into-owned-0.2.0-1.fc42.src.rpm Description: Custom derives to help with types containing Cow fields Build: https://copr.fedorainfracloud.org/coprs/g/retis/playground/build/7953228/
Thank you, looks good to me now! === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora 🫤 license file is included with %license in %files (termporarily manually included from upstream) ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) === If you need help with any of the following steps, feel free to reach out on the #rust channel on the Fedora Matrix homeserver.