Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-substrait-io.spec SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-substrait-io-0.4.2-1.fc40.src.rpm Description: Experimental Go bindings for substrait. Fedora Account System Username: eclipseo
Copr build: https://copr.fedorainfracloud.org/coprs/eclipseo/gotests/build/7657108/ (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/eclipseo/gotests/fedora-rawhide-x86_64/07657108-golang-github-substrait-io/fedora-review/review.txt Please take a look if any issues were found.
Copr build: https://copr.fedorainfracloud.org/coprs/build/7657428 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2293883-golang-github-substrait-io/fedora-rawhide-x86_64/07657428-golang-github-substrait-io/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
In https://discussion.fedoraproject.org/t/4-go-packages-to-review/123119 you mention this package needs to be boostrapped, but it built just fine for me. This package was generated using go2rpm, which simplifies the review. Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated - [x] The latest version is packaged or packaging an earlier version is justified. - [x] The License tag reflects the package contents and uses the correct identifiers. - [x] The package builds successfully in mock. - [x] Package is installable (checked by fedora-review). - [x] There are no relevant rpmlint errors. - [x] The package runs tests in %check. - [x] `%goipath` is set correctly. - [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names) - [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default) - [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86. - [x] The package complies with the Golang and general Packaging Guidelines. Package approved! On import, don't forget to do the following: - [ ] Add the package to release-monitoring.org - [ ] Give go-sig privileges (at least commit) on the package - [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket. - [ ] Consider configuring Packit service to help with maintenance Thanks!
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-substrait-io