Spec URL: https://osteffen.fedorapeople.org/packages/rust-bitfield-struct/rust-bitfield-struct.spec SRPM URL: https://osteffen.fedorapeople.org/packages/rust-bitfield-struct/rust-bitfield-struct-0.6.2-1.fc41.src.rpm Description: Procedural macro for bitfields that allows specifying bitfields as structs. As this library provides a procedural macro, it has no runtime dependencies and works for no-std environments. Fedora Account System Username: osteffen This crate is packaged directly from crates.io, just the summary and description strings were shortened. This is part of the effort to add the Coconut-SVSM paravisor to Fedora. It would enables Fedora virtualization hosts to launch confidential virtual machines using AMD's SEV-SNP technology. See https://fedoraproject.org/wiki/Changes/ConfidentialVirtHostAMDSEVSNP
Copr build: https://copr.fedorainfracloud.org/coprs/build/7542849 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2290696-rust-bitfield-struct/fedora-rawhide-x86_64/07542849-rust-bitfield-struct/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Two questions: 1. The latest release is 0.8.0. You are packaging 0.6.2. Do you specifically need a version in the >=0.6,<0.7 range? 2. The "summary and description strings were shortened" comment is a bit confusing to me. Your Summary and descriptions are both *longer* than the one generated by rust2rpm: +Struct-like procedural macro for bit-fields -Struct-like procedural macro for bitfields And the bug title doesn't match the summary of the package.
(In reply to Fabio Valentini from comment #2) > Two questions: > > 1. The latest release is 0.8.0. You are packaging 0.6.2. Do you specifically > need a version in the >=0.6,<0.7 range? The dependent crate (still to be packaged) currently requires 0.7.0. Updating the spec file to that version. > 2. The "summary and description strings were shortened" comment is a bit > confusing to me. Your Summary and descriptions are both *longer* than the > one generated by rust2rpm: > > +Struct-like procedural macro for bit-fields > -Struct-like procedural macro for bitfields True. The comment should be: Changed Summary and Description, changing the spelling of 'bitfields' to make the linter happy. > And the bug title doesn't match the summary of the package. That was the summary from crates.io which does not match the crate file. Fixed.
pec URL: https://osteffen.fedorapeople.org/packages/rust-bitfield-struct/rust-bitfield-struct.spec SRPM URL: https://osteffen.fedorapeople.org/packages/rust-bitfield-struct/rust-bitfield-struct-0.7.0-1.fc41.src.rpm Description: Struct-like procedural macro for bit-fields Fedora Account System Username: osteffen This crate is packaged directly from crates.io, just the summary and description strings were modified, changing the spelling of 'bitfields' to make the linter happy. This is part of the effort to add the Coconut-SVSM paravisor to Fedora. It would enables Fedora virtualization hosts to launch confidential virtual machines using AMD's SEV-SNP technology. See https://fedoraproject.org/wiki/Changes/ConfidentialVirtHostAMDSEVSNP
Created attachment 2039400 [details] The .spec file difference from Copr build 7542849 to 7722319
Copr build: https://copr.fedorainfracloud.org/coprs/build/7722319 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2290696-rust-bitfield-struct/fedora-rawhide-x86_64/07722319-rust-bitfield-struct/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
v0.7.0 gained a new dev-dependency: rust-endian-num See Review Request https://bugzilla.redhat.com/show_bug.cgi?id=2297082
V0.8.0 has been released in the meantime. Please update.
(In reply to Zbigniew Jędrzejewski-Szmek from comment #8) > V0.8.0 has been released in the meantime. Please update. Correction: Only update if what you're working on is compatible with v0.8.