Spec URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07229288-cosmic-panel/cosmic-panel.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07229288-cosmic-panel/cosmic-panel-0.1.0~20240329.00-1.fc41.src.rpm Description: COSMIC panel runs the panels for the cosmic desktop environment, and can run configurable applets for each panel (see cosmic-applets) Fedora Account System Username: ryanabx
Copr build: https://copr.fedorainfracloud.org/coprs/build/7230922 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2272134-cosmic-panel/fedora-rawhide-x86_64/07230922-cosmic-panel/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - Not a valid SPDX expression 'GPL-3.0'. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07338636-cosmic-panel/cosmic-panel.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07338636-cosmic-panel/cosmic-panel-0.1.0~git20240423.04.5bbaf97-1.fc41.src.rpm Description: COSMIC panel runs the panels for the cosmic desktop environment, and can run configurable applets for each panel (see cosmic-applets) Fedora Account System Username: ryanabx
Spec URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07377365-cosmic-panel/cosmic-panel.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07377365-cosmic-panel/cosmic-panel-0.1.0~git20240426.18.5bbaf97-1.fc41.src.rpm Description: COSMIC panel runs the panels for the cosmic desktop environment, and can run configurable applets for each panel (see cosmic-applets) Fedora Account System Username: ryanabx
Spec URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07794907-cosmic-panel/cosmic-panel.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07794907-cosmic-panel/cosmic-panel-0.1.0~%5E20240725.211016gitd5fc4dd-1.fc41.src.rpm Description: COSMIC panel runs the panels for the cosmic desktop environment, and can run configurable applets for each panel (see cosmic-applets) Fedora Account System Username: ryanabx
In my initial review, I did find a serious issue: the "GPL-3.0" license identifier needs to be clarified. It looks like the sources indicate the codebase is GPLv3, but there is a complete lack of identifying marks about whether it's GPL-3.0-only or GPL-3.0-or-later. The license default is "GPL-3.0-or-later", but I recommend contacting upstream to make a decision on indicating this somehow. The GNU licenses recommend some kind of license header on source files, and I would say that's probably the right thing to do too. I suspect this is necessary for all COSMIC projects. Here's a suggested header template (from some projects I've seen): /* This file is part of {project}. * * Copyright System76, Inc. * * Licensed under the GNU General Public License Version 3 * Fedora-License-Identifier: GPLv3+ * SPDX-2.0-License-Identifier: GPL-3.0+ * SPDX-3.0-License-Identifier: GPL-3.0-or-later * * {project} is free software: you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation, either version 3 of the License, or * (at your option) any later version. * * {project} is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with {project}. If not, see <https://www.gnu.org/licenses/>. */ An simpler alternative that can work is something like this: /* * This file is part of {project} * Copyright System76, Inc. * * Fedora-License-Identifier: GPLv3+ * SPDX-2.0-License-Identifier: GPL-3.0+ * SPDX-3.0-License-Identifier: GPL-3.0-or-later * * This program is free software. * For more information on the license, see LICENSE.md. * For more information on free software, see <https://www.gnu.org/philosophy/free-sw.en.html>. */
The "Fedora-License-Identifier" stuff can probably be skipped over, though I use it for mine since there are other distributions using that system besides Fedora that benefit from it.
Spec URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07798725-cosmic-panel/cosmic-panel.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07798725-cosmic-panel/cosmic-panel-0.1.0~%5E20240728.041606git49a40f0-1.fc41.src.rpm Description: COSMIC panel runs the panels for the cosmic desktop environment, and can run configurable applets for each panel (see cosmic-applets) Fedora Account System Username: ryanabx
Created attachment 2040652 [details] The .spec file difference from Copr build 7230922 to 7799189
Copr build: https://copr.fedorainfracloud.org/coprs/build/7799189 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2272134-cosmic-panel/fedora-rawhide-x86_64/07799189-cosmic-panel/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - Not a valid SPDX expression '0BSD OR MIT OR Apache-2.0 AND Apache-2.0 AND Apache-2.0 OR BSD-3-Clause AND Apache-2.0 OR MIT AND Apache-2.0 WITH LLVM-exception OR Apache-2.0 OR MIT AND BSD-3-Clause AND BSL-1.0 AND CC0-1.0 AND GPL-3.0 AND ISC AND MIT AND MIT OR Apache-2.0 AND MIT OR Apache-2.0 OR CC0-1.0 AND MIT OR Apache-2.0 OR Zlib AND MIT OR Zlib OR Apache-2.0 AND MPL-2.0 AND Unlicense OR MIT AND Zlib AND Zlib OR Apache-2.0 OR MIT'. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Created attachment 2040653 [details] The .spec file difference from Copr build 7799189 to 7799209
Copr build: https://copr.fedorainfracloud.org/coprs/build/7799209 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2272134-cosmic-panel/fedora-rawhide-x86_64/07799209-cosmic-panel/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - Not a valid SPDX expression '0BSD OR MIT OR Apache-2.0 AND Apache-2.0 AND Apache-2.0 OR BSD-3-Clause AND Apache-2.0 OR MIT AND Apache-2.0 WITH LLVM-exception OR Apache-2.0 OR MIT AND BSD-3-Clause AND BSL-1.0 AND CC0-1.0 AND GPL-3.0 AND ISC AND MIT AND MIT OR Apache-2.0 AND MIT OR Apache-2.0 OR CC0-1.0 AND MIT OR Apache-2.0 OR Zlib AND MIT OR Zlib OR Apache-2.0 AND MPL-2.0 AND Unlicense OR MIT AND Zlib AND Zlib OR Apache-2.0 OR MIT'. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.