Spec URL: https://hobbes1069.fedorapeople.org/sioclient.spec SRPM URL: https://hobbes1069.fedorapeople.org/sioclient-cpp-3.1.0-1.fc39.src.rpm Description: Library that enables low-latency, bidirectional and event-based communication between a client and a server. Fedora Account System Username: hobbes1069
Copr build: https://copr.fedorainfracloud.org/coprs/build/7208171 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2271219-sioclient-cpp/fedora-rawhide-x86_64/07208171-sioclient-cpp/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Header files in -devel subpackage, if present. Note: sioclient-cpp : /usr/include/sio_client.h sioclient-cpp : /usr/include/sio_message.h sioclient-cpp : /usr/include/sio_socket.h See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages - Spec file name must match the spec package %{name}, in the format %{name}.spec. Note: sioclient.spec should be sioclient-cpp.spec See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_spec_file_naming ===== MUST items ===== C/C++: [-]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. No licenses found. Please check the source files for licenses manually. [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [!]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10888 bytes in 3 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in sioclient-cpp-devel [ ]: Package functions as described. [ ]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Bad spec filename: /home/fedora/2271219-sioclient/srpm- unpacked/sioclient.spec See: (this test has no URL) [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: sioclient-cpp-3.1.0-1.fc41.aarch64.rpm sioclient-cpp-devel-3.1.0-1.fc41.aarch64.rpm sioclient-cpp-debuginfo-3.1.0-1.fc41.aarch64.rpm sioclient-cpp-debugsource-3.1.0-1.fc41.aarch64.rpm sioclient-cpp-3.1.0-1.fc41.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpfmb1bq2k')] checks: 32, packages: 5 sioclient-cpp.aarch64: E: summary-too-long Library that enables low-latency, bidirectional and event-based communication between a client and a server. sioclient-cpp.src: E: summary-too-long Library that enables low-latency, bidirectional and event-based communication between a client and a server. sioclient-cpp.aarch64: W: summary-ended-with-dot Library that enables low-latency, bidirectional and event-based communication between a client and a server. sioclient-cpp.src: W: summary-ended-with-dot Library that enables low-latency, bidirectional and event-based communication between a client and a server. sioclient-cpp.aarch64: W: spurious-executable-perm /usr/share/doc/sioclient-cpp/README.md sioclient-cpp.aarch64: E: script-without-shebang /usr/share/licenses/sioclient-cpp/LICENSE sioclient-cpp-devel.aarch64: W: no-documentation sioclient-cpp.src: E: invalid-spec-name sioclient-cpp.aarch64: W: devel-file-in-non-devel-package /usr/include/sio_client.h sioclient-cpp.aarch64: W: devel-file-in-non-devel-package /usr/include/sio_message.h sioclient-cpp.aarch64: W: devel-file-in-non-devel-package /usr/include/sio_socket.h sioclient-cpp.aarch64: E: description-line-too-long Library that enables low-latency, bidirectional and event-based communication between a client and a server. sioclient-cpp.src: E: description-line-too-long Library that enables low-latency, bidirectional and event-based communication between a client and a server. 5 packages and 0 specfiles checked; 6 errors, 7 warnings, 45 filtered, 6 badness; has taken 1.0 s Rpmlint (debuginfo) ------------------- Checking: sioclient-cpp-debuginfo-3.1.0-1.fc41.aarch64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp424hsepv')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 11 filtered, 0 badness; has taken 0.5 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 4 sioclient-cpp.aarch64: E: summary-too-long Library that enables low-latency, bidirectional and event-based communication between a client and a server. sioclient-cpp.aarch64: W: summary-ended-with-dot Library that enables low-latency, bidirectional and event-based communication between a client and a server. sioclient-cpp.aarch64: W: spurious-executable-perm /usr/share/doc/sioclient-cpp/README.md sioclient-cpp.aarch64: E: script-without-shebang /usr/share/licenses/sioclient-cpp/LICENSE sioclient-cpp-devel.aarch64: W: no-documentation sioclient-cpp.aarch64: W: devel-file-in-non-devel-package /usr/include/sio_client.h sioclient-cpp.aarch64: W: devel-file-in-non-devel-package /usr/include/sio_message.h sioclient-cpp.aarch64: W: devel-file-in-non-devel-package /usr/include/sio_socket.h sioclient-cpp.aarch64: E: description-line-too-long Library that enables low-latency, bidirectional and event-based communication between a client and a server. 4 packages and 0 specfiles checked; 3 errors, 6 warnings, 42 filtered, 3 badness; has taken 1.0 s Source checksums ---------------- https://github.com/socketio/socket.io-client-cpp/archive/3.1.0/socket.io-client-cpp-3.1.0.tar.gz : CHECKSUM(SHA256) this package : f54dd36b8e5618d028c7c42f0c1a83a0d3a58f9239cf4b770f6b02b925909597 CHECKSUM(SHA256) upstream package : f54dd36b8e5618d028c7c42f0c1a83a0d3a58f9239cf4b770f6b02b925909597 Requires -------- sioclient-cpp (rpmlib, GLIBC filtered): ld-linux-aarch64.so.1()(64bit) libc.so.6()(64bit) libcrypto.so.3()(64bit) libcrypto.so.3(OPENSSL_3.0.0)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libm.so.6()(64bit) libssl.so.3()(64bit) libssl.so.3(OPENSSL_3.0.0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.11)(64bit) libstdc++.so.6(CXXABI_1.3.13)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) rtld(GNU_HASH) sioclient-cpp-devel (rpmlib, GLIBC filtered): libsioclient.so.1()(64bit) libsioclient_tls.so.1()(64bit) sioclient-cpp(aarch-64) sioclient-cpp-debuginfo (rpmlib, GLIBC filtered): sioclient-cpp-debugsource (rpmlib, GLIBC filtered): Provides -------- sioclient-cpp: libsioclient.so.1()(64bit) libsioclient_tls.so.1()(64bit) sioclient-cpp sioclient-cpp(aarch-64) sioclient-cpp-devel: sioclient-cpp-devel sioclient-cpp-devel(aarch-64) sioclient-cpp-debuginfo: debuginfo(build-id) libsioclient.so.1.6.0-3.1.0-1.fc41.aarch64.debug()(64bit) libsioclient_tls.so.1.6.0-3.1.0-1.fc41.aarch64.debug()(64bit) sioclient-cpp-debuginfo sioclient-cpp-debuginfo(aarch-64) sioclient-cpp-debugsource: sioclient-cpp-debugsource sioclient-cpp-debugsource(aarch-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2271219 Buildroot used: fedora-rawhide-aarch64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: PHP, SugarActivity, Haskell, R, Perl, Java, Python, fonts, Ocaml Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) Can tests be run? If not, perhaps build tests and the console example. b) The tar.gz file contains a binary, test/sio_test which should be removed c) %{_includedir}/sio* should be in the devel package d) Spec file should have the name sioclient-cpp
e) License and readme files should not have executable permissions.
Thanks for the quick review. I'll update the spec file as soon as I am able.
SPEC: https://hobbes1069.fedorapeople.org/sioclient.spec SRPM: https://hobbes1069.fedorapeople.org/sioclient-cpp-3.1.0-2.fc39.src.rpm * Sun Apr 21 2024 Richard Shaw <hobbes1069> - 3.1.0-2 - Update per review comments.
This package has rebuilt quite happily on F40, now to see if I can get freedv to build with it installed.
Thanks for the update. Mostly seems ok. Comments: a) Spec file is: https://hobbes1069.fedorapeople.org/sioclient-cpp.spec b) Please remove the binary sio_test by adding: rm test/sio_test in the %prep section c) Please also add chmod -x ./LICENSE in the %prep section d) To enable tests please add BuildRequires: catch2-devel then change %cmake -DUSE_SUBMODULES=OFF -DBUILD_SHARED_LIBS=ON to %cmake -DBUILD_UNIT_TESTS=ON -DUSE_SUBMODULES=OFF -DBUILD_SHARED_LIBS=ON then after the %install section add: %check %ctest The source files also need a modification indicated in the patch below: diff -ruN socket.io-client-cpp-3.1.0/test/CMakeLists.txt socket.io-client-cpp-3.1.0-mod/test/CMakeLists.txt --- socket.io-client-cpp-3.1.0/test/CMakeLists.txt 2021-10-12 08:24:29.000000000 +0000 +++ socket.io-client-cpp-3.1.0-mod/test/CMakeLists.txt 2024-05-18 16:14:07.013475270 +0000 @@ -1,9 +1,16 @@ +find_package(Catch2 CONFIG REQUIRED) + add_executable(sio_test sio_test.cpp) set_property(TARGET sio_test PROPERTY CXX_STANDARD 11) set_property(TARGET sio_test PROPERTY CXX_STANDARD_REQUIRED ON) -target_link_libraries(sio_test sioclient) -target_include_directories(sio_test PRIVATE - "${CMAKE_CURRENT_SOURCE_DIR}/../lib/catch/include" - "${CMAKE_CURRENT_SOURCE_DIR}/../src" +target_link_libraries(sio_test + PRIVATE + sioclient ) +target_include_directories(sio_test + PRIVATE + ${CATCH2_INCLUDE_DIR} + "${CMAKE_CURRENT_SOURCE_DIR}/../src" +) + add_test(sioclient_test sio_test) Binary files socket.io-client-cpp-3.1.0/test/sio_test and socket.io-client-cpp-3.1.0-mod/test/sio_test differ diff -ruN socket.io-client-cpp-3.1.0/test/sio_test.cpp socket.io-client-cpp-3.1.0-mod/test/sio_test.cpp --- socket.io-client-cpp-3.1.0/test/sio_test.cpp 2021-10-12 08:24:29.000000000 +0000 +++ socket.io-client-cpp-3.1.0-mod/test/sio_test.cpp 2024-05-18 16:16:40.048805932 +0000 @@ -11,7 +11,7 @@ #include <thread> #define CATCH_CONFIG_MAIN // This tells Catch to provide a main() - only do this in one cpp file -#include "catch.hpp" +#include <catch2/catch.hpp> #ifndef _WIN32 #include "json.hpp" //nlohmann::json cannot build in MSVC
SPEC: https://hobbes1069.fedorapeople.org/sioclient-cpp.spec SRPM: https://hobbes1069.fedorapeople.org/sioclient-cpp-3.1.0-3.fc40.src.rpm * Sat Sep 07 2024 Richard Shaw <hobbes1069> - 3.1.0-3 - Additional package review changes. Sorry it took so long. I dropped the ball on this with $LIFE and $DAYJOB.
Thanks for getting this far Richard One thing to note is the current freedv code requires a later git version of sioclient-cpp, please see: https://bugzilla.redhat.com/show_bug.cgi?id=2250287 It would be really good to be able to have the most recent freedv in Fedora 41 and 40.
That's less than ideal but let's get the review done and then I can see about packaging the snapshot.
I don't know why the sioclient release version has not been updated, but I found that I could not build the recent freedv releases without it. I see other packages with git snapshots included, so it seems to be some Fedora allows.
@mae.benson are you still able to complete the review?
Yes
ackage Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License". 56 files have unknown license. Detailed output of licensecheck in /home/FedoraPackaging/reviews/sioclient-cpp/2271219-sioclient- cpp/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10888 bytes in 3 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in sioclient-cpp-devel [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: sioclient-cpp-3.1.0-3.fc42.x86_64.rpm sioclient-cpp-devel-3.1.0-3.fc42.x86_64.rpm sioclient-cpp-debuginfo-3.1.0-3.fc42.x86_64.rpm sioclient-cpp-debugsource-3.1.0-3.fc42.x86_64.rpm sioclient-cpp-3.1.0-3.fc42.src.rpm ======================================== rpmlint session starts ======================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpxkjvmk8q')] checks: 32, packages: 5 sioclient-cpp.src: E: summary-too-long Library that enables low-latency, bidirectional and event-based communication between a client and a server. sioclient-cpp.x86_64: E: summary-too-long Library that enables low-latency, bidirectional and event-based communication between a client and a server. sioclient-cpp.src: W: summary-ended-with-dot Library that enables low-latency, bidirectional and event-based communication between a client and a server. sioclient-cpp.x86_64: W: summary-ended-with-dot Library that enables low-latency, bidirectional and event-based communication between a client and a server. sioclient-cpp-devel.x86_64: W: no-documentation sioclient-cpp.src: E: description-line-too-long Library that enables low-latency, bidirectional and event-based communication between a client and a server. sioclient-cpp.x86_64: E: description-line-too-long Library that enables low-latency, bidirectional and event-based communication between a client and a server. == 5 packages and 0 specfiles checked; 4 errors, 3 warnings, 43 filtered, 4 badness; has taken 5.4 s === Rpmlint (debuginfo) ------------------- Checking: sioclient-cpp-debuginfo-3.1.0-3.fc42.x86_64.rpm ======================================== rpmlint session starts ======================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpa_dp3qi0')] checks: 32, packages: 1 == 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 12 filtered, 0 badness; has taken 1.4 s === Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 4 sioclient-cpp.x86_64: E: summary-too-long Library that enables low-latency, bidirectional and event-based communication between a client and a server. sioclient-cpp.x86_64: W: summary-ended-with-dot Library that enables low-latency, bidirectional and event-based communication between a client and a server. sioclient-cpp-devel.x86_64: W: no-documentation sioclient-cpp.x86_64: E: description-line-too-long Library that enables low-latency, bidirectional and event-based communication between a client and a server. 4 packages and 0 specfiles checked; 2 errors, 2 warnings, 41 filtered, 2 badness; has taken 3.7 s Source checksums ---------------- https://github.com/socketio/socket.io-client-cpp/archive/3.1.0/socket.io-client-cpp-3.1.0.tar.gz : CHECKSUM(SHA256) this package : f54dd36b8e5618d028c7c42f0c1a83a0d3a58f9239cf4b770f6b02b925909597 CHECKSUM(SHA256) upstream package : f54dd36b8e5618d028c7c42f0c1a83a0d3a58f9239cf4b770f6b02b925909597 Requires -------- sioclient-cpp (rpmlib, GLIBC filtered): libc.so.6()(64bit) libcrypto.so.3()(64bit) libcrypto.so.3(OPENSSL_3.0.0)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libm.so.6()(64bit) libssl.so.3()(64bit) libssl.so.3(OPENSSL_3.0.0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.11)(64bit) libstdc++.so.6(CXXABI_1.3.13)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) rtld(GNU_HASH) sioclient-cpp-devel (rpmlib, GLIBC filtered): libsioclient.so.1()(64bit) libsioclient_tls.so.1()(64bit) sioclient-cpp(x86-64) sioclient-cpp-debuginfo (rpmlib, GLIBC filtered): sioclient-cpp-debugsource (rpmlib, GLIBC filtered): Provides -------- sioclient-cpp: libsioclient.so.1()(64bit) libsioclient_tls.so.1()(64bit) sioclient-cpp sioclient-cpp(x86-64) sioclient-cpp-devel: sioclient-cpp-devel sioclient-cpp-devel(x86-64) sioclient-cpp-debuginfo: debuginfo(build-id) libsioclient.so.1.6.0-3.1.0-3.fc42.x86_64.debug()(64bit) libsioclient_tls.so.1.6.0-3.1.0-3.fc42.x86_64.debug()(64bit) sioclient-cpp-debuginfo sioclient-cpp-debuginfo(x86-64) sioclient-cpp-debugsource: sioclient-cpp-debugsource sioclient-cpp-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2271219 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: Python, R, Java, Perl, PHP, SugarActivity, Haskell, fonts, Ocaml Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) Please see https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_complex_versioning https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_hosting_services for how to package commits. The binary has been removed, so it is preferable to package a snapshot rather than the latest release. b) Consider getting the patch upstreamed in some form to make maintenance easier c) Can the description warnings and errors be fixed: sioclient-cpp.x86_64: E: summary-too-long Library that enables low-latency, bidirectional and event-based communication between a client and a server. sioclient-cpp.x86_64: W: summary-ended-with-dot Library that enables low-latency, bidirectional and event-based communication between a client and a server. sioclient-cpp.x86_64: E: description-line-too-long Library that enables low-latency, bidirectional and event-based communication between a client and a server. The current summary seems like a better fit for the description. The repository page has: C++11 implementation of Socket.IO client which maybe a reasonable summary.
To be clear I really don't like this package and don't want to maintain it. I'm working with FreeDV upstream to see if they actually need a git checkout or whether the latest official release is sufficient.
Bah... Trying to build from a git checkout is a pain due to use of git submodules.
Does it not just snapshot the sub-directory as part of the master branch snapshot?
It is also possible to create a script that removes the binary from the release? Could upstream make a new release e.g. 3.1.1? The binary seems to have reasonable licensing, so you can remove it in prep section https://docs.fedoraproject.org/en-US/packaging-guidelines/what-can-be-packaged/#prebuilt-binaries-or-libraries had thought https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#when-upstream-uses-prohibited-code applied.
No, when you have github create the archive using the standard method, the submodules are not included. I would have to do the git checkout myself and add --recurse-submodules or something like that and then gzip the archive myself. It's possible, but it's a PITA and definitely not preferred. And then the submodules (if included in the final library and not just used for testing) would be considered bundled libraries.