Spec URL: https://pagure.io/mochaa-rpms/joycond/raw/rawhide/f/joycond.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mochaa/joycond/fedora-rawhide-x86_64/07055443-joycond/joycond-0.1.0-1.20240224git9d1f509.fc41.src.rpm Description: joycond is a linux daemon which uses the evdev devices provided by hid-nintendo (formerly known as hid-joycon) to implement joycon pairing. Fedora Account System Username: mochaa
Copr build: https://copr.fedorainfracloud.org/coprs/build/7057694 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2265774-joycond/fedora-rawhide-x86_64/07057694-joycond/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://github.com/rpm-software-management/rpmlint/issues/1074 Perhaps change %forgeautosetup to %autosetup -n %{name}-%{commit} -p1 Some other warnings: joycond.aarch64: W: summary-not-capitalized userspace daemon to combine joy-cons from the hid-nintendo kernel driver joycond.aarch64: E: spelling-error ('nintendo', 'Summary(en_US) nintendo -> Nintendo, intended, indolent') joycond.aarch64: E: spelling-error ('nintendo', '%description -l en_US nintendo -> Nintendo, intended, indolent') joycond.spec:8: W: mixed-use-of-spaces-and-tabs (spaces: line 8, tab: line 6) Issues: ======= - systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in joycond https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_scriptlets
Spec URL: https://pagure.io/mochaa-rpms/joycond/raw/rawhide/f/joycond.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mochaa/joycond/srpm-builds/07067595/joycond-0.1.0-1.src.rpm E: spelling-error should be ignored, since "hid-nintendo" is the name of the kernel module.