Bug 2262961 - Review Request: php-bjeavons-zxcvbn-php - Realistic password strength estimation PHP library based on Zxcvbn JS
Summary: Review Request: php-bjeavons-zxcvbn-php - Realistic password strength estimat...
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL: https://github.com/bjeavons/zxcvbn-php
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-02-06 09:44 UTC by Xavier Bachelot
Modified: 2024-02-13 13:22 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Xavier Bachelot 2024-02-06 09:44:50 UTC
Spec URL: https://www.bachelot.org/fedora/SPECS/php-bjeavons-zxcvbn-php.spec
SRPM URL: https://www.bachelot.org/fedora/SRPMS/php-bjeavons-zxcvbn-php-1.3.1-1.fc40.src.rpm

Description:
Zxcvbn-PHP is a password strength estimator using pattern matching and minimum
entropy calculation. Zxcvbn-PHP is based on the the Javascript zxcvbn project
from Dropbox and @lowe. "zxcvbn" is bad password, just like "qwerty" and
"123456".

Fedora Account System Username: xavierb

Comment 1 Fedora Review Service 2024-02-06 09:50:37 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6988819
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2262961-php-bjeavons-zxcvbn-php/fedora-rawhide-x86_64/06988819-php-bjeavons-zxcvbn-php/fedora-review/review.txt

Found issues:

- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/php-bjeavons-zxcvbn-php
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Remi Collet 2024-02-13 13:22:38 UTC
Indeed this package was in Fedora repository until F35

Was removed in F36 as FTBFS (and no more used, as roundcubemail now uses bundled libraries)

For my curiosity, which project still uses it (as it seems dead, with no activity for ~3y)

Perhaps better to take old spec as a base, especially as it was using PSR-0 tree, and manage update from php-mkopinsky-zxcvbn-php


Issues:
- require both php-mbstring and php-symfony-polyfill-mbstring
- missing BuildRequires of used extensions

But polyfill autoloader is not included, so mbstring (ext) is enough

Notice: php-symfony-polyfill-mbstring add functions from mbstring, but also some new fonctions (ex: mb_str_split in 7.4)

So it is fine to remove dependency on polyfill (especially as most of doctrine / symfony packages are FTBFS and going to be removed, lack of maintainer)


Note You need to log in before you can comment on or make changes to this bug.