Spec URL: https://cmadams.fedorapeople.org/perl-Net-Async-HTTP-Server/perl-Net-Async-HTTP-Server.spec SRPM URL: https://cmadams.fedorapeople.org/perl-Net-Async-HTTP-Server/perl-Net-Async-HTTP-Server-0.14-1.fc39.src.rpm Description: This module allows a program to respond asynchronously to HTTP requests, as part of a program based on IO::Async. An object in this class listens on a single port and invokes the on_request callback or subclass method whenever an HTTP request is received, allowing the program to respond to it. Fedora Account System Username: cmadams
Note: depends on perl-IO-Async-SSL (review BZ 2254917) perl-Net-Async-HTTP (review BZ 2254931)
Bumped release for spec file cleanups: Spec URL: https://cmadams.fedorapeople.org/perl-Net-Async-HTTP-Server/perl-Net-Async-HTTP-Server.spec SRPM URL: https://cmadams.fedorapeople.org/perl-Net-Async-HTTP-Server/perl-Net-Async-HTTP-Server-0.14-2.fc39.src.rpm
Bumped release for additional spec file cleanups: Spec URL: https://cmadams.fedorapeople.org/perl-Net-Async-HTTP-Server/perl-Net-Async-HTTP-Server.spec SRPM URL: https://cmadams.fedorapeople.org/perl-Net-Async-HTTP-Server/perl-Net-Async-HTTP-Server-0.14-3.fc39.src.rpm
Bumped release for additional spec file cleanups: Spec URL: https://cmadams.fedorapeople.org/perl-Net-Async-HTTP-Server/perl-Net-Async-HTTP-Server.spec SRPM URL: https://cmadams.fedorapeople.org/perl-Net-Async-HTTP-Server/perl-Net-Async-HTTP-Server-0.14-4.fc39.src.rpm
Swap you for a review of perl-TOML-Tiny? https://bugzilla.redhat.com/show_bug.cgi?id=2276412
(In reply to Peter Oliver from comment #5) > Swap you for a review of perl-TOML-Tiny? > https://bugzilla.redhat.com/show_bug.cgi?id=2276412 I have not actually done a review before, but I've been meaning to give it a try. I'm about to be out for a week or so, but I will check it out next week. Thanks.
- The package should own the following directories: - /usr/share/perl5/vendor_perl/Net - /usr/share/perl5/vendor_perl/Net/Async - /usr/share/perl5/vendor_perl/Plack - /usr/share/perl5/vendor_perl/Plack/Handler - /usr/share/perl5/vendor_perl/Plack/Handler/Net Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 1 and/or The Perl 5 License", "GNU General Public License". 29 files have unknown license. Detailed output of licensecheck in /home/mavit/src/fedora/reviews/2254932-perl-Net-Async-HTTP- Server/licensecheck.txt [-]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/perl5/vendor_perl/Plack/Handler/Net [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/perl5/vendor_perl/Net/Async, /usr/share/perl5/vendor_perl/Plack, /usr/share/perl5/vendor_perl/Plack/Handler/Net, /usr/share/perl5/vendor_perl/Plack/Handler, /usr/share/perl5/vendor_perl/Net [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/perl5/vendor_perl/Net/Async/HTTP(perl-Net-Async-HTTP) [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 8524 bytes in 3 files. [x]: Packages must not store files under /srv, /opt or /usr/local Perl: [x]: Package contains the mandatory BuildRequires and Requires:. [x]: CPAN urls should be non-versioned. ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: perl-Net-Async-HTTP-Server-0.14-4.fc42.noarch.rpm perl-Net-Async-HTTP-Server-0.14-4.fc42.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpb8zh8vdi')] checks: 32, packages: 2 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 7 filtered, 0 badness; has taken 0.5 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 3 filtered, 0 badness; has taken 0.1 s Requires -------- perl-Net-Async-HTTP-Server (rpmlib, GLIBC filtered): perl(:VERSION) perl(Carp) perl(HTTP::Request) perl(HTTP::Response) perl(IO::Async::Listener) perl(IO::Async::Loop) perl(IO::Async::Stream) perl(Metrics::Any) perl(Net::Async::HTTP::Server) perl(Net::Async::HTTP::Server::PSGI) perl(Net::Async::HTTP::Server::Protocol) perl(Net::Async::HTTP::Server::Request) perl(Scalar::Util) perl(URI) perl(URI::QueryParam) perl(base) perl(warnings) perl-libs Provides -------- perl-Net-Async-HTTP-Server: perl(Net::Async::HTTP::Server) perl(Net::Async::HTTP::Server::PSGI) perl(Net::Async::HTTP::Server::Protocol) perl(Net::Async::HTTP::Server::Request) perl(Plack::Handler::Net::Async::HTTP::Server) perl-Net-Async-HTTP-Server Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2254932 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Perl, Shell-api Disabled plugins: C/C++, Ocaml, Java, R, Python, Haskell, fonts, PHP, SugarActivity Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH