Spec URL: https://dcavalca.fedorapeople.org/review/python-beancount/python-beancount.spec SRPM URL: https://dcavalca.fedorapeople.org/review/python-beancount/python-beancount-2.3.6-1.fc40.src.rpm Description: Beancount is double-entry bookkeeping computer language that lets you define financial transaction records in a text file, read them in memory, generate a variety of reports from them, and provides a web interface. Fedora Account System Username: dcavalca
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=109524070
Copr build: https://copr.fedorainfracloud.org/coprs/build/6693240 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2251448-python-beancount/fedora-rawhide-x86_64/06693240-python-beancount/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
There's something fishy with the dependencies here -- this package installs fine in mock, but on a live system I get Problem: problem with installed package python3-file-magic-5.44-5.fc39.noarch - package python3-file-magic-5.44-5.fc39.noarch from @System conflicts with python3-magic < 5.44-5.fc39 provided by python3-magic-0.4.27-5.fc39.noarch from fedora - installed package python3-file-magic-5.44-5.fc39.noarch obsoletes python3-magic < 5.44-5.fc39 provided by python3-magic-0.4.27-5.fc39.noarch from fedora - package python3-file-magic-5.44-5.fc39.noarch from fedora conflicts with python3-magic < 5.44-5.fc39 provided by python3-magic-0.4.27-5.fc39.noarch from fedora - package python3-file-magic-5.44-5.fc39.noarch from fedora obsoletes python3-magic < 5.44-5.fc39 provided by python3-magic-0.4.27-5.fc39.noarch from fedora - package beancount-2.3.6-1.fc39.x86_64 from @commandline requires python3.12dist(python-magic) >= 0.4.12, but none of the providers can be installed - conflicting requests I assume this is because python3-file-magic is obsoleting python3-magic but doesn't actually provide python3.12dist(python-magic).
Spec URL: https://dcavalca.fedorapeople.org/review/python-beancount/python-beancount.spec SRPM URL: https://dcavalca.fedorapeople.org/review/python-beancount/python-beancount-2.3.6-1.fc40.src.rpm Changelog: - replace python-magic with python-file-magic to avoid install conflict
Created attachment 2001539 [details] The .spec file difference from Copr build 6693240 to 6695807
Copr build: https://copr.fedorainfracloud.org/coprs/build/6695807 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2251448-python-beancount/fedora-rawhide-x86_64/06695807-python-beancount/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
I also created a spec file without knowing that this bug existed. https://copr.fedorainfracloud.org/coprs/kanru/beancount/ Overall your package looks great. Just two small questions related to naming. > %global srcname beancount > %global forgeurl https://github.com/beancount/beancount > > Name: python-%{srcname} Would it make sense to name the srpm `beancount` instead? Python packaging guideline https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_application_naming > Packages that primarily provide applications, services or any kind of executables > SHOULD be named according to the general Fedora naming guidelines (e.g. ansible). Since upstream already release the package as `beancount` I feel this should be preferred. This also make the auto-generated debugsource and debuginfo package named correctly.