Spec URL: https://download.copr.fedorainfracloud.org/results/mmassari/apscheduler/fedora-rawhide-x86_64/06499610-python-APScheduler/python-APScheduler.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mmassari/apscheduler/fedora-rawhide-x86_64/06499610-python-APScheduler/python-APScheduler-3.9.1-1.fc40.src.rpm Description: Task scheduling library for Python Fedora Account System Username: mmassari
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/python-APScheduler See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License". 113 files have unknown license. Detailed output of licensecheck in /home/fedora/2242477-python- APScheduler/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Test run failed [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-APScheduler-3.9.1-1.fc40.noarch.rpm python-APScheduler-3.9.1-1.fc40.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpnwpurrj3')] checks: 31, packages: 2 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.2 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.1 s Source checksums ---------------- https://files.pythonhosted.org/packages/source/A/APScheduler/APScheduler-3.9.1.tar.gz : CHECKSUM(SHA256) this package : 65e6574b6395498d371d045f2a8a7e4f7d50c6ad21ef7313d15b1c7cf20df1e3 CHECKSUM(SHA256) upstream package : 65e6574b6395498d371d045f2a8a7e4f7d50c6ad21ef7313d15b1c7cf20df1e3 Requires -------- python3-APScheduler (rpmlib, GLIBC filtered): ((python3.12dist(tzlocal) < 3~~ or python3.12dist(tzlocal) >= 4) with python3.12dist(tzlocal) >= 2) python(abi) python3.12dist(pytz) python3.12dist(setuptools) python3.12dist(six) Provides -------- python3-APScheduler: python-APScheduler python3-APScheduler python3.12-APScheduler python3.12dist(apscheduler) python3dist(apscheduler) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2242477 Buildroot used: fedora-rawhide-aarch64 Active plugins: Python, Generic, Shell-api Disabled plugins: fonts, SugarActivity, Perl, C/C++, R, Java, PHP, Haskell, Ocaml Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) Assume this is to unretire the package. b) Is it possible to update to 3.10.4 c) Can the changelog be updated? d) License file metadata is correct: $ rpm -qL python3-APScheduler-3.9.1-1.fc40.noarch.rpm /usr/lib/python3.12/site-packages/APScheduler-3.9.1.dist-info/LICENSE.txt /usr/share/licenses/python3-APScheduler/LICENSE.txt so can remove: %license LICENSE.txt e) Can coverage tests be removed/ignored? f)
The source package has a APScheduler.egg-info directory. This should probably be removed in the prep section.
Thank you for your review: You can find my changes here: Spec URL: https://download.copr.fedorainfracloud.org/results/mmassari/apscheduler/fedora-rawhide-x86_64/06508081-python-APScheduler/python-APScheduler.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mmassari/apscheduler/fedora-rawhide-x86_64/06508081-python-APScheduler/python-APScheduler-3.10.4-1.fc40.src.rpm a) Yes, I would like to adopt this package b) Updated c) I have inserted the %autochangelog macro d) License macro removed e) Coverage option removed f) egg-info directory removed Maja
Not sure if %autochangelog macro will work, check this, may also need %autorelease. May also need a separate changelog file for the old entries: https://docs.pagure.org/fedora-infra.rpmautospec/autochangelog.html https://docs.fedoraproject.org/en-US/packaging-guidelines/#changelogs https://docs.fedoraproject.org/en-US/packaging-guidelines/manual-changelog/ However, using a manual changelog is fine, just need to add an entry indicating unretiring the package. Is python3-pytest-cov still needed?
This is the latest version: Spec Url: https://download.copr.fedorainfracloud.org/results/mmassari/apscheduler/fedora-rawhide-x86_64/06513655-python-APScheduler/python-APScheduler.spec SRPM Url: https://download.copr.fedorainfracloud.org/results/mmassari/apscheduler/fedora-rawhide-x86_64/06513655-python-APScheduler/python-APScheduler-3.10.4-1.fc40.src.rpm As you suggested, I created a changelog file locally with the command: rpmautospec generate-changelog python-APScheduler.spec The command rpmautospec generate-changelog python-APScheduler.spec seems to be working fine, at least locally. I prefer not to use the %autorelease macro, at least at the moment. I have removed python3-pytest-cov. I have also removed unedeed BuildRequires, since I am using %pyproject_buildrequires, and for this reason I had to fix the pytest-tornado reference in setup.py. Thank you, Maja
I created a changelog file locally with the command: rpmautospec convert python-APScheduler.spec...
(In reply to mmassari from comment #5) > As you suggested, I created a changelog file locally with the command: > rpmautospec generate-changelog python-APScheduler.spec I think you are supposed to move existing changelog entries from the spec file to a changelog file, what "rpmautospec generate-changelog" does is a preview of changelog generated from commit messages. > I prefer not to use the %autorelease macro, at least at the moment. Why not? A few notes to the spec file: > Source0: %{pypi_source} You should use "%{pypi_source %{srcname}}", omitting name is deprecated. > %{?python_provide:%python_provide python3-%{srcname}} I don't think this is necessary. > sed -i "s/ 'pytest-tornado5'/ 'pytest-tornado'/g" setup.py You can omit the whitespace, and you don't need "g". > sed -i "s/ 'pytest-cov',//g" setup.py You could use simpler "sed -i '/pytest-cov/d' setup.py".
Hi Nikola, thanks for your review. > I think you are supposed to move existing changelog entries from the spec file to a changelog file, what "rpmautospec generate-changelog" does is a preview of changelog generated from commit messages. I wrote it in the wrong way, and I wasn't able to edit the message. I have used 'rpmautospec convert' to create a changelog file; the commit is not visible in the srpm but I have it in a new commit locally. > Why not? I want to use packit with it and, if I am not mistaken, there are some open issues for packit and the autorelease macro. This is the latest build: spec file: https://download.copr.fedorainfracloud.org/results/mmassari/apscheduler/fedora-rawhide-x86_64/06519065-python-APScheduler/python-APScheduler.spec srpm: https://download.copr.fedorainfracloud.org/results/mmassari/apscheduler/fedora-rawhide-x86_64/06519065-python-APScheduler/python-APScheduler-3.10.4-1.fc40.src.rpm - I have used %{pypi_source %{srcname}} - I have removed: %{?python_provide:%python_provide python3-%{srcname}} - And improved sed usage as you suggested Maja
(In reply to mmassari from comment #8) > I want to use packit with it and, if I am not mistaken, there are some open > issues for packit and the autorelease macro. I'm not aware of any, I believe %autorelease is fully supported. And if not, it's the perfect opportunity to test and improve it :)
Ok, I will try it ^_^ The specfile with %autorelease: https://download.copr.fedorainfracloud.org/results/mmassari/apscheduler/fedora-rawhide-x86_64/06519278-python-APScheduler/python-APScheduler.spec and rpmautospec calculate-release python-APScheduler.spec gives me 1, so it should be correct.
If time allows, review of https://bugzilla.redhat.com/show_bug.cgi?id=2243337 would be appreciated. Please post updated srpm when ready.
spec: https://download.copr.fedorainfracloud.org/results/mmassari/apscheduler/fedora-rawhide-x86_64/06519278-python-APScheduler/python-APScheduler.spec srpm: https://download.copr.fedorainfracloud.org/results/mmassari/apscheduler/fedora-rawhide-x86_64/06519278-python-APScheduler/python-APScheduler-3.10.4-1.fc40.src.rpm
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/python-APScheduler See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License". 107 files have unknown license. Detailed output of licensecheck in /home/fedora/2242477-python- APScheduler/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 3831 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [-]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-APScheduler-3.10.4-1.fc40.noarch.rpm python-APScheduler-3.10.4-1.fc40.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpebbrup49')] checks: 31, packages: 2 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.8 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.1 s Source checksums ---------------- https://files.pythonhosted.org/packages/source/A/APScheduler/APScheduler-3.10.4.tar.gz : CHECKSUM(SHA256) this package : e6df071b27d9be898e486bc7940a7be50b4af2e9da7c08f0744a96d4bd4cef4a CHECKSUM(SHA256) upstream package : e6df071b27d9be898e486bc7940a7be50b4af2e9da7c08f0744a96d4bd4cef4a Requires -------- python3-APScheduler (rpmlib, GLIBC filtered): ((python3.12dist(tzlocal) < 3~~ or python3.12dist(tzlocal) >= 4) with python3.12dist(tzlocal) >= 2) python(abi) python3.12dist(pytz) python3.12dist(six) Provides -------- python3-APScheduler: python-APScheduler python3-APScheduler python3.12-APScheduler python3.12dist(apscheduler) python3dist(apscheduler) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2242477 Buildroot used: fedora-rawhide-aarch64 Active plugins: Shell-api, Python, Generic Disabled plugins: Ocaml, Haskell, Perl, PHP, C/C++, fonts, R, Java, SugarActivity Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) Approved b) Warnings in build log, may wish to notify upstream and/or add dependencies: /usr/lib/python3.12/site-packages/setuptools/dist.py:498: SetuptoolsDeprecationWarning: I nvalid dash-separated options !! ******************************************************************************** Usage of dash-separated 'upload-dir' will not be supported in future versions. Please use the underscore name 'upload_dir' instead. This deprecation is overdue, please update your project and remove deprecated calls to avoid build errors in the future. See https://setuptools.pypa.io/en/latest/userguide/declarative_config.html for de tails. ******************************************************************************** =========================== short test summary info ============================ SKIPPED [1] tests/test_schedulers.py:892: could not import 'apscheduler.schedulers.gevent ': GeventScheduler requires gevent installed SKIPPED [1] tests/test_schedulers.py:906: could not import 'apscheduler.schedulers.gevent ': GeventScheduler requires gevent installed SKIPPED [1] tests/test_schedulers.py:921: could not import 'apscheduler.schedulers.gevent ': GeventScheduler requires gevent installed SKIPPED [1] tests/test_schedulers.py:892: could not import 'twisted.internet.selectreacto r': No module named 'twisted' SKIPPED [1] tests/test_schedulers.py:906: could not import 'twisted.internet.selectreacto r': No module named 'twisted' SKIPPED [1] tests/test_schedulers.py:921: could not import 'twisted.internet.selectreacto r': No module named 'twisted' SKIPPED [1] tests/test_schedulers.py:892: could not import 'PySide6.QtCore': No module na med 'PySide6' SKIPPED [1] tests/test_schedulers.py:906: could not import 'PySide6.QtCore': No module na med 'PySide6' SKIPPED [1] tests/test_schedulers.py:921: could not import 'PySide6.QtCore': No module na med 'PySide6' ================== 357 passed, 9 skipped, 9 warnings in 3.12s ==================
Thank you!