Spec URL: https://github.com/stewartsmith/pkg-aws-lambda-cpp/blob/rawhide/aws-lambda-cpp.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/3478/106323478/aws-lambda-cpp-0.2.8-1.fc40.src.rpm / COPR build: https://copr.fedorainfracloud.org/coprs/trawets/aws-lambda-cpp/build/6412619/ Description: C++ implementation of the Lambda runtime API, allowing Lambda functions to be easily implemented in C++. This package includes a shared library providing functionality to interact with the Lambda runtime. This allows you to provide Lambda functions from your C++ application with negligible cold-start overhead. This library will build on more CPU architectures than AWS Lambda supports. An application to be run on Lambda will need to be built for an architecture that AWS Lambda supports. Fedora Account System Username: trawets
I had intended to get the demo built and able to be run, but ran into some rpath fun that I didn't quite figure out. If someone has a hint on that, it would be appreciated!
Please link to raw spec file. Makes it easier to run fedora-review spec: https://raw.githubusercontent.com/stewartsmith/pkg-aws-lambda-cpp/rawhide/aws-lambda-cpp.spec srpm: https://kojipkgs.fedoraproject.org//work/tasks/3478/106323478/aws-lambda-cpp-0.2.8-1.fc40.src.rpm
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Cannot run licensecheck: Command 'licensecheck -r /var/lib/mock/fedora-rawhide-aarch64/root/builddir/build/BUILD/aws- lambda-cpp-0.2.8' returned non-zero exit status 2. [ ]: License file installed when any subpackage combination is installed. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/include/aws/http, /usr/include/aws/lambda-runtime, /usr/include/aws/logging [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/include/aws/lambda- runtime, /usr/include/aws/http, /usr/include/aws, /usr/include/aws/logging [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Test run failed [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in aws- lambda-cpp-devel , aws-lambda-cpp-demo [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [!]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define _vpath_srcdir examples/demo, %define _vpath_builddir %{_vendor}-%{_target_os}-demo- build [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: aws-lambda-cpp-0.2.8-1.fc40.aarch64.rpm aws-lambda-cpp-devel-0.2.8-1.fc40.aarch64.rpm aws-lambda-cpp-demo-0.2.8-1.fc40.aarch64.rpm aws-lambda-cpp-debuginfo-0.2.8-1.fc40.aarch64.rpm aws-lambda-cpp-debugsource-0.2.8-1.fc40.aarch64.rpm aws-lambda-cpp-0.2.8-1.fc40.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpbkgsijoj')] checks: 31, packages: 6 aws-lambda-cpp.aarch64: W: no-documentation aws-lambda-cpp-demo.aarch64: E: no-binary aws-lambda-cpp.spec:11: W: mixed-use-of-spaces-and-tabs (spaces: line 11, tab: line 10) 6 packages and 0 specfiles checked; 1 errors, 2 warnings, 1 badness; has taken 0.5 s Rpmlint (debuginfo) ------------------- Checking: aws-lambda-cpp-debuginfo-0.2.8-1.fc40.aarch64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmplzq23tsj')] checks: 31, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.2 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 5 aws-lambda-cpp.aarch64: W: no-documentation aws-lambda-cpp-demo.aarch64: E: no-binary 5 packages and 0 specfiles checked; 1 errors, 1 warnings, 1 badness; has taken 0.4 s Source checksums ---------------- https://github.com/awslabs/aws-lambda-cpp/archive/v0.2.8/aws-lambda-cpp-0.2.8.tar.gz : CHECKSUM(SHA256) this package : a236516331804a0a6e2ef2273042a583e55a135bb6478308829c51e7c425acdb CHECKSUM(SHA256) upstream package : a236516331804a0a6e2ef2273042a583e55a135bb6478308829c51e7c425acdb Requires -------- aws-lambda-cpp (rpmlib, GLIBC filtered): ld-linux-aarch64.so.1()(64bit) libc.so.6()(64bit) libcurl.so.4()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.3)(64bit) libgcc_s.so.1(GCC_4.2.0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) rtld(GNU_HASH) aws-lambda-cpp-devel (rpmlib, GLIBC filtered): /usr/bin/bash aws-lambda-cpp libaws-lambda-runtime.so.0()(64bit) aws-lambda-cpp-demo (rpmlib, GLIBC filtered): aws-lambda-cpp-debuginfo (rpmlib, GLIBC filtered): aws-lambda-cpp-debugsource (rpmlib, GLIBC filtered): Provides -------- aws-lambda-cpp: aws-lambda-cpp aws-lambda-cpp(aarch-64) libaws-lambda-runtime.so.0()(64bit) aws-lambda-cpp-devel: aws-lambda-cpp-devel aws-lambda-cpp-devel(aarch-64) aws-lambda-cpp-demo: aws-lambda-cpp-demo aws-lambda-cpp-demo(aarch-64) aws-lambda-cpp-debuginfo: aws-lambda-cpp-debuginfo aws-lambda-cpp-debuginfo(aarch-64) debuginfo(build-id) libaws-lambda-runtime.so.0.2.8-0.2.8-1.fc40.aarch64.debug()(64bit) aws-lambda-cpp-debugsource: aws-lambda-cpp-debugsource aws-lambda-cpp-debugsource(aarch-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2239352 Buildroot used: fedora-rawhide-aarch64 Active plugins: Generic, C/C++, Shell-api Disabled plugins: Ocaml, SugarActivity, R, Java, Python, fonts, Perl, PHP, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) You can create a spec file template using rpmdev-newspec Please try to follow the format, in particular listing of files is at the end of the spec file. b) It is possible to pass options to %cmake see for example: https://orion.fedorapeople.org/dbcsr.spec thus one can build the main package, then build a demo binary c) Please add %dir directives in the file listings to own directories for example %dir %{_includedir}/aws/ %dir %{_includedir}/aws/http/ %dir %{_includedir}/aws/logging/ %dir %{_includedir}/aws/lambda-runtime/ %dir %{_libdir}/aws-lambda-runtime/ d) should zip be a dependency? e) A file with executable permissions usr/lib64/aws-lambda-runtime/cmake/packager is in the devel package. Is this needed? If so, should it be placed somewhere else? f) Would prefer to see %{_includedir}/aws/lambda-runtime/*.h instead of %{_includedir}/aws/lambda-runtime/* as this indicates types of files. g) Would also prefer if %dir %{_libdir}/aws-lambda-runtime/ %dir %{_libdir}/aws-lambda-runtime/cmake %{_libdir}/aws-lambda-runtime/cmake/*.cmake is used instead of %{_libdir}/aws-lambda-runtime/ as the file contents of the directory are specified.
Review of https://bugzilla.redhat.com/show_bug.cgi?id=2240758 would be appreciated. It is a dependency of aws-sdk-cpp which if packaged would enable running tests.