Spec URL: https://dcavalca.fedorapeople.org/review/get_iplayer/get_iplayer.spec SRPM URL: https://dcavalca.fedorapeople.org/review/get_iplayer/get_iplayer-3.31-3.fc40.src.rpm Description: get_iplayer is a tool for listing, recording and streaming BBC iPlayer television and radio programmes, and other programmes via 3rd-party plugins. Fedora Account System Username: dcavalca
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=105541483
This is based on the rpmfusion package: https://admin.rpmfusion.org/pkgdb/package/free/get_iplayer/
Spec URL: https://dcavalca.fedorapeople.org/review/get_iplayer/get_iplayer.spec SRPM URL: https://dcavalca.fedorapeople.org/review/get_iplayer/get_iplayer-3.31-4.fc40.src.rpm Changelog: - Merge latest changes from rpmfusion
Copr build: https://copr.fedorainfracloud.org/coprs/build/6356988 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2236248-get_iplayer/fedora-rawhide-x86_64/06356988-get_iplayer/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Created attachment 1986198 [details] The .spec file difference from Copr build 6356988 to 6357000
Copr build: https://copr.fedorainfracloud.org/coprs/build/6357000 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2236248-get_iplayer/fedora-rawhide-x86_64/06357000-get_iplayer/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Please split all the BuildRequires into one per line and sort alphabetically. BuildRequires: file-libs >= 5.14-14 That is an unusual requirement for a noarch package. What is actually required here? %build ./get_iplayer --manpage=get_iplayer.1 || : What is getting "built" here? The manpage? Requires: perl(Encode::Locale) Requires: perl(XML::LibXML) >= 1.91 Requires: perl(LWP::Protocol::https) Requires: perl(Mojolicious) >= 4.63 Requires: perl(JSON::PP) Are these perl requirements not detected automatically?
> Please split all the BuildRequires into one per line and sort alphabetically. Will do > That is an unusual requirement for a noarch package. What is actually required here? This was for https://bugzilla.redhat.com/show_bug.cgi?id=1051607 according to the git blame. Given that we're long past that I'll just drop it. > What is getting "built" here? The manpage? Yup, I'll add a comment > Are these perl requirements not detected automatically? perl(Encode::Locale) and perl(Mojolicious) >= 4.63 are missing, the rest is there so I'll drop them.
Spec URL: https://dcavalca.fedorapeople.org/review/get_iplayer/get_iplayer.spec SRPM URL: https://dcavalca.fedorapeople.org/review/get_iplayer/get_iplayer-3.34-2.fc40.src.rpm Changelog: - Merge latest changes from rpmfusion - Tidy up requires and BuildRequires
Created attachment 2005573 [details] The .spec file difference from Copr build 6357000 to 6784937
Copr build: https://copr.fedorainfracloud.org/coprs/build/6784937 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2236248-get_iplayer/fedora-rawhide-x86_64/06784937-get_iplayer/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Taking review.
APPROVED. Notes on SHOULD items: 1. It did download a list of programmes from the BBC, but I couldn't download anything, probably due to geoIP restrictions. 2. Version 3.35 is out. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/mime/packages, /usr/share/mime [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 13417 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Package functions as described. [!]: Latest version is packaged. (3.35 is available) [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: get_iplayer-3.34-2.fc40.noarch.rpm get_iplayer-3.34-2.fc40.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmppjvz0noj')] checks: 31, packages: 2 get_iplayer.noarch: E: zero-length /etc/get_iplayer/options 2 packages and 0 specfiles checked; 1 errors, 0 warnings, 1 badness; has taken 0.1 s Rpmlint (installed packages) ---------------------------- ================================================ rpmlint session starts ================================================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 get_iplayer.noarch: E: zero-length /etc/get_iplayer/options get_iplayer.noarch: E: spelling-error ('programmes', 'Summary(en_US) programmes -> programmed, programmers, programmer') get_iplayer.noarch: E: spelling-error ('programmes', '%description -l en_US programmes -> programmed, programmers, programmer') =========== 1 packages and 0 specfiles checked; 3 errors, 0 warnings, 3 filtered, 3 badness; has taken 0.1 s =========== Source checksums ---------------- https://github.com/get-iplayer/get_iplayer/archive/v3.34/get_iplayer-3.34.tar.gz : CHECKSUM(SHA256) this package : 72128a0edd731c1b1d932108b3c47c74f93e17ca99915f5c769767344f339be8 CHECKSUM(SHA256) upstream package : 72128a0edd731c1b1d932108b3c47c74f93e17ca99915f5c769767344f339be8 Requires -------- get_iplayer (rpmlib, GLIBC filtered): /usr/bin/ffmpeg /usr/bin/perl AtomicParsley config(get_iplayer) perl(Cwd) perl(Encode) perl(Encode::Locale) perl(Env) perl(Fcntl) perl(File::Basename) perl(File::Copy) perl(File::Path) perl(File::Spec) perl(File::stat) perl(Getopt::Long) perl(HTML::Entities) perl(HTML::Parser) perl(HTTP::Cookies) perl(HTTP::Headers) perl(IO::Seekable) perl(IO::Socket) perl(IPC::Open3) perl(JSON::PP) perl(LWP::ConnCache) perl(LWP::Protocol::https) perl(LWP::UserAgent) perl(List::Util) perl(Mojolicious) perl(POSIX) perl(PerlIO::encoding) perl(Storable) perl(Text::ParseWords) perl(Text::Wrap) perl(Time::Local) perl(Time::Piece) perl(URI) perl(Unicode::Normalize) perl(XML::LibXML) perl(XML::LibXML::XPathContext) perl(base) perl(constant) perl(if) perl(open) perl(strict) perl(version) perl-interpreter Provides -------- get_iplayer: application() application(get_iplayer.desktop) config(get_iplayer) get_iplayer mimehandler(x-scheme-handler/bbc-ipd) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name get_iplayer --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: SugarActivity, Java, PHP, fonts, Ocaml, R, Perl, Haskell, C/C++, Python Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH