Bug 2232861 - Review Request: jsemver - A Java implementation of the Semantic Versioning Specification
Summary: Review Request: jsemver - A Java implementation of the Semantic Versioning Sp...
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2256349
TreeView+ depends on / blocked
 
Reported: 2023-08-19 16:54 UTC by W. Michael Petullo
Modified: 2024-01-01 20:39 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:


Attachments (Terms of Use)

Description W. Michael Petullo 2023-08-19 16:54:27 UTC
Spec URL: https://www.flyn.org/SRPMS/jsemver.spec
SRPM URL: https://www.flyn.org/SRPMS/jsemver-0.9.0-16.fc38.src.rpm
Description: A Java implementation of the Semantic Versioning Specification
Fedora Account System Username: mikep

This package was retired, and I would like to take ownership of it. The only changes I made were to build against the newer Java ABI and drop the maven-javadoc-plugin dependency.

COPR repository:
[copr:copr.fedorainfracloud.org:mikep:lulzbot]
name=Copr repo for lulzbot owned by mikep
baseurl=https://download.copr.fedorainfracloud.org/results/mikep/lulzbot/fedora-$releasever-$basearch/
type=rpm-md
skip_if_unavailable=True
gpgcheck=1
gpgkey=https://download.copr.fedorainfracloud.org/results/mikep/lulzbot/pubkey.gpg
repo_gpgcheck=0
enabled=1
enabled_metadata=1

Comment 1 W. Michael Petullo 2023-08-20 17:05:45 UTC
Spec URL: https://www.flyn.org/SRPMS/jsemver.spec
SRPM URL: https://www.flyn.org/SRPMS/jsemver-0.9.0-1.fc38.src.rpm

- Use %autorelease/%autochangelog
- Use SPDX

Comment 2 Tim Semeijn 2023-10-17 22:34:21 UTC
This is an unofficial review as I am not in the packager group yet.

> Package does not contain duplicates in %files.
> Note: warning: File listed twice: /usr/share/java/jsemver
> See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_duplicate_files

This issue seems a false positive as /usr/share/java/jsemver and /usr/share/maven-poms/jsemver both are folders with the same name but contain different files. This can be ignored.

> License file ADDITIONAL_LICENSE_INFO is not marked as %license
> See: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text

File seems to mention additional licensing requirements regarding an exception to the GPLv2 (GNU Classpath Exception). Please verify how this affects licensing and if acceptable to use mark it as %license under %files.


Note You need to log in before you can comment on or make changes to this bug.