Bug 2097826 - Review Request: perl-Types-ReadOnly - Type constraints and coercions for read-only data structures and locked hashes
Summary: Review Request: perl-Types-ReadOnly - Type constraints and coercions for rea...
Keywords:
Status: ASSIGNED
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Michal Josef Spacek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-06-16 16:15 UTC by Ralf Corsepius
Modified: 2024-05-22 14:44 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:
mspacek: fedora-review?
mspacek: needinfo-


Attachments (Terms of Use)

Description Ralf Corsepius 2022-06-16 16:15:29 UTC
Spec URL: https://corsepiu.fedorapeople.org/packages/perl-Types-ReadOnly.spec
SRPM URL: https://corsepiu.fedorapeople.org/packages/perl-Types-ReadOnly-0.003-1.fc37.src.rpm
Description: 
This is a type constraint library for write-restricted references.

This module is built with Type::Tiny, which means that you can use it
with Moo, Mouse, Moose, or none of the above.

Fedora Account System Username: corsepiu

Comment 1 Ralf Corsepius 2022-06-16 16:16:33 UTC
This package is a so far missing, optional BR: of perl-Types-Tiny.

Comment 2 Michal Josef Spacek 2023-05-22 14:03:55 UTC
There are some issues:
* I think that block with '%if !%{defined perl_bootstrap}' is bad. There are runtime dependencies (Type::Tiny, Type::Coercion, Types::Standard, and Type::Library) that are in Type::Tiny dist. We need to remove if/else (bootstrap) and we need to add this kind of bootstrap block to BuildRequire in perl-Type-Tiny (for perl-Types-ReadOnly, is used in tests only).
* Rewrite license to SPDX
* Remove MODULE_COMPAT line

Optional:
* I am for adding comments like "Runtime:" and "Tests:" to BuildRequire list as in other Perl modules

Comment 3 Package Review 2024-05-22 00:45:30 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time, but it seems
that the review is still being working out by you. If this is right, please
respond to this comment clearing the NEEDINFO flag and try to reach out the
submitter to proceed with the review.

If you're not interested in reviewing this ticket anymore, please clear the
fedora-review flag and reset the assignee, so that a new reviewer can take
this ticket.

Without any reply, this request will shortly be resetted.

Comment 4 Michal Josef Spacek 2024-05-22 10:00:23 UTC
@rc040203 What about this ticket?

Comment 5 Ralf Corsepius 2024-05-22 14:44:51 UTC
(In reply to Michal Josef Spacek from comment #4)
> @rc040203 What about this ticket?

It's still valid.


Note You need to log in before you can comment on or make changes to this bug.