Spec URL: https://agoode.fedorapeople.org/python-pyvips.spec SRPM URL: https://agoode.fedorapeople.org/python-pyvips-2.2.0-1.fc35.src.rpm Description: Python binding for the libvips image processing library Fedora Account System Username: agoode
Hello Adam, thank you for the package. Overall, the package looks very well. > Name: python-pyvips > Version: 2.2.0 > Release: 1%{?dist} This is up to your preference but I would suggest not aligning text into columns like these using TABs. It breaks when another person is using a different TAB width than you. For example, you can try vim python-pyvips.spec :set tabstop=12 or just experimenting with various TAB widths in your favorite editor. When using spaces, the columns are always aligned the same. (This is a different topic from TABs vs spaces for indentation, i.e. whitespace on the beginning of the line. I wouldn't have any suggestions there because I don't want to start a holy war :D) > Version: 2.2.0 There is already version 2.2.1, can you please update? > %global _description %{expand: > %{summary}. > > Programs that use pyvips don't manipulate images directly, instead IMHO there is no reason to have the %{summary} here > %check > %tox I am a bit confused about this but to me, it seems that the tests aren't actually being executed. This happens during a build /usr/bin/python3 -m tox --current-env -q --recreate -e py311 py311: commands succeeded congratulations :) and it happens instantly, in 0 seconds. In comparison, running `tox` inside the git repository, takes much longer and one can see unit tests being executed. > %files -n python3-pyvips -f %{pyproject_files} > %doc README.rst I think we should add %license LICENSE.txt as well
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time, but it seems that the review is still being working out by you. If this is right, please respond to this comment clearing the NEEDINFO flag and try to reach out the submitter to proceed with the review. If you're not interested in reviewing this ticket anymore, please clear the fedora-review flag and reset the assignee, so that a new reviewer can take this ticket. Without any reply, this request will shortly be resetted.
> If you're not interested in reviewing this ticket anymore I am interested in reviewing this ticket but there is no response from the contributor.
Sorry about that. I'll be able to take a look in the next week or so.
I've updated the files on https://agoode.fedorapeople.org/ with the requested changes. Unfortunately, it looks like the build now requires pyperf which isn't available in Fedora, so the package doesn't yet work. I'll see if I can exclude this dependency, or otherwise propose to include pyperf in Fedora.
Ok, I've patched out the dependency (not needed for running the testsuite). https://agoode.fedorapeople.org/python-pyvips-2.2.2-1.fc39.src.rpm https://agoode.fedorapeople.org/python-pyvips.spec
Copr build: https://copr.fedorainfracloud.org/coprs/build/6937242 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2080809-python-pyvips/fedora-rawhide-x86_64/06937242-python-pyvips/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Oops, I guess it doesn't build on rawhide. Let me take another look.
It's going to need some upstream fixes.