Spec URL: https://download.copr.fedorainfracloud.org/results/glaringgibbon/colortest/fedora-rawhide-x86_64/03514616-colortest/colortest.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/glaringgibbon/colortest/fedora-rawhide-x86_64/03514616-colortest/colortest-3.0.4-1.fc37.src.rpm Description: Quickly show all your terminal colours Fedora Account System Username: glaringgibbon
Thank you for the package! Overall, it looks good, but I think a couple of things should be fixed. > * Tue Feb 15 2022 glaringgibbon <glaringgibbon> - 3.0.4-1 I am not sure if it is an enforced policy or not but it is common to put a full name into the changelog entries. See the guidelines for an example https://docs.fedoraproject.org/en-US/packaging-guidelines/#changelogs > Version: 3.0.4 > Source0: https://github.com/pablopunk/%{name}/archive/refs/heads/master.zip You are packaging 3.0.4 version, which is what I would expect but the problem is that you are using different a source tarball. If you look at https://github.com/pablopunk/colortest/commits/master you can see that since the actual 3.0.4 version, multiple commits (9 if I count correctly) have happened. Also, packaging sources from the `master` branch is problematic in another way - each time we would rebuild the package, the sources tarball could be different (if the author pushed some changes in the meantime). You actually want to download the Source0 like this %{URL}/archive/%{version}/%{name}-%{version}.tar.gz See https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_tags I understand why you needed to package `master` instead of the actual version, which is the added LICENSE file. You will probably have to ask upstream to release 3.0.5 version. A few really nitpicky notes - There are two blank lines between sections but between %files and %changelog, there is just one. Also between the email in the changelog and the dash, there is a double space. Otherwise, I tried the package and it works, so cheers!
Will sponsor once the review is done
Thank you very much Michael, I became a sponsor in the meantime as well. But we shall first see how the review turns out.
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time, but it seems that the review is still being working out by you. If this is right, please respond to this comment clearing the NEEDINFO flag and try to reach out the submitter to proceed with the review. If you're not interested in reviewing this ticket anymore, please clear the fedora-review flag and reset the assignee, so that a new reviewer can take this ticket. Without any reply, this request will shortly be resetted.
I am interested in reviewing this ticket but there is no response from the contributor.