Bug 493654 - Following recent color-related changes, System Settings sidebar text doesn't update immediately when changing color schemes
Summary: Following recent color-related changes, System Settings sidebar text doesn't ...
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kirigami
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: Master
Platform: Other Linux
: NOR normal
Target Milestone: Not decided
Assignee: kdelibs bugs
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2024-09-25 20:39 UTC by Nate Graham
Modified: 2024-09-26 15:39 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Colors failed to change after switching from Breeze Light to Breeze Dark (858.30 KB, image/png)
2024-09-25 20:39 UTC, Nate Graham
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2024-09-25 20:39:02 UTC
Created attachment 174078 [details]
Colors failed to change after switching from Breeze Light to Breeze Dark

STEPS TO REPRODUCE
1. systemsettings kcm_colors
2. Switch to an opposite style color scheme (e.g. from light to dark)

OBSERVED RESULT
Sidebar colors fail to change immediately

EXPECTED RESULT
They do change immediately

ADDITIONAL INFORMATION
Leaving the KCM and coming back makes the sidebar text colors change as expected.
Comment 1 Bug Janitor Service 2024-09-26 12:23:40 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kirigami/-/merge_requests/1622
Comment 2 Marco Martin 2024-09-26 15:39:05 UTC
Git commit d3a32c9734c2c283952f398b418f45a9f955336d by Marco Martin.
Committed on 26/09/2024 at 15:34.
Pushed by mart into branch 'master'.

Workaround on incorrect palette update

Needs to be connected to enabledChanged twice to correctly fully update when a
Theme that does inherit becomes temporarly non-inherit and back due to
the item being enabled or disabled

M  +4    -0    src/platform/platformtheme.cpp

https://invent.kde.org/frameworks/kirigami/-/commit/d3a32c9734c2c283952f398b418f45a9f955336d