Add Content-Type for MP4 files (#234)

JosePineiro · mathieucarbou · web-flow · commit 80af24527446 · 2025-07-18T20:17:05.000+02:00
* Add Content-Type for MP4 files

This patch ensures that HTTP responses serving .mp4 files include the correct Content-Type: video/mp4 header. This improves media compatibility across browsers and clients, and adheres to standard MIME type conventions for MP4 files. No changes were made outside of content-type handling for MP4.
If the correct content type is not sent, many browsers will ignore the Content-Disposition: inline header and download the file instead of playing it in-browser. In such cases, the browser assumes it cannot render the content inline and defaults to download behavior. This fix ensures MP4 files are properly recognized and played directly in the browser when expected.

* Add files via upload

* Update literals.h

---------

Co-authored-by: Mathieu Carbou &lt;mathieu.carbou@gmail.com&gt;
diff --git a/src/WebResponses.cpp b/src/WebResponses.cpp
@@ -680,6 +680,8 @@ void AsyncFileResponse::_setContentTypeFromPath(const String &path) {
     _contentType = T_text_xml;
   } else if (strcmp(dot, T__pdf) == 0) {
     _contentType = T_application_pdf;
+  } else if (strcmp(dot, T__mp4) == 0) {
+    _contentType = T_video_mp4;
   } else if (strcmp(dot, T__zip) == 0) {
     _contentType = T_application_zip;
   } else if (strcmp(dot, T__gz) == 0) {
diff --git a/src/literals.h b/src/literals.h
@@ -114,6 +114,7 @@ static constexpr const char *T__ico = ".ico";
 static constexpr const char *T__jpg = ".jpg";
 static constexpr const char *T__js = ".js";
 static constexpr const char *T__json = ".json";
+static constexpr const char *T__mp4 = ".mp4";
 static constexpr const char *T__pdf = ".pdf";
 static constexpr const char *T__png = ".png";
 static constexpr const char *T__svg = ".svg";
@@ -145,6 +146,7 @@ static constexpr const char *T_text_css = "text/css";
 static constexpr const char *T_text_event_stream = "text/event-stream";
 static constexpr const char *T_text_html = "text/html";
 static constexpr const char *T_text_plain = "text/plain";
+static constexpr const char *T_video_mp4 = "video/mp4";
 static constexpr const char *T_text_xml = "text/xml";
 
 // Response codes
