Changeset 103661 in webkit

Timestamp:

Dec 24, 2011, 12:29:30 PM (14 years ago)

Author:

[email protected]

Message:

Allow XMLHttpRequest withCredentials to be set prior to a call to open()
​https://bugs.webkit.org/show_bug.cgi?id=75194

Source/WebCore:

XMLHttpRequest.withCredentials attribute should be modifiable prior to the OPENED state per
the W3C spec. See ​http://dvcs.w3.org/hg/xhr/raw-file/tip/Overview.html#the-withcredentials-attribute

Reviewed by Alexey Proskuryakov.

Test: fast/xmlhttprequest/xmlhttprequest-withcredentials-before-open.html

• xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::setWithCredentials):
Prevent setting the value only after the OPENED state.

LayoutTests:

Reviewed by Alexey Proskuryakov.

• fast/xmlhttprequest/xmlhttprequest-withcredentials-before-open-expected.txt: Added.
• fast/xmlhttprequest/xmlhttprequest-withcredentials-before-open.html: Added.

Validate that XMLHttpRequest.withCredentials can be set prior to a call to open().

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/xmlhttprequest/xmlhttprequest-withcredentials-before-open-expected.txt (added)
• LayoutTests/fast/xmlhttprequest/xmlhttprequest-withcredentials-before-open.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/xml/XMLHttpRequest.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-12-24  Jarred Nicholls  <[email protected]>
+
+        Allow XMLHttpRequest withCredentials to be set prior to a call to open()
+        https://bugs.webkit.org/show_bug.cgi?id=75194
+
+        Reviewed by Alexey Proskuryakov.
+
+        * fast/xmlhttprequest/xmlhttprequest-withcredentials-before-open-expected.txt: Added.
+        * fast/xmlhttprequest/xmlhttprequest-withcredentials-before-open.html: Added.
+        Validate that XMLHttpRequest.withCredentials can be set prior to a call to open().
+
 2011-12-24  Ryosuke Niwa  <[email protected]>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-12-24  Jarred Nicholls  <[email protected]>
+
+        Allow XMLHttpRequest withCredentials to be set prior to a call to open()
+        https://bugs.webkit.org/show_bug.cgi?id=75194
+
+        XMLHttpRequest.withCredentials attribute should be modifiable prior to the OPENED state per
+        the W3C spec. See http://dvcs.w3.org/hg/xhr/raw-file/tip/Overview.html#the-withcredentials-attribute
+
+        Reviewed by Alexey Proskuryakov.
+
+        Test: fast/xmlhttprequest/xmlhttprequest-withcredentials-before-open.html
+
+        * xml/XMLHttpRequest.cpp:
+        (WebCore::XMLHttpRequest::setWithCredentials):
+        Prevent setting the value only after the OPENED state.
+
 2011-12-24  Andreas Kling  <[email protected]>
 

trunk/Source/WebCore/xml/XMLHttpRequest.cpp

@@ -378 +378 @@
 void XMLHttpRequest::setWithCredentials(bool value, ExceptionCode& ec)
 {
-    if (m_state != OPENED || m_loader) {
+    if (m_state > OPENED || m_loader) {
         ec = INVALID_STATE_ERR;
         return;