Changeset 103631 in webkit

Timestamp:

Dec 23, 2011, 9:01:47 AM (14 years ago)

Author:

Simon Fraser

Message:

Blur filter doesn't invalidate enough
​https://bugs.webkit.org/show_bug.cgi?id=74891

Source/WebCore:

Reviewed by Darin Adler.

Take the effects of filters into account for repainting; we need
to inflate the repaint rect by the outsets provided by the filter.

Test: css3/filters/filter-repaint.html

• rendering/RenderBox.cpp:

(WebCore::RenderBox::computeRectForRepaint):

• rendering/RenderInline.cpp:

(WebCore::RenderInline::computeRectForRepaint):

LayoutTests:

Reviewed by Darin Adler.

Repaint test for the effects of a blur filter.

• css3/filters/filter-repaint-expected.txt: Added.
• css3/filters/filter-repaint-expected.png: Added.
• css3/filters/filter-repaint.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/css3/filters/filter-repaint-expected.png (added)
• LayoutTests/css3/filters/filter-repaint-expected.txt (added)
• LayoutTests/css3/filters/filter-repaint.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderBox.cpp (modified) (1 diff)
• Source/WebCore/rendering/RenderInline.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-12-23  Simon Fraser  <[email protected]>
+
+        Blur filter doesn't invalidate enough
+        https://bugs.webkit.org/show_bug.cgi?id=74891
+
+        Reviewed by Darin Adler.
+        
+        Repaint test for the effects of a blur filter.
+
+        * css3/filters/filter-repaint-expected.txt: Added.
+        * css3/filters/filter-repaint-expected.png: Added.
+        * css3/filters/filter-repaint.html: Added.
+
 2011-12-23  Simon Fraser  <[email protected]>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-12-23  Simon Fraser  <[email protected]>
+
+        Blur filter doesn't invalidate enough
+        https://bugs.webkit.org/show_bug.cgi?id=74891
+
+        Reviewed by Darin Adler.
+        
+        Take the effects of filters into account for repainting; we need
+        to inflate the repaint rect by the outsets provided by the filter.
+        
+        Test: css3/filters/filter-repaint.html
+
+        * rendering/RenderBox.cpp:
+        (WebCore::RenderBox::computeRectForRepaint):
+        * rendering/RenderInline.cpp:
+        (WebCore::RenderInline::computeRectForRepaint):
+
 2011-12-23  Simon Fraser  <[email protected]>
 

trunk/Source/WebCore/rendering/RenderBox.cpp

@@ -1568 +1568 @@
     if (isWritingModeRoot() && !isPositioned())
         flipForWritingMode(rect);
+
+#if ENABLE(CSS_FILTERS)
+    if (style()->hasFilterOutsets()) {
+        LayoutUnit topOutset;
+        LayoutUnit rightOutset;
+        LayoutUnit bottomOutset;
+        LayoutUnit leftOutset;
+        style()->filter().getOutsets(topOutset, rightOutset, bottomOutset, leftOutset);
+        rect.move(-leftOutset, -topOutset);
+        rect.expand(leftOutset + rightOutset, topOutset + bottomOutset);
+    }
+#endif
+
     LayoutPoint topLeft = rect.location();
     topLeft.move(x(), y());

trunk/Source/WebCore/rendering/RenderInline.cpp

@@ -1064 +1064 @@
     }
 
+#if ENABLE(CSS_FILTERS)
+    if (style()->hasFilterOutsets()) {
+        LayoutUnit topOutset;
+        LayoutUnit rightOutset;
+        LayoutUnit bottomOutset;
+        LayoutUnit leftOutset;
+        style()->filter().getOutsets(topOutset, rightOutset, bottomOutset, leftOutset);
+        rect.move(-leftOutset, -topOutset);
+        rect.expand(leftOutset + rightOutset, topOutset + bottomOutset);
+    }
+#endif
+
     if (style()->position() == RelativePosition && layer()) {
         // Apply the relative position offset when invalidating a rectangle.  The layer