Changeset 103630 in webkit

Timestamp:

Dec 23, 2011, 8:56:35 AM (14 years ago)

Author:

Simon Fraser

Message:

Filters should apply to inline elements
​https://bugs.webkit.org/show_bug.cgi?id=75152

Source/WebCore:

Reviewed by Darin Adler.

Filters need to cause creation of RenderLayers for inlines, just like
opacity and masks do.

Test: css3/filters/filtered-inline.html

• rendering/RenderInline.h:

(WebCore::RenderInline::requiresLayer):

• rendering/RenderTableRow.h: Remove an obviously incorrect comment.

LayoutTests:

Reviewed by Darin Adler.

Test for filter on an inline.

• css3/filters/filtered-inline-expected.png: Added.
• css3/filters/filtered-inline-expected.txt: Added.
• css3/filters/filtered-inline.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/css3/filters/filtered-inline-expected.png (added)
• LayoutTests/css3/filters/filtered-inline-expected.txt (added)
• LayoutTests/css3/filters/filtered-inline.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderInline.h (modified) (1 diff)
• Source/WebCore/rendering/RenderTableRow.h (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-12-23  Simon Fraser  <[email protected]>
+
+        Filters should apply to inline elements
+        https://bugs.webkit.org/show_bug.cgi?id=75152
+
+        Reviewed by Darin Adler.
+        
+        Test for filter on an inline.
+
+        * css3/filters/filtered-inline-expected.png: Added.
+        * css3/filters/filtered-inline-expected.txt: Added.
+        * css3/filters/filtered-inline.html: Added.
+
 2011-12-23  Jarred Nicholls  <[email protected]>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-12-23  Simon Fraser  <[email protected]>
+
+        Filters should apply to inline elements
+        https://bugs.webkit.org/show_bug.cgi?id=75152
+
+        Reviewed by Darin Adler.
+        
+        Filters need to cause creation of RenderLayers for inlines, just like
+        opacity and masks do.
+
+        Test: css3/filters/filtered-inline.html
+
+        * rendering/RenderInline.h:
+        (WebCore::RenderInline::requiresLayer):
+        * rendering/RenderTableRow.h: Remove an obviously incorrect comment.
+
 2011-12-23  Jarred Nicholls  <[email protected]>
 

trunk/Source/WebCore/rendering/RenderInline.h

@@ -120 +120 @@
     virtual bool nodeAtPoint(const HitTestRequest&, HitTestResult&, const LayoutPoint& pointInContainer, const LayoutPoint& accumulatedOffset, HitTestAction);
 
-    virtual bool requiresLayer() const { return isRelPositioned() || isTransparent() || hasMask(); }
+    virtual bool requiresLayer() const { return isRelPositioned() || isTransparent() || hasMask() || hasFilter(); }
 
     virtual LayoutUnit offsetLeft() const;

trunk/Source/WebCore/rendering/RenderTableRow.h

@@ -57 +57 @@
     virtual bool nodeAtPoint(const HitTestRequest&, HitTestResult&, const LayoutPoint& pointInContainer, const LayoutPoint& accumulatedOffset, HitTestAction);
 
-    // The only time rows get a layer is when they have transparency.
     virtual bool requiresLayer() const { return isTransparent() || hasOverflowClip() || hasTransform() || hasMask() || hasFilter(); }