Menu
▾
▴
#101 <!-- Comments --> support
Let HTMLParser handler comment sections - let
HTMLParser.HtmlUnitDOMBuilder implement the
LexicalHandler interface.
I have implemented the LexicalHandler interface in
HTMLParser.HtmlUnitDOMBuilder, created the DomComment
class and a junit test class for it.
My LexicalHandler implementation handles comments only,
CDATA sections, Entities and DTDs are ignored. Is this
enough for code submit ? Should I attach the patches ?
I think it's better to have something (comments
support) than nothing.
Logged In: YES
user_id=402164
As long as this is an improvement to current state, your
patch is welcome. Further improvements may come later.
DomComment support.
Logged In: YES
user_id=402164
Patch applied. Thanks.
I haven't received any notification from SF when you've
attached the patch else I could have applied it earlier.
Logged In: YES
user_id=1612820
I noticed that some of the files (e.g. DomComment) contain
"@version $Revision$" whereas others "@version $Revision:
1268 $" version info. Which is the right way to specifiy
@version info so that it's autoupdated by svn (if that
what's hapenning in the latter case) ?
And thanks for applying the patch, it makes work easier when
working with a local htmlunit branch and upgrading to a new
htmlunit version.
Logged In: YES
user_id=402164
Under SVN, keyword expansion occurs only if property
svn:keywords is set and this was missing on the new files.
This should now be fixed.
Logged In: YES
user_id=1612820
Originator: YES
I'm uploading another patch, innerHTML support for comments was broken in my former code submit.
This patch fixes the problem, a test case (HTMLElementTest.java) that fails without the patch applied and passes with the patched version is attached.
Logged In: YES
user_id=402164
Originator: NO
Patch applied. Thanks. I haven't added any extra comment in change log as your first patch belongs to the changes for next release too.