Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rspec/rspec-rails
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.8.1
Choose a base ref
...
head repository: rspec/rspec-rails
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.8.2
Choose a head ref
  • 16 commits
  • 20 files changed
  • 9 contributors

Commits on Dec 26, 2018

  1. Use Rubygems 2.7.8 (avoid Rubygems 3) (#2051)

    @greysteil @JonRowe
    greysteil authored and JonRowe committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    bfd3374 View commit details
    Browse the repository at this point in the history

  2. removed rails 5.0 check for mailer preview generator (#2037) 

    * removed rails 5.0 check for mailer preview generator

* Add test fot mailer generator
    @koheisg @JonRowe
    koheisg authored and JonRowe committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    aa53007 View commit details
    Browse the repository at this point in the history

  3. Changelog for #2037

    @JonRowe
    JonRowe committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    1406a8a View commit details
    Browse the repository at this point in the history

  4. Error message language: call them system specs (#2053)

    @olleolleolle @JonRowe
    olleolleolle authored and JonRowe committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    c7d9f86 View commit details
    Browse the repository at this point in the history

  5. Fix generate request spec name has / (#2057) 

    Use `name.underscore.pluralize` instead of file and table name to handle the case where generating request specs for name spaced files
    @koheisg @JonRowe
    koheisg authored and JonRowe committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    71a1a91 View commit details
    Browse the repository at this point in the history

  6. Changelog for #2057

    @JonRowe
    JonRowe committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    7cc0166 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2019

  1. Truncate method names further in system tests (#2058) 

    * Truncate method names further in system tests

ref: https://github.com/rspec/rspec-rails/pull/1999/files

If system test fails, a screenshot is taken, but if the file name exceeds 255 characters(e.g. using turnip), the following error will be output.

```
File name too long @ rb_sysopen
```

The file name is prepended with `failures_` so further truncation is needed.
    @benoittgt
    Takumi Kaji authored and benoittgt committed Jan 13, 2019
    Configuration menu
    Copy the full SHA
    85b16c4 View commit details
    Browse the repository at this point in the history

  2. Change log for #2058

    @JonRowe @benoittgt
    JonRowe authored and benoittgt committed Jan 13, 2019
    Configuration menu
    Copy the full SHA
    79925f9 View commit details
    Browse the repository at this point in the history

  3. Updated travis build scripts (from rspec-dev) (#2059)

    @JonRowe @benoittgt
    JonRowe authored and benoittgt committed Jan 13, 2019
    Configuration menu
    Copy the full SHA
    75c02f8 View commit details
    Browse the repository at this point in the history

  4. Updated travis build scripts (from rspec-dev)

    @JonRowe @benoittgt
    JonRowe authored and benoittgt committed Jan 13, 2019
    Configuration menu
    Copy the full SHA
    081cce5 View commit details
    Browse the repository at this point in the history

  5. Add dependency for rspec-rails on bundler / rubygems script

    @JonRowe @benoittgt
    JonRowe authored and benoittgt committed Jan 13, 2019
    Configuration menu
    Copy the full SHA
    1c6074f View commit details
    Browse the repository at this point in the history

  6. Downgrade to older bundler on older rails

    @JonRowe @benoittgt
    JonRowe authored and benoittgt committed Jan 13, 2019
    Configuration menu
    Copy the full SHA
    7ca3d04 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2019

  1. Backport: Change negated active job matcher (#2069) 

    This is a partial backport of #2069 that doesn't include changes on
"have_enqueued_mail" tests.

When expecting no job to be enqueued, the matcher would expect exactly
one job not to have been enqueued. This commit changes so that it now expects
no jobs to have been enqueued.
    @Istanful @benoittgt
    Istanful authored and benoittgt committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    9271c22 View commit details
    Browse the repository at this point in the history

  2. Backport: Changelog for #2047

    @JonRowe @benoittgt
    JonRowe authored and benoittgt committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    2ae472b View commit details
    Browse the repository at this point in the history

  3. Update version to 3.8.2

    @benoittgt
    benoittgt committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    987bd32 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #2067 from benoittgt/3-8-maintenance-prep 

    3.8.2 release
    @benoittgt
    benoittgt authored Jan 17, 2019
    Configuration menu
    Copy the full SHA
    0d0ce9e View commit details
    Browse the repository at this point in the history
Loading