Fix the missing table sync due to improper invalidation handling.
authorAmit Kapila <[email protected]>
Thu, 25 Apr 2024 05:10:52 +0000 (10:40 +0530)
committerAmit Kapila <[email protected]>
Thu, 25 Apr 2024 05:10:52 +0000 (10:40 +0530)
commitaa79bde725650b4cfdce05bcc119008709590af6
treeeb5a0c37816ab93700d16708da0fbe692ce7b759
parentee3ef4af19d8ba140a8b33c6598d470d36eec10c
Fix the missing table sync due to improper invalidation handling.

We missed performing table sync if the invalidation happened while the
non-ready tables list was being prepared. This occurs because the sync
state was set to valid at the end of non-ready table list preparation
irrespective of the invalidations processed while the list is being
prepared.

Fix it by changing the boolean variable to a tri-state enum and by setting
table state to valid only if no invalidations have occurred while the list
is being prepared.

Reprted-by: Alexander Lakhin
Diagnosed-by: Alexander Lakhin
Author: Vignesh C
Reviewed-by: Hou Zhijie, Alexander Lakhin, Ajin Cherian, Amit Kapila
Backpatch-through: 15
Discussion: https://postgr.es/m/711a6afe-edb7-1211-cc27-1bef8239eec7@gmail.com
src/backend/replication/logical/tablesync.c
src/tools/pgindent/typedefs.list