diff options
author | Bruce Momjian | 2003-06-25 01:09:24 +0000 |
---|---|---|
committer | Bruce Momjian | 2003-06-25 01:09:24 +0000 |
commit | e9cb28c5179a937f4e81b8389ef1a01d371cf5c9 (patch) | |
tree | baa0ca8066808adac9c1f316d8153c047fa9e82f | |
parent | 4f1a206b829760760b2cb020d1b9043e7751dd51 (diff) |
This is a bug in python interface module,
postgresql-7.3.3/src/interfaces/python/pg.py.
_quote() function fails due to integer overflow if input d is larger
than max integer.
In the case where the column type is "BIGINT", the input d may very well
be larger than max integer while its type, t, is labeled 'int'.
The conversion on line 19, return "%d" % int(d), will fail due to
"OverflowError: long int too large to convert to int".
Please describe a way to repeat the problem. Please try to provide a
concise reproducible example, if at all possible:
----------------------------------------------------------------------
[1] create a table with a column type 'BIGINT'.
[2] use pg.DB.insert() to insert a value that is larger than max integer
If you know how this problem might be fixed, list the solution below:
---------------------------------------------------------------------
Just changing the conversion at line 19 of pg.py to long(d) instead of
int(d) should fix it. The following is a patch:
Chih-Hao Huang
-rw-r--r-- | src/interfaces/python/pg.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/interfaces/python/pg.py b/src/interfaces/python/pg.py index 5fd36eed34..0380dc4de9 100644 --- a/src/interfaces/python/pg.py +++ b/src/interfaces/python/pg.py @@ -17,7 +17,7 @@ def _quote(d, t): if t in ['int', 'seq']: if d == "": return "NULL" - return "%d" % int(d) + return "%d" % long(d) if t == 'decimal': if d == "": return "NULL" |