diff options
| author | Andrew Dunstan | 2009-07-25 13:35:32 +0000 |
|---|---|---|
| committer | Andrew Dunstan | 2009-07-25 13:35:32 +0000 |
| commit | b197237b7943561f9ac8d99f7a6a2d51bf22e24b (patch) | |
| tree | 316302841d7428114a2d5b688959519960df0ee0 | |
| parent | a04d1c68b9b32a07fe07e85fad2d70dc516466b0 (diff) | |
Small stylistic improvement in recent FORCE QUOTE * code - use a bool instead of a magic value.
| -rw-r--r-- | src/backend/commands/copy.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/src/backend/commands/copy.c b/src/backend/commands/copy.c index 9ee8ea2c82..f74eb35937 100644 --- a/src/backend/commands/copy.c +++ b/src/backend/commands/copy.c @@ -729,9 +729,7 @@ DoCopy(const CopyStmt *stmt, const char *queryString) TupleDesc tupDesc; int num_phys_attrs; uint64 processed; - - /* a dummy list that represents 'all-columns' */ - List all_columns = { T_List }; + bool force_quote_all = false; /* Allocate workspace and zero all fields */ cstate = (CopyStateData *) palloc0(sizeof(CopyStateData)); @@ -813,7 +811,7 @@ DoCopy(const CopyStmt *stmt, const char *queryString) errmsg("conflicting or redundant options"))); if (IsA(defel->arg, A_Star)) - force_quote = &all_columns; + force_quote_all = true; else force_quote = (List *) defel->arg; } @@ -1099,7 +1097,7 @@ DoCopy(const CopyStmt *stmt, const char *queryString) /* Convert FORCE QUOTE name list to per-column flags, check validity */ cstate->force_quote_flags = (bool *) palloc0(num_phys_attrs * sizeof(bool)); - if (force_quote == &all_columns) + if (force_quote_all) { int i; |