> There is an ugly little problem with the DB wrapper class.

>
> In pg.py the attributes of DB are defined as being the same as
> the attributes of the corresponding pgobject "db", using the following

...

> The problem is that the attributes of db (which are read only)
> are not static (they are actually function calls to PostgreSQL),
> especially "status" and "error", but those attributes are copied
> and this is done only once when initializing the DB object.
>
> So, in effect, only the attribute "db.error" of a DB instance
> will be updated, but not the attribute "error". Same with "status".


> Don't copy the (read only) attributes of the pgobject to the
> DB object, but only the methods, and all of them, like this:
>
> --------------- change in pg.py ------------------
> # Create convience methods, in a way that is still overridable.
> for e in self.db.__methods__:
>  setattr(self, e, getattr(self.db, e))
> ----------------------------------------------------
>
> Furthermore, make an addition to the documentation of the
> DB wrapper class (i.e. in pygresql-pg-db.html):
> After the sentence "All pgobject methods are included in this class also."
> add the following sentence "The pgobject read-only attributes can be
> accessed py adding the prefix 'db.' to them."

Christoph Zwerschke

2 files changed, 15 insertions, 14 deletions

diff --git a/doc/src/sgml/pygresql.sgml b/doc/src/sgml/pygresql.sgml
index 7db5a8c7bd..eba7ed553d 100644
--- a/doc/src/sgml/pygresql.sgml
+++ b/doc/src/sgml/pygresql.sgml
@@ -2413,12 +2413,17 @@ loimport(<parameter>filename</parameter>)
   <title>Database Wrapper Class: <classname>DB</classname></title>
 
   <para>
-   <classname>pg</classname> module contains a class called
-   <classname>DB</classname>.  All <classname>pgobject</classname>
-   methods are included in this class also.  A number of additional
-   <classname>DB</classname> class methods are described below.  The
-   preferred way to use this module is as follows (See description of
-   the initialization method below.):
+   The <literal>pg</literal> module contains a class called
+   <classname>DB</classname> wrapping a <classname>pgobject</classname>.
+   This <classname>pgobject</classname> can be addressed as a
+   <classname>DB</classname> class member named <varname>db</varname>
+   to get access to the read-only attributes of the corresponding connection
+   (e.g. <varname>db.error</varname>).  All <classname>pgobject</classname>
+   methods (e.g. <function>query()</function>) are directly included as members
+   in the class <classname>DB</classname> also.  A number of additional
+   higher level <classname>DB</classname> class methods are described below.
+   The preferred way to use this module is as follows  (see description of the
+   initialization method below):
 
 <programlisting>
 import pg
diff --git a/src/interfaces/python/pg.py b/src/interfaces/python/pg.py
index df502397fa..0e40a6e5a4 100644
--- a/src/interfaces/python/pg.py
+++ b/src/interfaces/python/pg.py
@@ -48,14 +48,10 @@ class DB:
 	def __init__(self, *args, **kw):
 		self.db = apply(connect, args, kw)
 
-		# Create convience methods, in a way that is still overridable.
-		for e in ( 'query', 'reset', 'close', 'getnotify', 'inserttable',
-					'putline', 'getline', 'endcopy',
-					'host', 'port', 'db', 'options', 
-					'tty', 'error', 'status', 'user',
-					'locreate', 'getlo', 'loimport' ):
-			if not hasattr(self,e) and hasattr(self.db,e):
-				exec 'self.%s = self.db.%s' % ( e, e )
+		# Create convience methods, in a way that is still overridable
+		# (members are not copied because they are actually functions)
+		for e in self.db.__methods__:
+			setattr(self, e, getattr(self.db, e))
 
 		self.__attnames__ = {}
 		self.__pkeys__ = {}